| Message ID | 202301281453121890132@zte.com.cn (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | i2c: xiic: Use devm_platform_get_and_ioremap_resource() | expand |
On 1/28/23 07:53, ye.xingchen@zte.com.cn wrote: > > From: ye xingchen <ye.xingchen@zte.com.cn> > > Convert platform_get_resource(), devm_ioremap_resource() to a single > call to devm_platform_get_and_ioremap_resource(), as this is exactly > what this function does. > > Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn> note: in my part of world name is starting with upper letter > --- > drivers/i2c/busses/i2c-xiic.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c > index bee5a2ef1f22..5114888f2916 100644 > --- a/drivers/i2c/busses/i2c-xiic.c > +++ b/drivers/i2c/busses/i2c-xiic.c > @@ -752,7 +752,6 @@ static int xiic_i2c_probe(struct platform_device *pdev) > { > struct xiic_i2c *i2c; > struct xiic_i2c_platform_data *pdata; > - struct resource *res; > int ret, irq; > u8 i; > u32 sr; > @@ -761,8 +760,7 @@ static int xiic_i2c_probe(struct platform_device *pdev) > if (!i2c) > return -ENOMEM; > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - i2c->base = devm_ioremap_resource(&pdev->dev, res); > + i2c->base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL); > if (IS_ERR(i2c->base)) > return PTR_ERR(i2c->base); > > -- > 2.25.1 Reviewed-by: Michal Simek <michal.simek@amd.com> Thanks, Michal
On Sat, Jan 28, 2023 at 02:53:12PM +0800, ye.xingchen@zte.com.cn wrote: > From: ye xingchen <ye.xingchen@zte.com.cn> > > Convert platform_get_resource(), devm_ioremap_resource() to a single > call to devm_platform_get_and_ioremap_resource(), as this is exactly > what this function does. > > Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn> Could you kindly rebase this to i2c/for-next or i2c/for-mergewindow? An earlier series for xiic has been applied there. Thanks!
diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index bee5a2ef1f22..5114888f2916 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c @@ -752,7 +752,6 @@ static int xiic_i2c_probe(struct platform_device *pdev) { struct xiic_i2c *i2c; struct xiic_i2c_platform_data *pdata; - struct resource *res; int ret, irq; u8 i; u32 sr; @@ -761,8 +760,7 @@ static int xiic_i2c_probe(struct platform_device *pdev) if (!i2c) return -ENOMEM; - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - i2c->base = devm_ioremap_resource(&pdev->dev, res); + i2c->base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL); if (IS_ERR(i2c->base)) return PTR_ERR(i2c->base);