| Message ID | 20230201113603.293758-9-miquel.raynal@bootlin.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mtd: spi-nor: read while write support | expand |
Hi, Jaime, Miquel, Any news with the datasheet, can you send me a copy of it? On 2/1/23 11:36, Miquel Raynal wrote: > Describe this new part and provide the RWW flag for it. > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > --- > drivers/mtd/spi-nor/macronix.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mtd/spi-nor/macronix.c b/drivers/mtd/spi-nor/macronix.c > index 6853ec9ae65d..655e7eec865c 100644 > --- a/drivers/mtd/spi-nor/macronix.c > +++ b/drivers/mtd/spi-nor/macronix.c > @@ -82,6 +82,9 @@ static const struct flash_info macronix_nor_parts[] = { > { "mx25u51245g", INFO(0xc2253a, 0, 64 * 1024, 1024) > NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) > FIXUP_FLAGS(SPI_NOR_4B_OPCODES) }, > + { "mx25uw51245g", INFOB(0xc2813a, 0, 16 * 1024, 1024, 4) > + NO_SFDP_FLAGS(SECT_4K | SPI_NOR_RWW) > + FIXUP_FLAGS(SPI_NOR_4B_OPCODES) }, Is this flash not really supporting SFDP? We ask people that update or add new flash entries to do a erase, verify erase, write, read back and compare test. Also to dump the sysfs entries. Here's how to do that: https://lore.kernel.org/lkml/97a3b023-b9bc-c34d-45a4-ddd56f47bd76@microchip.com/T/ Thanks, ta
Hi Tudor > > Hi, Jaime, Miquel, > > Any news with the datasheet, can you send me a copy of it? > > On 2/1/23 11:36, Miquel Raynal wrote: > > Describe this new part and provide the RWW flag for it. > > > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > > --- > > drivers/mtd/spi-nor/macronix.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/mtd/spi-nor/macronix.c b/drivers/mtd/spi-nor/macronix.c > > index 6853ec9ae65d..655e7eec865c 100644 > > --- a/drivers/mtd/spi-nor/macronix.c > > +++ b/drivers/mtd/spi-nor/macronix.c > > @@ -82,6 +82,9 @@ static const struct flash_info macronix_nor_parts[] = { > > { "mx25u51245g", INFO(0xc2253a, 0, 64 * 1024, 1024) > > NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) > > FIXUP_FLAGS(SPI_NOR_4B_OPCODES) }, > > + { "mx25uw51245g", INFOB(0xc2813a, 0, 16 * 1024, 1024, 4) > > + NO_SFDP_FLAGS(SECT_4K | SPI_NOR_RWW) > > + FIXUP_FLAGS(SPI_NOR_4B_OPCODES) }, > > Is this flash not really supporting SFDP? Yap MX25UW51245G have SFDP table support. As below is the link of octal DTR feature patch which include MX25UW51245G SFDP information. https://patchwork.ozlabs.org/project/uboot/patch/20220718064922.20193-2-jaimeliao.tw@gmail.com/ Sorry for that I can't share the link of datasheet cause Macronix didn't make it public. > > We ask people that update or add new flash entries to do a erase, verify > erase, write, read back and compare test. Also to dump the sysfs > entries. Here's how to do that: > > https://lore.kernel.org/lkml/97a3b023-b9bc-c34d-45a4-ddd56f47bd76@microchip.com/T/ > > Thanks, > ta Thanks Jaime
On 3/17/23 07:43, liao jaime wrote: > Hi Tudor > >> >> Hi, Jaime, Miquel, >> >> Any news with the datasheet, can you send me a copy of it? >> >> On 2/1/23 11:36, Miquel Raynal wrote: >>> Describe this new part and provide the RWW flag for it. >>> >>> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> >>> --- >>> drivers/mtd/spi-nor/macronix.c | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/drivers/mtd/spi-nor/macronix.c b/drivers/mtd/spi-nor/macronix.c >>> index 6853ec9ae65d..655e7eec865c 100644 >>> --- a/drivers/mtd/spi-nor/macronix.c >>> +++ b/drivers/mtd/spi-nor/macronix.c >>> @@ -82,6 +82,9 @@ static const struct flash_info macronix_nor_parts[] = { >>> { "mx25u51245g", INFO(0xc2253a, 0, 64 * 1024, 1024) >>> NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) >>> FIXUP_FLAGS(SPI_NOR_4B_OPCODES) }, >>> + { "mx25uw51245g", INFOB(0xc2813a, 0, 16 * 1024, 1024, 4) >>> + NO_SFDP_FLAGS(SECT_4K | SPI_NOR_RWW) >>> + FIXUP_FLAGS(SPI_NOR_4B_OPCODES) }, >> >> Is this flash not really supporting SFDP? > Yap MX25UW51245G have SFDP table support. Okay, then for the next iteration of the series we should have PARSE_SFDP set. > As below is the link of octal DTR feature patch which include > MX25UW51245G SFDP information. > > https://patchwork.ozlabs.org/project/uboot/patch/20220718064922.20193-2-jaimeliao.tw@gmail.com/ cool, thanks. I'd also like an erase, verify erase, write, read back and compare test if possible, just to make sure that the flash works in it's first day. Obviously in linux, not u-boot. The how is in the link below. > > Sorry for that I can't share the link of datasheet cause Macronix > didn't make it public. Ok, no worries. Cheers, ta >> >> We ask people that update or add new flash entries to do a erase, verify >> erase, write, read back and compare test. Also to dump the sysfs >> entries. Here's how to do that: >> >> https://lore.kernel.org/lkml/97a3b023-b9bc-c34d-45a4-ddd56f47bd76@microchip.com/T/ >> >> Thanks, >> ta > Thanks > Jaime
diff --git a/drivers/mtd/spi-nor/macronix.c b/drivers/mtd/spi-nor/macronix.c index 6853ec9ae65d..655e7eec865c 100644 --- a/drivers/mtd/spi-nor/macronix.c +++ b/drivers/mtd/spi-nor/macronix.c @@ -82,6 +82,9 @@ static const struct flash_info macronix_nor_parts[] = { { "mx25u51245g", INFO(0xc2253a, 0, 64 * 1024, 1024) NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) FIXUP_FLAGS(SPI_NOR_4B_OPCODES) }, + { "mx25uw51245g", INFOB(0xc2813a, 0, 16 * 1024, 1024, 4) + NO_SFDP_FLAGS(SECT_4K | SPI_NOR_RWW) + FIXUP_FLAGS(SPI_NOR_4B_OPCODES) }, { "mx25v8035f", INFO(0xc22314, 0, 64 * 1024, 16) NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
Describe this new part and provide the RWW flag for it. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- drivers/mtd/spi-nor/macronix.c | 3 +++ 1 file changed, 3 insertions(+)