From patchwork Wed Feb 1 14:26:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergey Organov X-Patchwork-Id: 13124459 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0D4DC636CD for ; Wed, 1 Feb 2023 14:43:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cfttro3fKjL3EtZ23jbiTctWXf35PbcbYykqMfp8r14=; b=Q0wQn5/ejcEG4f ROVNUMrsIzT6zumTG41ZNJ2N+nq9w2XOJcq40fEN4bI/c/e1BWaEftXdc/a9ezMSeUWkIuRyFJ3r4 hiF8JeV+kJirvOdrLdqVmCJfPI0v17DptsygaCiit82ECLL6GlejdkwV3lwcpkUFW7TA/oU7VhygJ elwQFYsBkO51A829PEC6gXpm2fwPchu5TjDBg/WZfNMbeNzCLxnCRCqD7RnPmfZI5V3emMlr5Uh8V FBOfaApaEuoH7vQVroXQPGU3U4zaVsw/1SnYVlwFNd2tXvqb16ssq85k1QkVVXcjFSBTBz2prkAX7 w9cpD5/zcpAENTjT96KQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNEJD-00CRvp-Hl; Wed, 01 Feb 2023 14:42:00 +0000 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNE5T-00CLop-Re for linux-arm-kernel@lists.infradead.org; Wed, 01 Feb 2023 14:27:49 +0000 Received: by mail-ed1-x535.google.com with SMTP id fi26so17845151edb.7 for ; Wed, 01 Feb 2023 06:27:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vxyxFeq00JGhfZF3lbLUVUOmxZ61KQdQmUjeiwFbgw8=; b=TqxSdo+txye/hH+JqDPj5+BHdWVeRBNc0K8jgGttCeHsb3yXb7k+vU36AzeDltqy3v 9tebe7abB0jDHhCl/7e23/HfrTJI4COPeIxtOr5YPWXChODWdRRPYf0PYmNpipTyH7fL CgQSOYJTfF9CPoRmwvjw9GJqQQXYOcPZA6v+4Z0lsfQmeJV52awQRXWerMbk4kjxrEf2 y2GCmwKDqMkTBpD6ik89DmR0SiIBG1cOdivGzo3YmgAGmExSu1BJsNXONBUgdZQPj1W6 EWiSXk4x18qkxpUHuHC1dZGe2bqT+kvHIPi2SWRSVWh2dS2mkDonCAPpdKGLx0UXaAWY 7New== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vxyxFeq00JGhfZF3lbLUVUOmxZ61KQdQmUjeiwFbgw8=; b=yc9g+hXScfamfBQQgDxaKzIvZGutWSyRDIh6ExMasJKjOVJhScg6PRB5e0S/lWRQw0 CgQXUVHbYCGCtB/1vQ0YBeFdbjgLznFsfHrpdGJOAfBWHSwQRa6o1WU4NlPKgP2GBuLl Eekj3jB6lF//ADgvsXeOrqptnQ/lfXfqf1lq0VKuXH0dhHxEUoDOeAhchJusG0KfLb52 P6hEK5SSf7OX2YEAFfLBO05uzgalV4tIoA1M1M2ax33aSOCvLU4SItjr63Q+2pUig6Ds UT5Wdltzb+fc3ZdgEgvTed+X9uRio6jP5jnvhrsO8N2voLq+e18K+rkZzMQDEI0M06Mt U5iA== X-Gm-Message-State: AO0yUKUPiQgDY3rhgzr1hwjkk1OiGSp5fNKHoX1txUwfLyaf2OJ00bZ0 4T6HOf+cfjzeg+pSiWXXbgA= X-Google-Smtp-Source: AK7set/U/qA9uhgkckwtVXIcYK+eNjL8h6axhavdaN9OZUBKFGGYjKnPrkEhQ7UYDUf9udq8Ns6cYA== X-Received: by 2002:aa7:d0c6:0:b0:49b:4711:f4b4 with SMTP id u6-20020aa7d0c6000000b0049b4711f4b4mr2459599edo.0.1675261666145; Wed, 01 Feb 2023 06:27:46 -0800 (PST) Received: from osv.localdomain ([89.175.180.246]) by smtp.gmail.com with ESMTPSA id cf8-20020a0564020b8800b004a18f2ffb86sm8975564edb.79.2023.02.01.06.27.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Feb 2023 06:27:45 -0800 (PST) From: Sergey Organov To: Greg Kroah-Hartman Cc: linux-serial@vger.kernel.org, Fabio Estevam , Jiri Slaby , Richard Genoud , Sascha Hauer , Shawn Guo , Tim Harvey , =?utf-8?q?Tomasz_Mo=C5=84?= , =?utf-8?q?Uwe_Kle?= =?utf-8?q?ine-K=C3=B6nig?= , Johan Hovold , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Sherry Sun , Stefan Wahren , linux-arm-kernel@lists.infradead.org, NXP Linux Team , Pengutronix Kernel Team , Sergey Organov Subject: [PATCH v1 5/7] serial: imx: remove redundant USR2 read from FIFO reading loop Date: Wed, 1 Feb 2023 17:26:58 +0300 Message-Id: <20230201142700.4346-6-sorganov@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230201142700.4346-1-sorganov@gmail.com> References: <87bko4e65y.fsf@osv.gnss.ru> <20230201142700.4346-1-sorganov@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230201_062747_969373_43FA74CE X-CRM114-Status: GOOD ( 12.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org There is no need to read USR2 twice at every loop iteration: get rid of the second read. Signed-off-by: Sergey Organov --- drivers/tty/serial/imx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index 797c441088a9..af4349fe6970 100644 --- a/drivers/tty/serial/imx.c +++ b/drivers/tty/serial/imx.c @@ -904,7 +904,6 @@ static irqreturn_t __imx_uart_rxint(int irq, void *dev_id) rx = imx_uart_readl(sport, URXD0); - usr2 = imx_uart_readl(sport, USR2); if (usr2 & USR2_BRCD) { imx_uart_writel(sport, USR2_BRCD, USR2); if (uart_handle_break(&sport->port))