diff mbox series

[v3] arm64: dts: ti: k3-j721e-main: Remove ti,strobe-sel property

Message ID 20230203073724.29529-1-b-kapoor@ti.com (mailing list archive)
State New, archived
Headers show
Series [v3] arm64: dts: ti: k3-j721e-main: Remove ti,strobe-sel property | expand

Commit Message

Bhavya Kapoor Feb. 3, 2023, 7:37 a.m. UTC
According to latest errata of J721e [1], (i2024) 'MMCSD: Peripherals
Do Not Support HS400' which applies to MMCSD0 subsystem. Speed modes
supported has been already updated in commit eb8f6194e807 ("arm64: dts: ti: k3-j721e-main: Update the speed modes supported and their itap delay values for MMCSD subsystems")
but it missed dropping 'ti,strobe-sel' property which is only required
by HS400 speed mode.

Thus, drop 'ti,strobe-sel' property from kernel dtsi for J721e SoC.

[1] https://www.ti.com/lit/er/sprz455/sprz455.pdf

Fixes: eb8f6194e807 ("arm64: dts: ti: k3-j721e-main: Update the speed modes supported and their itap delay values for MMCSD subsystems")
Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
---
 arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 1 -
 1 file changed, 1 deletion(-)

Comments

Nitin Yadav March 13, 2023, 9:49 a.m. UTC | #1
On 2/3/2023 1:07 PM, Bhavya Kapoor wrote:
> According to latest errata of J721e [1], (i2024) 'MMCSD: Peripherals
> Do Not Support HS400' which applies to MMCSD0 subsystem. Speed modes
> supported has been already updated in commit eb8f6194e807 ("arm64: dts: ti: k3-j721e-main: Update the speed modes supported and their itap delay values for MMCSD subsystems")
> but it missed dropping 'ti,strobe-sel' property which is only required
> by HS400 speed mode.
> 
> Thus, drop 'ti,strobe-sel' property from kernel dtsi for J721e SoC.
> 
> [1] https://www.ti.com/lit/er/sprz455/sprz455.pdf
> 
> Fixes: eb8f6194e807 ("arm64: dts: ti: k3-j721e-main: Update the speed modes supported and their itap delay values for MMCSD subsystems")
> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
> ---
>  arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> index c935622f0102..bfa296dce3a3 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> @@ -1180,7 +1180,6 @@ main_sdhci0: mmc@4f80000 {
>  		ti,itap-del-sel-mmc-hs = <0xa>;
>  		ti,itap-del-sel-ddr52 = <0x3>;
>  		ti,trm-icp = <0x8>;
> -		ti,strobe-sel = <0x77>;
>  		dma-coherent;
>  	};
>
Reviewed-by: Nitin Yadav <n-yadav@ti.com>
Nishanth Menon March 13, 2023, 4:20 p.m. UTC | #2
On 14:27-20230313, a0502875 wrote:
> On 03/02/23 13:07, Bhavya Kapoor wrote:
> > According to latest errata of J721e [1], (i2024) 'MMCSD: Peripherals
> > Do Not Support HS400' which applies to MMCSD0 subsystem. Speed modes
> > supported has been already updated in commit eb8f6194e807 ("arm64: dts: ti: k3-j721e-main: Update the speed modes supported and their itap delay values for MMCSD subsystems")
> > but it missed dropping 'ti,strobe-sel' property which is only required
> > by HS400 speed mode.
> > 
> > Thus, drop 'ti,strobe-sel' property from kernel dtsi for J721e SoC.
> > 
> > [1]https://www.ti.com/lit/er/sprz455/sprz455.pdf
> > 
> > Fixes: eb8f6194e807 ("arm64: dts: ti: k3-j721e-main: Update the speed modes supported and their itap delay values for MMCSD subsystems")
> > Signed-off-by: Bhavya Kapoor<b-kapoor@ti.com>
> 
> Reviewed-by: Diwakar Dhyani <d-dhyani@ti.com <mailto:d-dhyani@ti.com>>

Please fix your mailer. I will need to hand apply for now.
Nishanth Menon March 14, 2023, 10:32 p.m. UTC | #3
Hi Bhavya Kapoor,

On Fri, 3 Feb 2023 13:07:24 +0530, Bhavya Kapoor wrote:
> According to latest errata of J721e [1], (i2024) 'MMCSD: Peripherals
> Do Not Support HS400' which applies to MMCSD0 subsystem. Speed modes
> supported has been already updated in commit eb8f6194e807 ("arm64: dts: ti: k3-j721e-main: Update the speed modes supported and their itap delay values for MMCSD subsystems")
> but it missed dropping 'ti,strobe-sel' property which is only required
> by HS400 speed mode.
> 
> Thus, drop 'ti,strobe-sel' property from kernel dtsi for J721e SoC.
> 
> [...]

I have applied the following to branch ti-k3-dts-next on [1].
Thank you!

[1/1] arm64: dts: ti: k3-j721e-main: Remove ti,strobe-sel property
      commit: 4f4b30a777d3e61603119297965343a37be36435

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] git://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
index c935622f0102..bfa296dce3a3 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
@@ -1180,7 +1180,6 @@  main_sdhci0: mmc@4f80000 {
 		ti,itap-del-sel-mmc-hs = <0xa>;
 		ti,itap-del-sel-ddr52 = <0x3>;
 		ti,trm-icp = <0x8>;
-		ti,strobe-sel = <0x77>;
 		dma-coherent;
 	};