diff mbox series

ARM: dts: imx7d-smegw01: Describe USBOTG1 as host

Message ID 20230209130429.1438053-1-festevam@denx.de (mailing list archive)
State New, archived
Headers show
Series ARM: dts: imx7d-smegw01: Describe USBOTG1 as host | expand

Commit Message

Fabio Estevam Feb. 9, 2023, 1:04 p.m. UTC 
The USBOTG1 port will always operate in host mode in Linux,
so describe dr_mode accordingly.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm/boot/dts/imx7d-smegw01.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Shawn Guo March 13, 2023, 8:08 a.m. UTC | #1 
On Thu, Feb 09, 2023 at 10:04:29AM -0300, Fabio Estevam wrote:
> The USBOTG1 port will always operate in host mode in Linux,

in Linux?  It could operate in otg mode in bootloader or other OS?

Shawn

> so describe dr_mode accordingly.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>  arch/arm/boot/dts/imx7d-smegw01.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx7d-smegw01.dts b/arch/arm/boot/dts/imx7d-smegw01.dts
> index c0f00f5db11e..386485755676 100644
> --- a/arch/arm/boot/dts/imx7d-smegw01.dts
> +++ b/arch/arm/boot/dts/imx7d-smegw01.dts
> @@ -190,7 +190,7 @@ &uart3 {
>  &usbotg1 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_usbotg1_lpsr>;
> -	dr_mode = "otg";
> +	dr_mode = "host";
>  	vbus-supply = <&reg_usbotg_vbus>;
>  	status = "okay";
>  };
> -- 
> 2.25.1
>
Fabio Estevam March 13, 2023, 9:52 a.m. UTC | #2 
Hi Shawn,

On 13/03/2023 05:08, Shawn Guo wrote:
> On Thu, Feb 09, 2023 at 10:04:29AM -0300, Fabio Estevam wrote:
>> The USBOTG1 port will always operate in host mode in Linux,
> 
> in Linux?  It could operate in otg mode in bootloader or other OS?

Yes, in U-Boot it can operate in OTG mode where it can be used in serial
download mode.

In Linux, the USB port only operates in host mode.
Shawn Guo March 13, 2023, 2:14 p.m. UTC | #3 
On Mon, Mar 13, 2023 at 06:52:32AM -0300, Fabio Estevam wrote:
> Hi Shawn,
> 
> On 13/03/2023 05:08, Shawn Guo wrote:
> > On Thu, Feb 09, 2023 at 10:04:29AM -0300, Fabio Estevam wrote:
> > > The USBOTG1 port will always operate in host mode in Linux,
> > 
> > in Linux?  It could operate in otg mode in bootloader or other OS?
> 
> Yes, in U-Boot it can operate in OTG mode where it can be used in serial
> download mode.
> 
> In Linux, the USB port only operates in host mode.

What stops the USB port from operating in OTG mode?

That doesn't sound right, as DT is a description of hardware capability
rather than Linux.

Shawn
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/imx7d-smegw01.dts b/arch/arm/boot/dts/imx7d-smegw01.dts
index c0f00f5db11e..386485755676 100644
--- a/arch/arm/boot/dts/imx7d-smegw01.dts
+++ b/arch/arm/boot/dts/imx7d-smegw01.dts
@@ -190,7 +190,7 @@  &uart3 {
 &usbotg1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_usbotg1_lpsr>;
-	dr_mode = "otg";
+	dr_mode = "host";
 	vbus-supply = <&reg_usbotg_vbus>;
 	status = "okay";
 };