From patchwork Sun Feb 19 09:27:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Rogers X-Patchwork-Id: 13145824 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D591C636CC for ; Sun, 19 Feb 2023 09:30:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:References: Mime-Version:Message-Id:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=dkKMKZUSA3StulXMQILl7mRJF8n6X35BggOcBgRF9pg=; b=ZfFzBwAdkZUL0/6ZpNqNe19i5C fckY7j+mgbQXsjSzrWhHts021Xk4KRMCcwt6bZrnMGx+82dbWvElzzEaCfq4CODYk13+8EJuAWxt9 JKMBhfvMCkMcKpf3kSvyWtVjQK5TQNS74q0jDGLVoQWx91JeZADC4dxShRDE5Af9XoSCLlIbbzWHS 7Yh78q5HB9i1Tv3fTUbH4vhj/iFEZF6YoEtZDDE+I/IPwCDZaOG8ZuIkR4zKq75CqHlZw807J3l86 ievW1Hc7ZMbA5ykVPUWWWcE1rkKvAasSXmCCihgeO1MkpHxeJaMq9Vq9uGiwCWlAYZzMkf3YeLPEK qY2fa/0g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pTg0R-0013XC-UJ; Sun, 19 Feb 2023 09:29:16 +0000 Received: from mail-yw1-x114a.google.com ([2607:f8b0:4864:20::114a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pTg0M-0013Vc-VV for linux-arm-kernel@lists.infradead.org; Sun, 19 Feb 2023 09:29:12 +0000 Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-53687f81167so18684177b3.18 for ; Sun, 19 Feb 2023 01:29:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=hFVME4MawZ7uSatJrZd2lz8rTpTsmAg9tHqKzSK6mH4=; b=lYts0MZFkBMWWWqsvbZ4s4LF7YBZTVWoKqr0XB8T3QZMUTOA2s2Z+G/g2UZslwUZuC Bg0JfwZvu8l1XTdfCWtyr+kOVvUd3vxdajoINwRuBTIhR35jt0E02ChfAVNX7oNfDnUc OQxysWfmRktf3N7SbQdfMUQDwloDegoPhyu+QeutG7viIgr3NSQJg+6Q1X7h+12Q6I/W lCtx21C8+b0DCEVf/bHP/8aPsvD8vdxjq3D6aElrMFCmBpWcEKc/gfnWhBWTMFWPGVfd G0NcqD61UhEmodEZAPS6XL71MQzBlkE/OwDXXgcA/gAT9OXasg2DRifrqgTUe2QIxicB mB5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hFVME4MawZ7uSatJrZd2lz8rTpTsmAg9tHqKzSK6mH4=; b=u5oy/qpOBWX2WBgZxFufXMJKht2ojaLZT/KuUPrkerzF7jfbb2Mf2fdtU5W9v1Q5R/ LrN4QLrz/TOwxhE4dCTPWv7YdmkIm1aKFTx7/QHi8VSvfCJe+7+tXUyf9B+N5KrX5uoB KQeX2oNIpdmNovrdvPSZb3wi7VewgthM33v0wTKvkuz1udWNlXT4+6yTNAgqvTg4k8pI NTlT+X4Pb6WQkfmY0WFwskU2cQA1hl2VN++8AL0KBFWkW1+dhF6avZtmdLkYx0lEK3p3 ZIzPRK3r0dB8Zf4r2zyWDWyzAZ4GUcg/R5F0Kn58nlOZJu5mLasr2FuSWEDuqr2M/PPI f8Ww== X-Gm-Message-State: AO0yUKXiYq6aefHOsSs8DsxrTc0zCRGltoOmEi6fdEw5NEF1x4BNfQdp g6iVTNYPhjBysEcvWIrC+8w36VCEGqeX X-Google-Smtp-Source: AK7set88ydp5C+tDl9Q//caqm5c4PHb281InYvDmoStSEM3jMHzSTQOu5zeqkSSBL+FN422RFEfJNs9jMi0d X-Received: from irogers.svl.corp.google.com ([2620:15c:2d4:203:cde9:3fbc:e1f1:6e3b]) (user=irogers job=sendgmr) by 2002:a25:9a45:0:b0:97a:4493:a7b8 with SMTP id r5-20020a259a45000000b0097a4493a7b8mr128740ybo.505.1676798949427; Sun, 19 Feb 2023 01:29:09 -0800 (PST) Date: Sun, 19 Feb 2023 01:27:58 -0800 In-Reply-To: <20230219092848.639226-1-irogers@google.com> Message-Id: <20230219092848.639226-2-irogers@google.com> Mime-Version: 1.0 References: <20230219092848.639226-1-irogers@google.com> X-Mailer: git-send-email 2.39.2.637.g21b0678d19-goog Subject: [PATCH v1 01/51] perf tools: Ensure evsel name is initialized From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Maxime Coquelin , Alexandre Torgue , Zhengjun Xing , Sandipan Das , James Clark , Kajol Jain , John Garry , Kan Liang , Adrian Hunter , Andrii Nakryiko , Eduard Zingerman , Suzuki Poulouse , Leo Yan , Florian Fischer , Ravi Bangoria , Jing Zhang , Sean Christopherson , Athira Rajeev , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Perry Taylor , Caleb Biggers Cc: Stephane Eranian , Ian Rogers X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230219_012911_038629_D04603A8 X-CRM114-Status: GOOD ( 12.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use the evsel__name accessor as otherwise name may be NULL resulting in a segv. This was observed with the perf stat shell test. Signed-off-by: Ian Rogers Reviewed-by: Kajol Jain --- tools/perf/util/synthetic-events.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/synthetic-events.c b/tools/perf/util/synthetic-events.c index 9ab9308ee80c..6def01036eb5 100644 --- a/tools/perf/util/synthetic-events.c +++ b/tools/perf/util/synthetic-events.c @@ -2004,7 +2004,7 @@ int perf_event__synthesize_event_update_name(struct perf_tool *tool, struct evse perf_event__handler_t process) { struct perf_record_event_update *ev; - size_t len = strlen(evsel->name); + size_t len = strlen(evsel__name(evsel)); int err; ev = event_update_event__new(len + 1, PERF_EVENT_UPDATE__NAME, evsel->core.id[0]);