| Message ID | 20230228210216.447373-3-tanmay.shah@amd.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drivers: remoteproc: xilinx: add mailbox support | expand |
On 2/28/23 22:02, Tanmay Shah wrote: > Multiple IPI channels are mapped to same interrupt handler. > Current isr implementation handles only one channel per isr. > Fix this behavior by checking isr status bit of all child > mailbox nodes. > > Signed-off-by: Tanmay Shah <tanmay.shah@amd.com> > --- > drivers/mailbox/zynqmp-ipi-mailbox.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-ipi-mailbox.c > index e287ed7a92ce..b1498f6f06e1 100644 > --- a/drivers/mailbox/zynqmp-ipi-mailbox.c > +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c > @@ -152,7 +152,7 @@ static irqreturn_t zynqmp_ipi_interrupt(int irq, void *data) > struct zynqmp_ipi_message *msg; > u64 arg0, arg3; > struct arm_smccc_res res; > - int ret, i; > + int ret, i, status = IRQ_NONE; > > (void)irq; > arg0 = SMC_IPI_MAILBOX_STATUS_ENQUIRY; > @@ -170,11 +170,11 @@ static irqreturn_t zynqmp_ipi_interrupt(int irq, void *data) > memcpy_fromio(msg->data, mchan->req_buf, > msg->len); > mbox_chan_received_data(chan, (void *)msg); > - return IRQ_HANDLED; > + status = IRQ_HANDLED; > } > } > } > - return IRQ_NONE; > + return status; > } > > /** Acked-by: Michal Simek <michal.simek@amd.com> Thanks, Michal
diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-ipi-mailbox.c index e287ed7a92ce..b1498f6f06e1 100644 --- a/drivers/mailbox/zynqmp-ipi-mailbox.c +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c @@ -152,7 +152,7 @@ static irqreturn_t zynqmp_ipi_interrupt(int irq, void *data) struct zynqmp_ipi_message *msg; u64 arg0, arg3; struct arm_smccc_res res; - int ret, i; + int ret, i, status = IRQ_NONE; (void)irq; arg0 = SMC_IPI_MAILBOX_STATUS_ENQUIRY; @@ -170,11 +170,11 @@ static irqreturn_t zynqmp_ipi_interrupt(int irq, void *data) memcpy_fromio(msg->data, mchan->req_buf, msg->len); mbox_chan_received_data(chan, (void *)msg); - return IRQ_HANDLED; + status = IRQ_HANDLED; } } } - return IRQ_NONE; + return status; } /**
Multiple IPI channels are mapped to same interrupt handler. Current isr implementation handles only one channel per isr. Fix this behavior by checking isr status bit of all child mailbox nodes. Signed-off-by: Tanmay Shah <tanmay.shah@amd.com> --- drivers/mailbox/zynqmp-ipi-mailbox.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)