From patchwork Fri Mar 3 17:19:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13159074 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29FA8C7EE2D for ; Fri, 3 Mar 2023 17:24:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TZ9bi2lextxT076Hembs1zGehP/EFlerfyx0jIPd5q8=; b=lVYvne7HuNWfxo OWOON8VDGI8k6RkV53oK5gKc42loz32HFat7ZBwjkKH4ZljFNoAN3W5pjn5+w9b5KRcTsLIePsimG 8WtgcRud6xFYDtIaSuTA2JlzMA+IwHhb8tncxHO/fK/Bm+iWAXuk7E7NSS2jQYytSSC2XTR67XINZ JwPp8WdEoIIK2Fju5jSqyp35RuCgYNKDvZeh3PjiJuzkYYG5a4ivD5mA7nZE7Cd8/itt0EXlXCl6m DZbovyXVwzkANJZLmOihPPAcJPWxgCWUFWCAiaU54GZOH/eNUcPfvqox8RqqEyhmQKJQvlU5DDh6y j9EVhOk39rtaG/ZTfDmA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pY97s-006uL9-RK; Fri, 03 Mar 2023 17:23:24 +0000 Received: from metis.ext.pengutronix.de ([85.220.165.71]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pY95l-006t66-Pp for linux-arm-kernel@lists.infradead.org; Fri, 03 Mar 2023 17:21:17 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pY95T-0006Pu-5Q; Fri, 03 Mar 2023 18:20:55 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pY95R-001bjH-ME; Fri, 03 Mar 2023 18:20:53 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pY95Q-001tiP-MO; Fri, 03 Mar 2023 18:20:52 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Mark Brown , Florian Fainelli , Ray Jui , Scott Branden Cc: Broadcom internal kernel review list , linux-spi@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 09/87] spi: bcm2835: Convert to platform remove callback returning void Date: Fri, 3 Mar 2023 18:19:23 +0100 Message-Id: <20230303172041.2103336-10-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230303172041.2103336-1-u.kleine-koenig@pengutronix.de> References: <20230303172041.2103336-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2073; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=IwMtpVogMLCOnqG7xyZOf1yVAVJAMlhznRPZfWS20qU=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkAistaibZ8u12RA+5ZlvyXrNsVYAw21v6yE1O2 jwrIwgu80SJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAIrLQAKCRDB/BR4rcrs CZDcB/0R7//E1eL+cLL7rtUtyygZCxAKAITisyDBy+vtPSEyvOBfwK7oDv/H8mZHFgmWqG0vLQk dZ5N9Fzwj5hBR8yulTkZM9wd3sDX07lgXwpqQqqnslEMiAwLo59iNO6cJqqlfsbWoBe9jjqZVti Wu9SQzQ/Ame/Ei+EkUU9eHnDiOrZcNJhF4kUIpw5hhu206hAZ6kfBZg4SnmyEM5iyUndm7fffPX ROBctkqI5ZPBuvxhwCvZvGkgJU+pK4njWoJPMNhk+pZqG8iUHC06ZBQLG6LJVNjpiJ8fK8ygXkt j0kLPcAJZgdxg6+5EO3xqc1DTvvd0PPuUzHwtIl06MN6NVms X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230303_092114_042712_C27C0CE3 X-CRM114-Status: GOOD ( 17.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Florian Fainelli --- drivers/spi/spi-bcm2835.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/spi/spi-bcm2835.c b/drivers/spi/spi-bcm2835.c index 747e03228c48..be6050b513a9 100644 --- a/drivers/spi/spi-bcm2835.c +++ b/drivers/spi/spi-bcm2835.c @@ -1398,7 +1398,7 @@ static int bcm2835_spi_probe(struct platform_device *pdev) return err; } -static int bcm2835_spi_remove(struct platform_device *pdev) +static void bcm2835_spi_remove(struct platform_device *pdev) { struct spi_controller *ctlr = platform_get_drvdata(pdev); struct bcm2835_spi *bs = spi_controller_get_devdata(ctlr); @@ -1414,17 +1414,11 @@ static int bcm2835_spi_remove(struct platform_device *pdev) BCM2835_SPI_CS_CLEAR_RX | BCM2835_SPI_CS_CLEAR_TX); clk_disable_unprepare(bs->clk); - - return 0; } static void bcm2835_spi_shutdown(struct platform_device *pdev) { - int ret; - - ret = bcm2835_spi_remove(pdev); - if (ret) - dev_err(&pdev->dev, "failed to shutdown\n"); + rbcm2835_spi_remove(pdev); } static const struct of_device_id bcm2835_spi_match[] = { @@ -1439,7 +1433,7 @@ static struct platform_driver bcm2835_spi_driver = { .of_match_table = bcm2835_spi_match, }, .probe = bcm2835_spi_probe, - .remove = bcm2835_spi_remove, + .remove_new = bcm2835_spi_remove, .shutdown = bcm2835_spi_shutdown, }; module_platform_driver(bcm2835_spi_driver);