From patchwork Fri Mar 3 17:19:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13159066 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C53DCC64EC4 for ; Fri, 3 Mar 2023 17:22:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Jl3YxM+EYNQoq91235ZepsK/Z9rtMzB92y1D1rdmjbA=; b=Kw4FLPtO7JCPUS 4jYWMULUiKY9501XFjMRxxzvGFRkb4t7BhkZ0FBYdRDD0dAYyl8bQAzNBpjXc5R6af60YG82n9JZh VqVAGd6YL+rLRG4w6aKA8cYcAHMtHY02LrIEdD1ppYF6XBCjadkomIGfh/6jBTI+GXtTDdlQ45brB xKKQtJW4Dk5TE+lQbbIVluiX7FLdgB9ULuMw/zh9HC+EtmgiNAn1jYPyj6PT4sNUd3eQkh8X5U4KR h2RO4oHaFCtdX69SP2yj4m82YFNbujQygoE+CEaRT5qnHMYEeSHAfJtxhwbJjqHD7fIPWOCWdY7og pUFtdDOMs7xFkXJvDmHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pY95x-006tEz-81; Fri, 03 Mar 2023 17:21:25 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pY95e-006t2i-6y for linux-arm-kernel@lists.infradead.org; Fri, 03 Mar 2023 17:21:12 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pY95T-0006Sy-CC; Fri, 03 Mar 2023 18:20:55 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pY95S-001bjc-Je; Fri, 03 Mar 2023 18:20:54 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pY95R-001tij-N9; Fri, 03 Mar 2023 18:20:53 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Kamal Dasu , Mark Brown , Florian Fainelli Cc: Broadcom internal kernel review list , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 14/87] spi: brcmstb-qspi: Convert to platform remove callback returning void Date: Fri, 3 Mar 2023 18:19:28 +0100 Message-Id: <20230303172041.2103336-15-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230303172041.2103336-1-u.kleine-koenig@pengutronix.de> References: <20230303172041.2103336-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1484; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=iqNUrERgLHMTT8ivhCINBCII1+ximgOKlxKLMHyYQk0=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkAis/jrpEglBe3ArBD4/4cb6K5gKk5nT6sQist 9khe/hKCgCJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAIrPwAKCRDB/BR4rcrs CQaqB/9Ogx1gFXp1VnBdCu2xQu3RIKIg1xPCVC6Nw7EdvGN8KGpvSRs3YBm4R+Lt1SWvaFW8+1r aVvowovEvNzNZXeXXOjUFivAtJSvcCH3ZXbPvNPc2MxzOaiGfQ+u7o347N7tvPQji3Ym7lQ7+a9 pOkiETgLktw6pIxm65brPmpvZufA5gPjA+aymeCf4ou/Gzf1ski86ghUvN7eiCDgux5isBs7HT5 GRZke0tYZHYKVXy0/9WXc1LsCDXNumu23PFD3nPbGeBp6OkgtRJ0uV4lFT0kSJSOL78sR0ASB2s xM4a+tVRxgitT84pNjTSGhsDEjWwf7vvlcU/x1HSxYFUPBnr X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230303_092106_289259_AD2C49B7 X-CRM114-Status: GOOD ( 16.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Florian Fainelli --- drivers/spi/spi-brcmstb-qspi.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-brcmstb-qspi.c b/drivers/spi/spi-brcmstb-qspi.c index de362b35718f..e1b137419f5c 100644 --- a/drivers/spi/spi-brcmstb-qspi.c +++ b/drivers/spi/spi-brcmstb-qspi.c @@ -21,16 +21,14 @@ static int brcmstb_qspi_probe(struct platform_device *pdev) return bcm_qspi_probe(pdev, NULL); } -static int brcmstb_qspi_remove(struct platform_device *pdev) +static void brcmstb_qspi_remove(struct platform_device *pdev) { bcm_qspi_remove(pdev); - - return 0; } static struct platform_driver brcmstb_qspi_driver = { .probe = brcmstb_qspi_probe, - .remove = brcmstb_qspi_remove, + .remove_new = brcmstb_qspi_remove, .driver = { .name = "brcmstb_qspi", .pm = &bcm_qspi_pm_ops,