From patchwork Fri Mar 3 17:19:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13159202 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2B4ECC64EC4 for ; Fri, 3 Mar 2023 17:35:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EqoPapaRiIusGI6UO7bgGCjlT+3SNsHMgH/0b72Gc38=; b=Nu+3AgmLONa6V4 n94yePrE2ar1+ukdL8ZelaW4lLFy3zcsg01Lfnq2btFV01n8uqNLfcUjNTFNmgd+FMhFM8WiyWPDk XW2t6A5b5A4lbsqnuoOWvYK45aYQJ9fz1Njtd52m1WnP/vcRABgC/eod6jtB2QTrJjSTkibiayNTe jJVezKQNSSkqTB6xtIeDVqmZiWaF+NQUIi23l9CFQomze9f6FXGzayikBY28K5fLJQpfQ+o9sqxSl f6v086V+TVN83GBQEcuixBZTXvI3mjaupqoNoMZSay3xvvTeoWit1xlCo6m7PR0fscBK3UU3he3Gw pIY5DNptc4X0sAJUauJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pY9IV-006zHw-0r; Fri, 03 Mar 2023 17:34:23 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pY965-006tHl-RB for linux-arm-kernel@bombadil.infradead.org; Fri, 03 Mar 2023 17:21:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=58ix0aDFh0DNCCZkFpq3LQxdCvA7eAS5aDF1XBuuIvA=; b=h0W0+BlnUdtCGj47PQ61kM1EBQ 978GN+GFDvdcQruzuq8mT6vWr17LINf78TBN/SMGT77JiMJy2PtpAw1Un9uGrW5a7++jqAOI3L74b Lrzbf7jNv1Ua7IJ5b4tc2SQvs/IuRwSiVfGFxC4qXBcrJfxCWGp+YoBl/Zdh1CnRFcY/K1LebKxpu Mbz1B0aVKCFqo8o3tDvPIYB8QOcTJc6+TBI6uB3glfkoHhixZX5ZxfdQ1357V4r8G5NzlS75P8jxL uu5QdZj4ycFPh45BdKCWNbJFnqNgTRW3jCzuePQIMvS+ua00ZiowdWxetgEkendbCGVaSqkWeurEx 3vyEdwWw==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pY95u-00FkTb-0E for linux-arm-kernel@lists.infradead.org; Fri, 03 Mar 2023 17:21:32 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pY95Z-0006o0-Jz; Fri, 03 Mar 2023 18:21:01 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pY95Y-001bly-JU; Fri, 03 Mar 2023 18:21:00 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pY95X-001tkg-UV; Fri, 03 Mar 2023 18:20:59 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Mark Brown , Shawn Guo , Sascha Hauer Cc: Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 44/87] spi: mxs: Convert to platform remove callback returning void Date: Fri, 3 Mar 2023 18:19:58 +0100 Message-Id: <20230303172041.2103336-45-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230303172041.2103336-1-u.kleine-koenig@pengutronix.de> References: <20230303172041.2103336-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1568; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=5OPK9fmthHTWqfIh12hEoolqfY6MlpVwy7kXcL/POCU=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkAiu11quOf7eXJTfR/iOUu809q+N8kgnEUu/bV 7c9UFIOtD2JATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAIrtQAKCRDB/BR4rcrs CR6aCACbtMJQRrXu9ya5MCMowHiH6qzE1JGXX8bF1QW913zDr3QG45KsbBIZeObRBJXcetPyL4k xsyH08KolXxEj3/ZezqUGg1oSkjjq4xztdcl9sy72WWI7w3lWWZ1EeQdLofwoYK78QeMgHgbmY0 Sx74yuOhiMST1Dv6HKuo5vRbkj/Tr7lJIc12P4OpwWMp9ecOCfbWWA8rMCR7F43KKmUXfH6IfX7 3lmSRVsmy3/ynJ7pX+vRqQ3siUxtX4jSdfK+JH4OSMNlDtlPusWWWQ0lJzXLnc1QTDQSxwSI3Qp GYgZOk5S6hOgK4CfP7rDUfzGMbIjj3T8+hdBp2x9nkHlBZyv X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230303_172122_272147_030B6AD1 X-CRM114-Status: GOOD ( 16.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/spi/spi-mxs.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-mxs.c b/drivers/spi/spi-mxs.c index 55178579f3c6..10fb31a5e409 100644 --- a/drivers/spi/spi-mxs.c +++ b/drivers/spi/spi-mxs.c @@ -638,7 +638,7 @@ static int mxs_spi_probe(struct platform_device *pdev) return ret; } -static int mxs_spi_remove(struct platform_device *pdev) +static void mxs_spi_remove(struct platform_device *pdev) { struct spi_master *master; struct mxs_spi *spi; @@ -653,13 +653,11 @@ static int mxs_spi_remove(struct platform_device *pdev) mxs_spi_runtime_suspend(&pdev->dev); dma_release_channel(ssp->dmach); - - return 0; } static struct platform_driver mxs_spi_driver = { .probe = mxs_spi_probe, - .remove = mxs_spi_remove, + .remove_new = mxs_spi_remove, .driver = { .name = DRIVER_NAME, .of_match_table = mxs_spi_dt_ids,