From patchwork Fri Mar 3 17:19:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13159203 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65DD0C7EE2D for ; Fri, 3 Mar 2023 17:36:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7drpizCP5xMFxeePWBdJ7+7kxh5yUPd8RtSKu/h2+eo=; b=VZfdr8AwfF5Kxx UVc+QzCYfHWYlBr5TQ9ZsuhJzgqZx4pOz9ZtO4cWTiraHXXl1GxbyGuJgaV3jvOPsL6MCfNwIk3Ge NdNkq0OSpx8QsaHObNKvNmVH1KeXQjvKr8UnOe/rTobrcg5LhoPlPrHtHd5K8SRErtQhLeVwaxaW6 Lap/0kfY0JKxBeszNMKMEPRz7FT1tMkPaDFMPnLU5TpUZWsIVdz1FdyE/E5iC6IuAZ+0h/p1HsKc+ +OmVi+dpXjVzQDb6yprnfbKl80gnXlq0grHN3xeh1vP00RCaZffr4BvKS6qp6A0DSjzaSqUlYwfbr WvRAxLtBqkQxn13lgMGw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pY9J7-006zYR-Ms; Fri, 03 Mar 2023 17:35:02 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pY968-006tJC-Gv for linux-arm-kernel@bombadil.infradead.org; Fri, 03 Mar 2023 17:21:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=3BRxqAm/eaouR3VEP0XTxAdn3RLU4BGqgDOCjH99XKs=; b=BlBwpBwHS+Bfb+MAyVHdUXwzvs WRzCUHZmwHelYvDB0+tcsGFC/HcvvcCsEx7qs+kdrzV77EIpdwZHnaEOhj47kLG3NRk6jliNvQvhJ uO+CiYk4MRoAKOu3ZsIFxLfLHXtRHMCfGtswh5M5h6QGDexa62zXpPKa3rSBzglsvxPT2ciKYTgNq eh5eecTWM3qRr2tYyD/LVIV6QoiBqKg5hNzjMJVX3/pMtsP/n8KMEjbiSuHqOitX6K3L2bnMPVKJ5 FgCpKG4abC8OGqJiN0yyaUNfmViOxziakHhPcyOQqrUR9vCYdLj9/g5uxqUfDqvTXBAZkA/tfc3iv 6VRslfGg==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pY95u-00FkTa-01 for linux-arm-kernel@lists.infradead.org; Fri, 03 Mar 2023 17:21:34 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pY95R-0006PP-T8; Fri, 03 Mar 2023 18:20:53 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pY95Q-001biy-TF; Fri, 03 Mar 2023 18:20:52 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pY95Q-001tiC-4b; Fri, 03 Mar 2023 18:20:52 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Tudor Ambarus , Mark Brown , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea Cc: linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 06/87] spi: atmel: Convert to platform remove callback returning void Date: Fri, 3 Mar 2023 18:19:20 +0100 Message-Id: <20230303172041.2103336-7-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230303172041.2103336-1-u.kleine-koenig@pengutronix.de> References: <20230303172041.2103336-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1761; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=mCt2Un821gpj1y8NAm+IBr4EdSBQOSNVgBWpBSq5bZs=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkAishGC2VZ7VOHqW4ZkNNX6g/mFQ+ZvzY0xMNx n122bI6SKuJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAIrIQAKCRDB/BR4rcrs CfGTB/4qeTRYO9EJB/+02GnInZTAUON0o38ogQMj7fAbI/gVee6C8YQSnuu5EDS44bQAMIZ/Kiy azJYPA6nDyao0BnD28HL6WOOuO8EOGIql/hYVlDvEAhPooUS0DxhLMBHcmtubxM4I9wBFNS5a+x zPeUxANNG4FpVtbrS7+IZtGehLGNvzBJjAPzzCgZyjKNAWR8qRAEz8EftzpGSiigVs43s096nGj XsUO+hKpkLRLbzamANE92pDTi+99WYZuRsw/pfQzQdZHh1NFBF9eXNSyn7o3r5/dkVWuSKENsPO pGN6G5dCM6ZZHWUhDMdsqquVAL5O/siXDKT8SB8MMKLu4UtV X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230303_172122_220253_97A39D20 X-CRM114-Status: GOOD ( 16.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Claudiu Beznea --- drivers/spi/spi-atmel.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c index 5c5678f065f3..73f80c8ac2ff 100644 --- a/drivers/spi/spi-atmel.c +++ b/drivers/spi/spi-atmel.c @@ -1596,7 +1596,7 @@ static int atmel_spi_probe(struct platform_device *pdev) return ret; } -static int atmel_spi_remove(struct platform_device *pdev) +static void atmel_spi_remove(struct platform_device *pdev) { struct spi_controller *host = platform_get_drvdata(pdev); struct atmel_spi *as = spi_controller_get_devdata(host); @@ -1627,8 +1627,6 @@ static int atmel_spi_remove(struct platform_device *pdev) pm_runtime_put_noidle(&pdev->dev); pm_runtime_disable(&pdev->dev); - - return 0; } static int atmel_spi_runtime_suspend(struct device *dev) @@ -1712,7 +1710,7 @@ static struct platform_driver atmel_spi_driver = { .of_match_table = atmel_spi_dt_ids, }, .probe = atmel_spi_probe, - .remove = atmel_spi_remove, + .remove_new = atmel_spi_remove, }; module_platform_driver(atmel_spi_driver);