From patchwork Fri Mar 3 17:20:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13159186 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC2D7C64EC4 for ; Fri, 3 Mar 2023 17:25:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qOfC0TsRS8wfkR8YxtiUi5kEo7gsvTD6JNuoNq/+c2s=; b=1UIGmhmBoCbZ5V Q0w0R1yN9KNKC9UmSKaJCrhfZlhuJ9f+x1ieN/faM4Ylgc9R8+jFSpQFhFifhV0sh0lkwjoIhj2Rn E0NAsOqh5miwJN6B3Zaf8J78HYeucav6Uou2nM8rhp5auDKCPxi0k5sbaoV5AwieyuCgQfJsPwRfU CZkrRKzzpCblMJbYTS99g41hJdXHPAnxS92dy2/rWyWMQlcLnFT4iGdJOZKe/PQ/+5oBH+nneeYxH ano+qAScGbF9CvjzUmRMpBhRJNRXeNYsxb8HPPIr3N3tUdCANosz88IStu3BSXcqMIHDsmx8qt1jU QrMYQiGccU17mvtZt4AA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pY98f-006umn-Bm; Fri, 03 Mar 2023 17:24:14 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pY95m-006t7f-Fv for linux-arm-kernel@lists.infradead.org; Fri, 03 Mar 2023 17:21:17 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pY95h-0007CA-SG; Fri, 03 Mar 2023 18:21:09 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pY95g-001bpF-Rb; Fri, 03 Mar 2023 18:21:08 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pY95g-001tnF-3s; Fri, 03 Mar 2023 18:21:08 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Mark Brown , Michal Simek Cc: linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 84/87] spi: xilinx: Convert to platform remove callback returning void Date: Fri, 3 Mar 2023 18:20:38 +0100 Message-Id: <20230303172041.2103336-85-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230303172041.2103336-1-u.kleine-koenig@pengutronix.de> References: <20230303172041.2103336-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1808; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=1coSjyLVCt5hqzIgXmUNdRRTtaEsNmf1x/8dcg0B/7Q=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkAixVdD3ol4CCLpPAXERy7eINNJy/LoDtjkAOs G0TJpGKW2GJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAIsVQAKCRDB/BR4rcrs CWpDB/wMXwpw7ruvyvKiQP+M13DVGSxsNOZnV5GZfdNyF8HLRCY5tk/WrHu1/E+xVDGPHVU6q5u ckFpO0EvAGI77kKnXh3Ti1PEdCUZFMI3Nvom6OmKEKWNUQbSqoYTZEzdiXLIy8qqjIHtaMQ9qk1 B+/uMA8ukZvbHiJ7c80BiBYetJiCjcC9cFhN9yFEob1yEKCPE3GtpDp01I0/TT60bHjcEoIVxlC hp0L7Aiy8U9l1nCqaQtxHCc1tdSKztutPWLZdXa6xX5RBe7++mFe5fXtbCrz2UUYUQl5VMUJlln txyHn81GwL0hzPTqlzcenGvDTwGacTPv80zHeFcFQbMmul4G X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230303_092114_628347_75A798AD X-CRM114-Status: GOOD ( 17.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/spi/spi-xilinx.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-xilinx.c b/drivers/spi/spi-xilinx.c index 1411548f4255..d2f9eea5e093 100644 --- a/drivers/spi/spi-xilinx.c +++ b/drivers/spi/spi-xilinx.c @@ -504,7 +504,7 @@ static int xilinx_spi_probe(struct platform_device *pdev) return 0; } -static int xilinx_spi_remove(struct platform_device *pdev) +static void xilinx_spi_remove(struct platform_device *pdev) { struct spi_master *master = platform_get_drvdata(pdev); struct xilinx_spi *xspi = spi_master_get_devdata(master); @@ -518,8 +518,6 @@ static int xilinx_spi_remove(struct platform_device *pdev) xspi->write_fn(0, regs_base + XIPIF_V123B_DGIER_OFFSET); spi_master_put(xspi->bitbang.master); - - return 0; } /* work with hotplug and coldplug */ @@ -527,7 +525,7 @@ MODULE_ALIAS("platform:" XILINX_SPI_NAME); static struct platform_driver xilinx_spi_driver = { .probe = xilinx_spi_probe, - .remove = xilinx_spi_remove, + .remove_new = xilinx_spi_remove, .driver = { .name = XILINX_SPI_NAME, .of_match_table = xilinx_spi_of_match,