From patchwork Fri Mar 3 18:54:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13159409 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B928DC7EE2D for ; Fri, 3 Mar 2023 18:56:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0ucKKufA8icQ/s/jJoONczH3Ct9vdsrVJ8mLkhfIgXM=; b=hbs2nsJ0XoVRIR DSsE4Q5rR5K4Z57UGiwh3R6nQ56eEj42Y/OY5p/NQda76SPLagzUwnxVtarkXkQZAZ42p3xwDS3lq IqLCWPPE10/8znSxu7SEfstjvnVxgHD4EvU2keMnegBoC22vmXGG7tB0XQ5NtjIRjNUULjCPhsrQZ crY3MDnHWX0u5j3ykzod0YPMVNUET8B+sh/5D3a8RiUfDGuNvuPViD4KzKqqacZvF5x2VAS9PDBn0 jQmqGTZY87K5BqXgzhRNnU0rvBwKZkKMlWPUVapNM+LF4xURf1J41sAxvuI8YXCD5jtCQTutYD5Go VXhmPIIngXjRCbgT2Z1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pYAZC-007D4W-O4; Fri, 03 Mar 2023 18:55:42 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pYAYa-007Cn9-3F for linux-arm-kernel@lists.infradead.org; Fri, 03 Mar 2023 18:55:07 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pYAYY-0006KJ-41; Fri, 03 Mar 2023 19:55:02 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pYAYX-001cUP-BY; Fri, 03 Mar 2023 19:55:01 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pYAYV-001ukQ-QA; Fri, 03 Mar 2023 19:54:59 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Thierry Reding , Vladimir Zapolskiy Cc: kernel@pengutronix.de, linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 13/30] pwm: lpc18xx-sct: Convert to platform remove callback returning void Date: Fri, 3 Mar 2023 19:54:28 +0100 Message-Id: <20230303185445.2112695-14-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230303185445.2112695-1-u.kleine-koenig@pengutronix.de> References: <20230303185445.2112695-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1775; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=I71n/M4JjXwoVG498QigfPTCYZOxyVxtqldIZMXZh3M=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkAkIM3roj9ZCzs68PbczbWFcAOh0/cqrPMGaiI BGTSYD8ozWJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAJCDAAKCRDB/BR4rcrs CZ5GCACWc8IzdPPmgPAk8/Bi+2azigSbL4wWxh9u48mKkmlChFqf94bbV51BnQp6P7bjHY0Ht/N aOlOr/C+sVm59tFCqPnzP/kl7BoF78s/Q/GRu5Ffr0C14grcLi/YJWIEWVUihEVKsHhlkMbqj6I 3uMRNaU+1344ld8ZSGM3zoRiAQ4DYh/jQ4gdSVnCXUxSB7yFaNXuBVymRGeT0JgW3vYBobdkjcz QxlBlPpZ6lRgXQeUObqz/Ov9qSBR5yzfJFlj3wrRAWB7C0RfctSVne2Svfo3xdD1ro+2J7Ut0vO 3vsjJRaxI+B0RvgF5dhBl0DClrb2EZdbHFPyCzwYK0H2Xk0A X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230303_105504_257610_D5030107 X-CRM114-Status: GOOD ( 16.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/pwm/pwm-lpc18xx-sct.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/pwm/pwm-lpc18xx-sct.c b/drivers/pwm/pwm-lpc18xx-sct.c index 378e1df944dc..b9bf5b366f4b 100644 --- a/drivers/pwm/pwm-lpc18xx-sct.c +++ b/drivers/pwm/pwm-lpc18xx-sct.c @@ -449,7 +449,7 @@ static int lpc18xx_pwm_probe(struct platform_device *pdev) return ret; } -static int lpc18xx_pwm_remove(struct platform_device *pdev) +static void lpc18xx_pwm_remove(struct platform_device *pdev) { struct lpc18xx_pwm_chip *lpc18xx_pwm = platform_get_drvdata(pdev); u32 val; @@ -461,8 +461,6 @@ static int lpc18xx_pwm_remove(struct platform_device *pdev) val | LPC18XX_PWM_CTRL_HALT); clk_disable_unprepare(lpc18xx_pwm->pwm_clk); - - return 0; } static struct platform_driver lpc18xx_pwm_driver = { @@ -471,7 +469,7 @@ static struct platform_driver lpc18xx_pwm_driver = { .of_match_table = lpc18xx_pwm_of_match, }, .probe = lpc18xx_pwm_probe, - .remove = lpc18xx_pwm_remove, + .remove_new = lpc18xx_pwm_remove, }; module_platform_driver(lpc18xx_pwm_driver);