From patchwork Fri Mar 3 18:54:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13159424 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B18BCC7EE2D for ; Fri, 3 Mar 2023 19:00:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tO19TjsjIHFbkxcVBFrYrSyeXqaM8Uj0SIhXH/1a4JI=; b=5G9+eHC6r5DGSi SkrDwAxyRzhPzVXnrX6CWAQZIcIZSOvMNOELDcSu2NNFp6DSSWswkeBVCm4ioIFiIhsVAySWHKkyp K0xRltaulUvfYjqXNOw5NU9hZjiPpJBeVabrcza4LFytsoldGoK+GewOzLesF2n1n20/jzbqyBydo O5HU+QJ+OQbJuP3hkmqQo63xSJCpc9mrLIY/zlYyGu2fztqPqUWHsHRw6PdP6d35KgGZBrRwIjNRU DBaByLkfdLl8j1GvqGu9UoXm16+E4fIPG20Fq/fyX3xC1x36R5Nw3EorOqDihYdNGtHwvm9o8lGy6 E3n624x1YHg+4p+3eq7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pYAcV-007Exw-BU; Fri, 03 Mar 2023 18:59:08 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pYAYk-007CtR-AC for linux-arm-kernel@lists.infradead.org; Fri, 03 Mar 2023 18:55:15 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pYAYc-0006WH-KJ; Fri, 03 Mar 2023 19:55:06 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pYAYb-001cVh-5G; Fri, 03 Mar 2023 19:55:05 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pYAYY-001ul9-02; Fri, 03 Mar 2023 19:55:02 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Thierry Reding , Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue Cc: kernel@pengutronix.de, linux-pwm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH 24/30] pwm: stm32: Convert to platform remove callback returning void Date: Fri, 3 Mar 2023 19:54:39 +0100 Message-Id: <20230303185445.2112695-25-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230303185445.2112695-1-u.kleine-koenig@pengutronix.de> References: <20230303185445.2112695-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1743; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=jmmiE3N34M+f9bnP1i3ZcXKc0KLwveoqbOciUOB61ao=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkAkJWrCRVmtpts6fB4h58ukV4CnbNxk4KoXKBG rQtZQ0yup6JATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAJCVgAKCRDB/BR4rcrs CT+3B/0Z1tun5MtmoFj/1O0B0FihqbDTmjOyymVfU+DfA66JSWdMnqkG9ej3+lx6fM3Emy3T8ok HNfDto+b9idqnAEZzTDx031mKjn2ZahnLeBGuLVoQCa/ki5iEGHGaCRtTzDCnx25i3/grHTyzN0 IHZ2k8gdKsrKbKv6HW0xNcf6gt+zUngvNG4h6mxvOQ38V6asA9RR3hCdndZJ1fOI2p91III+A/R MzoA6+PdkyvCjHBmb9/eq1AsqLaWcFBI1/DYZH1sNRoSHdUYFVTXrpstPwMq2bVnyiL54/BDJr4 TFn9Nqlrm0+BW/K/EIUV32L608DB2qtJoFbjduJcbb/mT5T4 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230303_105514_392586_05ED8753 X-CRM114-Status: GOOD ( 16.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/pwm/pwm-stm32.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/pwm/pwm-stm32.c b/drivers/pwm/pwm-stm32.c index 21e4a34dfff3..a482f7e0e4ab 100644 --- a/drivers/pwm/pwm-stm32.c +++ b/drivers/pwm/pwm-stm32.c @@ -642,7 +642,7 @@ static int stm32_pwm_probe(struct platform_device *pdev) return 0; } -static int stm32_pwm_remove(struct platform_device *pdev) +static void stm32_pwm_remove(struct platform_device *pdev) { struct stm32_pwm *priv = platform_get_drvdata(pdev); unsigned int i; @@ -651,8 +651,6 @@ static int stm32_pwm_remove(struct platform_device *pdev) pwm_disable(&priv->chip.pwms[i]); pwmchip_remove(&priv->chip); - - return 0; } static int __maybe_unused stm32_pwm_suspend(struct device *dev) @@ -699,7 +697,7 @@ MODULE_DEVICE_TABLE(of, stm32_pwm_of_match); static struct platform_driver stm32_pwm_driver = { .probe = stm32_pwm_probe, - .remove = stm32_pwm_remove, + .remove_new = stm32_pwm_remove, .driver = { .name = "stm32-pwm", .of_match_table = stm32_pwm_of_match,