From patchwork Fri Mar 3 18:54:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13159407 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81332C7EE2D for ; Fri, 3 Mar 2023 18:56:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QhRZZiAKzY75y+tkE/GmGHLg2oSYOdC9F5bKrKVQEkk=; b=WgazjdGnD0TaeX Jlx2CnEiZdjPrFZwi6pqtqnpe4FfAL6dqLxTDw6ZfFJJsiliizZsr3PqDIUYjvSQlZqQhuVDSdX1W VobiOvT4qyu4Q2gDczuEvX5ozrEZvu6bFQ/UWx3/dZEKVge6cHliZSg/tByxWHwkduVzMU1Rzaue5 V9Fnc4ZFME2n2aTodnX5dGWTIOCZL/X7v7fkOxvjEXGmUlg7pZoDjTAPwLRJfOOlIhb3Y9IryAOLG ySUuf8cRpvWr59c9n2O22nZyjUmrC2HKXpOzfVHPQY2DdAd6FTKjxOJgnpLJA4PW3yld1ZO87KeVq okU02VUCizXmFTO/EfPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pYAYu-007Cwo-VS; Fri, 03 Mar 2023 18:55:25 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pYAYa-007Cmw-3F for linux-arm-kernel@lists.infradead.org; Fri, 03 Mar 2023 18:55:06 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pYAYU-0006AU-Pw; Fri, 03 Mar 2023 19:54:58 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pYAYU-001cTX-3l; Fri, 03 Mar 2023 19:54:58 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pYAYT-001ujj-DV; Fri, 03 Mar 2023 19:54:57 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Thierry Reding , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea Cc: kernel@pengutronix.de, linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 02/30] pwm: atmel-tcb: Convert to platform remove callback returning void Date: Fri, 3 Mar 2023 19:54:17 +0100 Message-Id: <20230303185445.2112695-3-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230303185445.2112695-1-u.kleine-koenig@pengutronix.de> References: <20230303185445.2112695-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1777; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=3GlNnOz2MtF+RCy3uc/VVXQMVqysqqFD9V6WoCSxiaQ=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkAkHnNF5rBx7tUYOXq5l5nt6DU0MNQPqJtnNig krJT5kNPYWJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAJB5wAKCRDB/BR4rcrs CfmQB/9fCdplTw5eXzEZwMmtb6QRrt4TsQrTTbtbZAq/T+YniKaEaCU3Lx+yR6CxUIoHXcSaxCR bHBbyAUHDvl8ibQhN2lBpo5KjbCog60nOyL6f2qs3Ea25PDo/ze0jWVzz4mpK1ytxD9x5LM0Nm2 ks8JMKV3rs1I5b3JAeORVeHNxH/tlL1Kjc3CD/+3+WCfDjuLsO+sCV3VTgtH6iIWaQA9eBiwE4M KDKntBP20yNVbQ3XcUwRCK7WNRY0uOwKQugfEui2gNOAq30zVqpcR6uAhrE/P9zygJXZ0eqhFo7 1jgGp1jGfLDh742LxK0hMhaAs+1dsnjiFbhWZVBW+7lixpcU X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230303_105504_266656_24452F6D X-CRM114-Status: GOOD ( 16.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Claudiu Beznea --- drivers/pwm/pwm-atmel-tcb.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/pwm/pwm-atmel-tcb.c b/drivers/pwm/pwm-atmel-tcb.c index 2837b4ce8053..4a116dc44f6e 100644 --- a/drivers/pwm/pwm-atmel-tcb.c +++ b/drivers/pwm/pwm-atmel-tcb.c @@ -500,7 +500,7 @@ static int atmel_tcb_pwm_probe(struct platform_device *pdev) return err; } -static int atmel_tcb_pwm_remove(struct platform_device *pdev) +static void atmel_tcb_pwm_remove(struct platform_device *pdev) { struct atmel_tcb_pwm_chip *tcbpwm = platform_get_drvdata(pdev); @@ -509,8 +509,6 @@ static int atmel_tcb_pwm_remove(struct platform_device *pdev) clk_disable_unprepare(tcbpwm->slow_clk); clk_put(tcbpwm->slow_clk); clk_put(tcbpwm->clk); - - return 0; } static const struct of_device_id atmel_tcb_pwm_dt_ids[] = { @@ -564,7 +562,7 @@ static struct platform_driver atmel_tcb_pwm_driver = { .pm = &atmel_tcb_pwm_pm_ops, }, .probe = atmel_tcb_pwm_probe, - .remove = atmel_tcb_pwm_remove, + .remove_new = atmel_tcb_pwm_remove, }; module_platform_driver(atmel_tcb_pwm_driver);