From patchwork Fri Mar 3 18:54:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13159410 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 352D8C64EC4 for ; Fri, 3 Mar 2023 18:56:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=J9N2IpIZuLbkYyW0Rb8h1rQZ3lZqGJ4hoaowUUSldLw=; b=NJe5AgmN0pCUNP Z7K6SPGnTeae4aceAHS4cFic1HGqS7gxu5rhMIOX9wmwwm22EGP8+dAqtNfFWjdIg05DH+q6sfp6z 7WFzYbfkSjWKZH4Wd7RRHG5uW7u10uSmQMx3JdFK8wBfAL11JUjcoJdj2d/nmhR6WVqSrERWO/OrL HSUybHgmbKFJYYam3aFGynsdGHK/yhk4MhG4KgIJv6Poi4WscfqdVspV+Fss4wi/y2jHJiiB7K8Up TZcrA558oRKncvp7d4Gh+JjJjU2vrrwmbWchmFH1skMFC/PvRnQbpjPYaE/3g1jDwUdePic4Xq9jN 0Sydoz5DBDh+ANSy9T0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pYAZK-007D8R-Pd; Fri, 03 Mar 2023 18:55:50 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pYAYa-007Cml-3G for linux-arm-kernel@lists.infradead.org; Fri, 03 Mar 2023 18:55:07 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pYAYW-0006Ci-9R; Fri, 03 Mar 2023 19:55:00 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pYAYV-001cTv-II; Fri, 03 Mar 2023 19:54:59 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pYAYU-001uk1-FV; Fri, 03 Mar 2023 19:54:58 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Thierry Reding , Florian Fainelli Cc: kernel@pengutronix.de, Broadcom internal kernel review list , linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 07/30] pwm: brcmstb: Convert to platform remove callback returning void Date: Fri, 3 Mar 2023 19:54:22 +0100 Message-Id: <20230303185445.2112695-8-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230303185445.2112695-1-u.kleine-koenig@pengutronix.de> References: <20230303185445.2112695-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1649; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=rKGg1AFdTpXfdMk4E8fz3PQ1JfukEUGH6p/w4jTHcvU=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkAkH5ONEXWOjOJ5GhOx8Kqs76r9uXfCMfWB1yI rGIxxYEE5uJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAJB+QAKCRDB/BR4rcrs Cak/B/4s1P/7vq2xWpDIjBiVqXQY5mLJX0+7hsRE1RxmHM4Z2qSNyjNWgnynNGvmxboEhGCUHDq cGMMluwN9EJaRJxENVxKgp8Bzw4VCFC8ayR4Dym19gByyREvCgnNhuNjOfjV8Xr6UV2GpJzPAgb 6Ozoaan9bSLsBpkIzm6b/uZLI+W+YJOtv5ybYJWTYPNwMXgciCmPp1AdmMXkLKdeMqZv3Eav9mE qyqCSACdxixxgYdaQFlhu6t+gGFqxUp0eioDTfMi+Mf1E6/VKxKPfyGy7yKNGoNTuZVbqTmVviE E8NKSVnyGfOYpiohn6yUMczL4QsjhvikmA85T7DDE0ngSkJi X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230303_105504_283337_D40BF661 X-CRM114-Status: GOOD ( 16.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/pwm/pwm-brcmstb.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/pwm/pwm-brcmstb.c b/drivers/pwm/pwm-brcmstb.c index 3db3f96edf78..a3faa9a3de7c 100644 --- a/drivers/pwm/pwm-brcmstb.c +++ b/drivers/pwm/pwm-brcmstb.c @@ -275,14 +275,12 @@ static int brcmstb_pwm_probe(struct platform_device *pdev) return ret; } -static int brcmstb_pwm_remove(struct platform_device *pdev) +static void brcmstb_pwm_remove(struct platform_device *pdev) { struct brcmstb_pwm *p = platform_get_drvdata(pdev); pwmchip_remove(&p->chip); clk_disable_unprepare(p->clk); - - return 0; } #ifdef CONFIG_PM_SLEEP @@ -310,7 +308,7 @@ static SIMPLE_DEV_PM_OPS(brcmstb_pwm_pm_ops, brcmstb_pwm_suspend, static struct platform_driver brcmstb_pwm_driver = { .probe = brcmstb_pwm_probe, - .remove = brcmstb_pwm_remove, + .remove_new = brcmstb_pwm_remove, .driver = { .name = "pwm-brcmstb", .of_match_table = brcmstb_pwm_of_match,