From patchwork Sat Mar 4 13:29:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13159904 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CDA81C678DB for ; Sat, 4 Mar 2023 13:32:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gJbnJ/pCQ3Ayml3MJnBGLB4/xh8wAzL0y2zQjf7yqzI=; b=JvIvI5EbivjVHK Aa+KtyXQghYOFYNDzqZX+td03G2PK55i26U7VO8GYfPFfgOazK3c6TfbqkO3HwN0oZ8I3mRv6u1CK LWghttVFwP4P2RKM/97BiGS0MKDC5M1kihVcHGbU5TzVaO/SqYIJlBQGiz8/uwBcvqWqqIAqPK1sv 29hW7M0QJtyCNTtCndBnXTUsY2iSHov0x4sqk5vYVoEuOFmE+Q/SqFbAfIYO9WRKsDV/IIP7/wIwt 27jac4wH7TYQfU/TpCf0ep3gzTuabhVGfmhDOkKRj6mN10QC3a/dorC+1569YUGFV2NyG9BSe/7OB xPkP9lwl2xAGxEi6Afvg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pYRyb-0091Jf-5q; Sat, 04 Mar 2023 13:31:05 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pYRyO-0091FK-7m for linux-arm-kernel@lists.infradead.org; Sat, 04 Mar 2023 13:30:54 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pYRyH-0000cy-76; Sat, 04 Mar 2023 14:30:45 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pYRyG-001nZp-BO; Sat, 04 Mar 2023 14:30:44 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pYRyF-0027Gv-G6; Sat, 04 Mar 2023 14:30:43 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Hans Ulli Kroll , Linus Walleij , Alessandro Zummo , Alexandre Belloni Cc: linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 12/41] rtc: ftrtc010: Convert to platform remove callback returning void Date: Sat, 4 Mar 2023 14:29:59 +0100 Message-Id: <20230304133028.2135435-13-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230304133028.2135435-1-u.kleine-koenig@pengutronix.de> References: <20230304133028.2135435-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1801; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=xBHg3706x1HPwRbGT26FLF7Zze/aj3U7BcO/vZb21QM=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkA0eNxqjC/rXFqS8oJcLXAwetXKDiwM7t3BtAM ENYdu3n0/+JATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZANHjQAKCRDB/BR4rcrs CWbQB/44+4sHXgQNQ3mijaIdkEZTLX5E9DbbvBeGw1YtJJbJfnfgh7IIWBrcEcyPDMz0Dihfd4B doz2bszzOoKQS7Tnzi/kx2Rgq8kJ++gbCASROusoJ4WZc62HEsAQFc1rlPiFoGF6cBHEAQNbAKE lFQEgrDCJ8h2IIioVh8WN5BItgtlyz5lnz7SB0zubA3NJXNeesi1kuOSLeVvR78gGfx9Wmdv+TY RHnaBVmUbLWDh8G1fUyMtbLXfc10Q7eQYJwbp6bDKf+rwUtV0+I30oKjgvy/lU3VvxBQDkXWCe/ FCNgLuM4Yb+l03cbXfXuqCYxVwTImlhaeyrDDlY12/LNRYky X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230304_053052_467559_40A95F5C X-CRM114-Status: GOOD ( 17.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Acked-by: Linus Walleij --- drivers/rtc/rtc-ftrtc010.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/rtc/rtc-ftrtc010.c b/drivers/rtc/rtc-ftrtc010.c index 25c6e7d9570f..8bfe7378f653 100644 --- a/drivers/rtc/rtc-ftrtc010.c +++ b/drivers/rtc/rtc-ftrtc010.c @@ -191,7 +191,7 @@ static int ftrtc010_rtc_probe(struct platform_device *pdev) return ret; } -static int ftrtc010_rtc_remove(struct platform_device *pdev) +static void ftrtc010_rtc_remove(struct platform_device *pdev) { struct ftrtc010_rtc *rtc = platform_get_drvdata(pdev); @@ -199,8 +199,6 @@ static int ftrtc010_rtc_remove(struct platform_device *pdev) clk_disable_unprepare(rtc->extclk); if (!IS_ERR(rtc->pclk)) clk_disable_unprepare(rtc->pclk); - - return 0; } static const struct of_device_id ftrtc010_rtc_dt_match[] = { @@ -216,7 +214,7 @@ static struct platform_driver ftrtc010_rtc_driver = { .of_match_table = ftrtc010_rtc_dt_match, }, .probe = ftrtc010_rtc_probe, - .remove = ftrtc010_rtc_remove, + .remove_new = ftrtc010_rtc_remove, }; module_platform_driver_probe(ftrtc010_rtc_driver, ftrtc010_rtc_probe);