diff mbox series

[v12,2/2] dt-bindings: arm: fsl: Add i.MX8MM-EVK revision B

Message ID 20230307044449.2714529-3-johannes.schneider@leica-geosystems.com (mailing list archive)
State New, archived
Headers show
Series pmic on imx8mm | expand

Commit Message

SCHNEIDER Johannes March 7, 2023, 4:44 a.m. UTC
Add DT compatible strings for recent EVKs, that come with a different PMIC.

The most recent revision of the 'original' EVK CPU module is C2 and the most
recent revision of EVKB CPU2 module is A4.

Reviewed-by: Shawn Guo <shawnguo@kernel.org>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
Signed-off-by: Johannes Schneider <johannes.schneider@leica-geosystems.com>
---
 Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski March 7, 2023, 6:24 a.m. UTC | #1
On 07/03/2023 05:44, Johannes Schneider wrote:
> Add DT compatible strings for recent EVKs, that come with a different PMIC.
> 
> The most recent revision of the 'original' EVK CPU module is C2 and the most
> recent revision of EVKB CPU2 module is A4.
> 
> Reviewed-by: Shawn Guo <shawnguo@kernel.org>

Where did you get this tag?

> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
> Signed-off-by: Johannes Schneider <johannes.schneider@leica-geosystems.com>

Best regards,
Krzysztof
Marco Felsch March 7, 2023, 9:02 a.m. UTC | #2
Hi Johannes,

On 23-03-07, Johannes Schneider wrote:
> Add DT compatible strings for recent EVKs, that come with a different PMIC.
> 
> The most recent revision of the 'original' EVK CPU module is C2 and the most
> recent revision of EVKB CPU2 module is A4.
> 
> Reviewed-by: Shawn Guo <shawnguo@kernel.org>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>

I did not added this for this series and I wouldn't since it is not
revision B as discussed earlier.

> Signed-off-by: Johannes Schneider <johannes.schneider@leica-geosystems.com>
> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index fbfc4f99c01e..d906896b560e 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -818,6 +818,7 @@ properties:
>                - emtrion,emcon-mx8mm-avari # emCON-MX8MM SoM on Avari Base
>                - fsl,imx8mm-ddr4-evk       # i.MX8MM DDR4 EVK Board
>                - fsl,imx8mm-evk            # i.MX8MM EVK Board
> +              - fsl,imx8mm-evk-revb       # i.MX8MM EVK Revision B Board

We are running cycles, please wait some time till the discussion
settled :)

Regards,
  Marco

>                - gateworks,imx8mm-gw7904
>                - gw,imx8mm-gw71xx-0x       # i.MX8MM Gateworks Development Kit
>                - gw,imx8mm-gw72xx-0x       # i.MX8MM Gateworks Development Kit
> -- 
> 2.25.1
> 
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index fbfc4f99c01e..d906896b560e 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -818,6 +818,7 @@  properties:
               - emtrion,emcon-mx8mm-avari # emCON-MX8MM SoM on Avari Base
               - fsl,imx8mm-ddr4-evk       # i.MX8MM DDR4 EVK Board
               - fsl,imx8mm-evk            # i.MX8MM EVK Board
+              - fsl,imx8mm-evk-revb       # i.MX8MM EVK Revision B Board
               - gateworks,imx8mm-gw7904
               - gw,imx8mm-gw71xx-0x       # i.MX8MM Gateworks Development Kit
               - gw,imx8mm-gw72xx-0x       # i.MX8MM Gateworks Development Kit