| Message ID | 20230307080555.14399-3-yong.wu@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | MT8188 IOMMU SUPPORT | expand |
Il 07/03/23 09:05, Yong Wu ha scritto: > When we enable PGTABLE_PA_35_EN, the PA for pgtable may be 35bits. > Thus add dma_mask for it. > > Fixes: 301c3ca12576 ("iommu/mediatek: Allow page table PA up to 35bit") > Signed-off-by: Chengci.Xu <chengci.xu@mediatek.com> > Signed-off-by: Yong Wu <yong.wu@mediatek.com> I would send this patch separately from the MT8188 series, as that's purely a (quite important) fix that is not specific to the introduction of MT8188, even though that SoC needs that fix. Regardless of that, Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c index e0264d5f1c9a..f2716896fee4 100644 --- a/drivers/iommu/mtk_iommu.c +++ b/drivers/iommu/mtk_iommu.c @@ -1297,6 +1297,14 @@ static int mtk_iommu_probe(struct platform_device *pdev) return PTR_ERR(data->bclk); } + if (MTK_IOMMU_HAS_FLAG(data->plat_data, PGTABLE_PA_35_EN)) { + ret = dma_set_mask(dev, DMA_BIT_MASK(35)); + if (!ret) { + dev_err(dev, "Failed to set dma_mask 35.\n"); + return ret; + } + } + pm_runtime_enable(dev); if (MTK_IOMMU_IS_TYPE(data->plat_data, MTK_IOMMU_TYPE_MM)) {
When we enable PGTABLE_PA_35_EN, the PA for pgtable may be 35bits. Thus add dma_mask for it. Fixes: 301c3ca12576 ("iommu/mediatek: Allow page table PA up to 35bit") Signed-off-by: Chengci.Xu <chengci.xu@mediatek.com> Signed-off-by: Yong Wu <yong.wu@mediatek.com> --- drivers/iommu/mtk_iommu.c | 8 ++++++++ 1 file changed, 8 insertions(+)