| Message ID | 20230307170046.28917-9-ansuelsmth@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | net: Add basic LED support for switch/phy | expand |
On Tue, Mar 07, 2023 at 06:00:43PM +0100, Christian Marangi wrote: > Document support for LEDs node in dsa port. > Switch may support different LEDs that can be configured for different > operation like blinking on traffic event or port link. > > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> > --- > Documentation/devicetree/bindings/net/dsa/dsa-port.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/dsa/dsa-port.yaml b/Documentation/devicetree/bindings/net/dsa/dsa-port.yaml > index 480120469953..f813e1f64f75 100644 > --- a/Documentation/devicetree/bindings/net/dsa/dsa-port.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/dsa-port.yaml > @@ -59,6 +59,13 @@ properties: > - rtl8_4t > - seville > > + leds: > + type: object > + > + patternProperties: > + '^led(@[a-f0-9]+)?$': > + $ref: /schemas/leds/common.yaml# Please could you add a description here documenting that these are LEDs the switch controls in its MACs. They are not LEDs in the possibly integrated PHY, which the PHY driver controls. We got this wrong, so i'm sure others will as well. So a bit of documentation should help avoid this. Andrew
On 07/03/2023 18:00, Christian Marangi wrote: > Document support for LEDs node in dsa port. > Switch may support different LEDs that can be configured for different > operation like blinking on traffic event or port link. > > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> > --- > Documentation/devicetree/bindings/net/dsa/dsa-port.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/dsa/dsa-port.yaml b/Documentation/devicetree/bindings/net/dsa/dsa-port.yaml > index 480120469953..f813e1f64f75 100644 > --- a/Documentation/devicetree/bindings/net/dsa/dsa-port.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/dsa-port.yaml > @@ -59,6 +59,13 @@ properties: > - rtl8_4t > - seville > > + leds: > + type: object additionalProperties: false Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/dsa/dsa-port.yaml b/Documentation/devicetree/bindings/net/dsa/dsa-port.yaml index 480120469953..f813e1f64f75 100644 --- a/Documentation/devicetree/bindings/net/dsa/dsa-port.yaml +++ b/Documentation/devicetree/bindings/net/dsa/dsa-port.yaml @@ -59,6 +59,13 @@ properties: - rtl8_4t - seville + leds: + type: object + + patternProperties: + '^led(@[a-f0-9]+)?$': + $ref: /schemas/leds/common.yaml# + # CPU and DSA ports must have phylink-compatible link descriptions if: oneOf:
Document support for LEDs node in dsa port. Switch may support different LEDs that can be configured for different operation like blinking on traffic event or port link. Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> --- Documentation/devicetree/bindings/net/dsa/dsa-port.yaml | 7 +++++++ 1 file changed, 7 insertions(+)