From patchwork Fri Mar 10 11:31:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cheng Ziqiu X-Patchwork-Id: 13169186 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9EE8DC6FA99 for ; Fri, 10 Mar 2023 11:33:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=KkKCI089u9CMtVXkY+aLIhinWPSj/RtoY5BTmF9GeYE=; b=X2el1NniJVf84k WbcfGclohmwqajsMUOn6pvqZXLeXJGj7RifvIJa9ErvtHEngfU52BZ+0KSZTBaoenMUvDUo/8HHbi HEQlmZfOz5kUPOwn7y1qoDkQhQ6VpOnKfKh/dFGVS9EwxqSGIVYC93/6Xa+/xf0biUF4+TgGN2xab QwtwesKAnmC1VPtBsXsLOmJjtvBHu8Zeo4dPnJg3u7sQjsHbGBdxJBgKxDHg/5VHa8x08Xk3xvtSk QALCIQTslzVwR/aeKmoWzLCrrINWCuNDin/URolETk3JeWYwJm6tozvha1csfAC76Ilb7qSsz9hOa UCEDXLMOhhHLoA2y239w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1paazV-00ENJZ-Hy; Fri, 10 Mar 2023 11:32:53 +0000 Received: from mail.hust.edu.cn ([202.114.0.240] helo=hust.edu.cn) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1paazR-00ENGo-2y for linux-arm-kernel@lists.infradead.org; Fri, 10 Mar 2023 11:32:50 +0000 Received: from Chengziqiu-Lab-Desktop.. ([172.16.0.254]) (user=chengziqiu@hust.edu.cn mech=LOGIN bits=0) by mx1.hust.edu.cn with ESMTP id 32ABW23d008330-32ABW23e008330 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 10 Mar 2023 19:32:06 +0800 From: Cheng Ziqiu To: Eugen Hristev , Jonathan Cameron , Lars-Peter Clausen , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea Cc: Cheng Ziqiu , Dongliang Mu , linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] drivers: iio: remove dead code in at91_adc_probe Date: Fri, 10 Mar 2023 19:31:58 +0800 Message-Id: <20230310113158.428940-1-chengziqiu@hust.edu.cn> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-FEAS-AUTH-USER: chengziqiu@hust.edu.cn X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230310_033249_504191_779E8BCB X-CRM114-Status: GOOD ( 10.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From the comment of platform_get_irq, it only returns non-zero IRQ number and negative error number, other than zero. Fix this by removing the if condition. Signed-off-by: Cheng Ziqiu Reviewed-by: Dongliang Mu --- v1->v2: Change commit message from SoB to Reviewed-by. drivers/iio/adc/at91-sama5d2_adc.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c index 50d02e5fc6fc..168399092590 100644 --- a/drivers/iio/adc/at91-sama5d2_adc.c +++ b/drivers/iio/adc/at91-sama5d2_adc.c @@ -2400,12 +2400,8 @@ static int at91_adc_probe(struct platform_device *pdev) st->dma_st.phys_addr = res->start; st->irq = platform_get_irq(pdev, 0); - if (st->irq <= 0) { - if (!st->irq) - st->irq = -ENXIO; - + if (st->irq < 0) return st->irq; - } st->per_clk = devm_clk_get(&pdev->dev, "adc_clk"); if (IS_ERR(st->per_clk))