From patchwork Mon Mar 13 15:51:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Zimmermann X-Patchwork-Id: 13172821 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4D66C6FD19 for ; Mon, 13 Mar 2023 16:04:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hNWVX1UnfWGvnOXitX0gUfR9PPR+OeMQHWctf2F7VsY=; b=b3ODUPec0c8Eoa ZO63Svgt0nDY2oast1oUmHxHP6ASdA/7SyyZ0vdDYjYxjlam5xhcnCjy/ml//A30Ukt3rxvoojJFd hhxg/s7/ti5iYq7qwxgR20yzWH0cBKLxFw2/YkYyGO1ajq2HSSbU0Oer79vdQI/Lb+U5zMRb2OmwZ bOTnTinkPXDTmysJa1Kras5fkpngt6IPMT54d1ZoCOoz8L5ToWS+fCZtNAHQ9tmWQm/9UkARhZyR6 qz+oW3LQ5VJUPejUKbfzb7VIgRU/69arNV9ynXCcmBBhyq/3r0lh9AJGpUUMXB9+KE7oB+89OEZch HR6OM5B0Dyp5z2ThvhtA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pbkdZ-006b2I-Il; Mon, 13 Mar 2023 16:03:01 +0000 Received: from smtp-out1.suse.de ([195.135.220.28]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pbkSn-006VVG-If; Mon, 13 Mar 2023 15:51:58 +0000 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D3D6422AE2; Mon, 13 Mar 2023 15:51:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1678722706; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YvjxTL+yszp3Qk83TsIdpDskTlMr4i6JlrFyXHd0Dq4=; b=DoLM46yIRboaMIKMa8epGJMiWJyMZ+D+CUJG4w+79JP9NgpZSxGVWKbtOZ0OIAzgVOaudv wZsk6hFWNtM1TFQu3r6ZBs4TeUH8nrECdhN6qy9j7LoVu5gL96N3IZ1HeqJ8aSC38fyxSr 23ksaRSyPMNioUWhJKn4B31d7CSvUDo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1678722706; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YvjxTL+yszp3Qk83TsIdpDskTlMr4i6JlrFyXHd0Dq4=; b=NfUPabzmLwXAej4fxUfruTNpIBzlnHdOCQ4KwUYDtQF7ZNBAH5V+qDkMolTYLFcNij3IsO L4WQN2y7QF94aPDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9537313517; Mon, 13 Mar 2023 15:51:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id KK2OI5JGD2RhegAAMHmgww (envelope-from ); Mon, 13 Mar 2023 15:51:46 +0000 From: Thomas Zimmermann To: javierm@redhat.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, airlied@gmail.com, daniel@ffwll.ch, linus.walleij@linaro.org Cc: linux-aspeed@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, linux-amlogic@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Thomas Zimmermann Subject: [PATCH v2 25/25] drm/pl111: Use GEM DMA fbdev emulation Date: Mon, 13 Mar 2023 16:51:38 +0100 Message-Id: <20230313155138.20584-26-tzimmermann@suse.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230313155138.20584-1-tzimmermann@suse.de> References: <20230313155138.20584-1-tzimmermann@suse.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230313_085153_836318_DEC8B1E8 X-CRM114-Status: GOOD ( 12.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use the fbdev emulation that is optimized for DMA helpers. Avoids possible shadow buffering and makes the code simpler. Reported-by: Linus Walleij Link: https://lore.kernel.org/dri-devel/CACRpkdawSQsNqKJkSSoSw3HmMHyNXFUywxkdszpTC-a_uZA+tQ@mail.gmail.com/ Signed-off-by: Thomas Zimmermann Reviewed-by: Linus Walleij --- drivers/gpu/drm/pl111/pl111_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/pl111/pl111_drv.c b/drivers/gpu/drm/pl111/pl111_drv.c index 00deba0b7271..4b2a9e9753f6 100644 --- a/drivers/gpu/drm/pl111/pl111_drv.c +++ b/drivers/gpu/drm/pl111/pl111_drv.c @@ -48,7 +48,7 @@ #include #include #include -#include +#include #include #include #include @@ -308,7 +308,7 @@ static int pl111_amba_probe(struct amba_device *amba_dev, if (ret < 0) goto dev_put; - drm_fbdev_generic_setup(drm, priv->variant->fb_bpp); + drm_fbdev_dma_setup(drm, priv->variant->fb_bpp); return 0;