| Message ID | 20230321033810.22017-1-lukas.bulwahn@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: mstar: remove unused config MACH_MERCURY | expand |
Hi Lukas On Tue, 21 Mar 2023 at 12:38, Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote: > > Commit 312b62b6610c ("ARM: mstar: Add machine for MStar/Sigmastar Armv7 > SoCs") adds the config MACH_INFINITY and MACH_MERCURY. The MACH_INFINITY > config is used in the gpio-msc313 driver, but the MACH_MERCURY config is > never used to configure anything in the kernel tree. > > Remove the unused config MACH_MERCURY. Because work is still on going to push that stuff. nak from me. Thanks, Daniel
On Tue, Mar 21, 2023 at 05:33:19PM +0900, Daniel Palmer wrote: > Hi Lukas > > On Tue, 21 Mar 2023 at 12:38, Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote: > > > > Commit 312b62b6610c ("ARM: mstar: Add machine for MStar/Sigmastar Armv7 > > SoCs") adds the config MACH_INFINITY and MACH_MERCURY. The MACH_INFINITY > > config is used in the gpio-msc313 driver, but the MACH_MERCURY config is > > never used to configure anything in the kernel tree. > > > > Remove the unused config MACH_MERCURY. > > Because work is still on going to push that stuff. Is there a link to the patchset? > > nak from me. This stuff hasn't been used for years. We generally don't push dummy code. It's super easy to add it back when the time comes. regards, dan carpenter
On Tue, Mar 21, 2023, at 09:33, Daniel Palmer wrote: > Hi Lukas > > On Tue, 21 Mar 2023 at 12:38, Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote: >> >> Commit 312b62b6610c ("ARM: mstar: Add machine for MStar/Sigmastar Armv7 >> SoCs") adds the config MACH_INFINITY and MACH_MERCURY. The MACH_INFINITY >> config is used in the gpio-msc313 driver, but the MACH_MERCURY config is >> never used to configure anything in the kernel tree. >> >> Remove the unused config MACH_MERCURY. > > Because work is still on going to push that stuff. > > nak from me. The symbol has been unused three year though, and will show up every time someone runs a script to look for orphaned Kconfig entries. I'd still prefer removing it now and only bringing it back when you actually add the code for it. Arnd
Hi Arnd, On Tue, 21 Mar 2023 at 18:30, Arnd Bergmann <arnd@arndb.de> wrote: > I'd still prefer removing it now and only bringing it > back when you actually add the code for it. Fair enough. Code does exist for it in my tree but I never got around to sending it. I rescind my nak. Cheers, Daniel
Hi, After discussion with Daniel, we agree that's an unused and an orphaned Kconfig symbol (we cannot really argue against it). We agree to remove it, it will be reverted back for a future patches set. Acked-by: Romain Perier <romain.perier@gmail.com> Le mar. 21 mars 2023 à 10:30, Arnd Bergmann <arnd@arndb.de> a écrit : > > On Tue, Mar 21, 2023, at 09:33, Daniel Palmer wrote: > > Hi Lukas > > > > On Tue, 21 Mar 2023 at 12:38, Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote: > >> > >> Commit 312b62b6610c ("ARM: mstar: Add machine for MStar/Sigmastar Armv7 > >> SoCs") adds the config MACH_INFINITY and MACH_MERCURY. The MACH_INFINITY > >> config is used in the gpio-msc313 driver, but the MACH_MERCURY config is > >> never used to configure anything in the kernel tree. > >> > >> Remove the unused config MACH_MERCURY. > > > > Because work is still on going to push that stuff. > > > > nak from me. > > The symbol has been unused three year though, and will > show up every time someone runs a script to look for > orphaned Kconfig entries. > > I'd still prefer removing it now and only bringing it > back when you actually add the code for it. > > Arnd
diff --git a/arch/arm/mach-mstar/Kconfig b/arch/arm/mach-mstar/Kconfig index 5dbea7b485af..fa9709f30b46 100644 --- a/arch/arm/mach-mstar/Kconfig +++ b/arch/arm/mach-mstar/Kconfig @@ -20,11 +20,4 @@ config MACH_INFINITY help Support for MStar/Sigmastar infinity IP camera SoCs. -config MACH_MERCURY - bool "MStar/Sigmastar mercury SoC support" - default ARCH_MSTARV7 - help - Support for MStar/Sigmastar mercury dash camera SoCs. - Note that older Mercury2 SoCs are ARM9 based and not supported. - endif
Commit 312b62b6610c ("ARM: mstar: Add machine for MStar/Sigmastar Armv7 SoCs") adds the config MACH_INFINITY and MACH_MERCURY. The MACH_INFINITY config is used in the gpio-msc313 driver, but the MACH_MERCURY config is never used to configure anything in the kernel tree. Remove the unused config MACH_MERCURY. Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> --- arch/arm/mach-mstar/Kconfig | 7 ------- 1 file changed, 7 deletions(-)