diff mbox series

[v2] arm64: defconfig: Enable CAN PHY transceiver driver

Message ID 20230323113324.361991-1-b-kapoor@ti.com (mailing list archive)
State New, archived
Headers show
Series [v2] arm64: defconfig: Enable CAN PHY transceiver driver | expand

Commit Message

Bhavya Kapoor March 23, 2023, 11:33 a.m. UTC
Enable CAN PHY transceiver driver to be built as a module.

Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
---
changelog v1->v2:
 - changed position of config in the file

 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Bjorn Andersson March 23, 2023, 1:53 p.m. UTC | #1
On Thu, Mar 23, 2023 at 05:03:24PM +0530, Bhavya Kapoor wrote:
> Enable CAN PHY transceiver driver to be built as a module.

Please use the commit message to describe why the driver should be
enabled. The patch and the subject already states clearly that the
driver is being enabled.

Regards,
Bjorn

> 
> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
> ---
> changelog v1->v2:
>  - changed position of config in the file
> 
>  arch/arm64/configs/defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 7790ee42c68a..6e123de3a9cf 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -1292,6 +1292,7 @@ CONFIG_RESET_QCOM_PDC=m
>  CONFIG_RESET_RZG2L_USBPHY_CTRL=y
>  CONFIG_RESET_TI_SCI=y
>  CONFIG_PHY_XGENE=y
> +CONFIG_PHY_CAN_TRANSCEIVER=m
>  CONFIG_PHY_SUN4I_USB=y
>  CONFIG_PHY_CADENCE_TORRENT=m
>  CONFIG_PHY_CADENCE_SIERRA=m
> -- 
> 2.34.1
>
Geert Uytterhoeven March 23, 2023, 4:09 p.m. UTC | #2
On Thu, Mar 23, 2023 at 2:53 PM Bjorn Andersson
<quic_bjorande@quicinc.com> wrote:
> On Thu, Mar 23, 2023 at 05:03:24PM +0530, Bhavya Kapoor wrote:
> > Enable CAN PHY transceiver driver to be built as a module.
>
> Please use the commit message to describe why the driver should be
> enabled. The patch and the subject already states clearly that the
> driver is being enabled.

And if no one has inspiration: I wouldn't mind "because it is needed
for CAN-FD on the Renesas White-Hawk development board" ;-)

> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -1292,6 +1292,7 @@ CONFIG_RESET_QCOM_PDC=m
> >  CONFIG_RESET_RZG2L_USBPHY_CTRL=y
> >  CONFIG_RESET_TI_SCI=y
> >  CONFIG_PHY_XGENE=y
> > +CONFIG_PHY_CAN_TRANSCEIVER=m
> >  CONFIG_PHY_SUN4I_USB=y
> >  CONFIG_PHY_CADENCE_TORRENT=m
> >  CONFIG_PHY_CADENCE_SIERRA=m

For the actual change:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert
Bhavya Kapoor March 24, 2023, 6:15 a.m. UTC | #3
On 23/03/23 21:39, Geert Uytterhoeven wrote:
> On Thu, Mar 23, 2023 at 2:53 PM Bjorn Andersson
> <quic_bjorande@quicinc.com> wrote:
>> On Thu, Mar 23, 2023 at 05:03:24PM +0530, Bhavya Kapoor wrote:
>>> Enable CAN PHY transceiver driver to be built as a module.
>> Please use the commit message to describe why the driver should be
>> enabled. The patch and the subject already states clearly that the
>> driver is being enabled.
> And if no one has inspiration: I wouldn't mind "because it is needed
> for CAN-FD on the Renesas White-Hawk development board" ;-)

Ahh , i do have the inspiration,lol 
diff mbox series

Patch

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 7790ee42c68a..6e123de3a9cf 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1292,6 +1292,7 @@  CONFIG_RESET_QCOM_PDC=m
 CONFIG_RESET_RZG2L_USBPHY_CTRL=y
 CONFIG_RESET_TI_SCI=y
 CONFIG_PHY_XGENE=y
+CONFIG_PHY_CAN_TRANSCEIVER=m
 CONFIG_PHY_SUN4I_USB=y
 CONFIG_PHY_CADENCE_TORRENT=m
 CONFIG_PHY_CADENCE_SIERRA=m