From patchwork Sun Mar 26 14:31:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13188298 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4907CC6FD1C for ; Sun, 26 Mar 2023 14:36:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KZmK50UUOrJhwCyyq5BGIxsSCI+1/4oY0Ko+r9PTb3o=; b=sr6FpJUb5ymO8B WKfEuHO8Uondx4573GHSqlspyTJ4o5dJiAVdt+Q3TTTI14WDkMgz4p0ua2XEqlGP+ONxODPdK+/6+ C9+/6a7JX5j7Cot+zPjhzsJQl6Gw+/ioaOPjlvDkV04cFh3yvDvSQqaoK4bBb8zLKtqeBtY6ENiG1 KMHSl+WyQm+WKoAX8NStQoCfkNsIiReSjENblqK/4ZQ8A5UZ+zYtxlVd09S1IKZYjb6iCr1H44JTb O8DHzX+kAZRB24Sc3uiOoKWnN0iWR7rqJlneT0hIq0w7CW33CjInXu+2SOCf9gR475rMC6qbFBon6 IHMZBT1azZOOyOVTQgUA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pgRTH-008b4z-1K; Sun, 26 Mar 2023 14:35:47 +0000 Received: from casper.infradead.org ([90.155.50.34]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pgRQg-008YuF-0m for linux-arm-kernel@bombadil.infradead.org; Sun, 26 Mar 2023 14:33:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description; bh=PWT5qL+pjfbKXwf15QVFHxfpLSknOn1/h8kILmNXwrI=; b=r7rhJOpR+0ErH6zTzbXLNCSzOW /TgiEZmMKYuKk0krsu6nkzbPM12K9Ptqg8C0X3tWUaRlH+i6spW7AXQQBR8k3eLC/fypA2whAzbQu 8hRBNN8hPwN/9EJJ6eD6YwbDxy4qBhyr5YLmtLDXpLqr15rrW4wmF9fV9pCIfX/pp9hiZOWqRRqgp 3bmwTIYlmXAt30vPBD2OQP5WnkKz2mwQ1GLchQqvRzpwwib6/qlC6WQIBK5laY5qk0ql2ROBBo9vo MLatWx22Sp40QAbSzNL2u+dB3yd4kJ8maHstXtNiywlCnI9fhS6LDqz0M8Hzckpro+fJY7zx2Yi2N hVDrLoDg==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by casper.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pgRQX-006aVK-Bt for linux-arm-kernel@lists.infradead.org; Sun, 26 Mar 2023 14:33:05 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pgRQN-0000AI-9o; Sun, 26 Mar 2023 16:32:47 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pgRQK-006rf1-02; Sun, 26 Mar 2023 16:32:44 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pgRQI-0088Yw-Tt; Sun, 26 Mar 2023 16:32:42 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Paul Kocialkowski , Mauro Carvalho Chehab , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Cc: linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@pengutronix.de Subject: [PATCH 080/117] media: sun6i_mipi_csi2: Convert to platform remove callback returning void Date: Sun, 26 Mar 2023 16:31:47 +0200 Message-Id: <20230326143224.572654-83-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230326143224.572654-1-u.kleine-koenig@pengutronix.de> References: <20230326143224.572654-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2004; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=jQPDsQVruAOUtxy6LPdqmQOfAEZivBfr3gDXNDkVj/k=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkIFblvrLuiuS45ZAzXk6hDA5q01ywy1BMMtsGy f8VyU5LzueJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZCBW5QAKCRCPgPtYfRL+ TuxtCACtTiMScCpHJoEnxcJ7bs2eib8WhF39+8QWG7QK02o8P9nG96sJYwrrUAG5eAokqmnKEHQ 5uLfu4JvzADkO2IoIEqYkLKnfzuNP2sDsLWv0RkzhI3ShyGStQzITC9tjhXS3It91CQGcOVWMCS PamUrYmkvrcg3hhGQ1V41QhPIcW6tjSKfLZv0Auna/kF8IOQuxXzwHr+xuGWSLirBgKu1gIgbCH AFk/B5q/Tf0rR5EWCiG1f/5l6hkdbPxD0H3j0+zxafi5DWoBKfbjoG6K8neind5Msq9G5saumz3 efKoHKp1A8VvuM2RzfTHLEz9uWELE7qb7/Qfa6CvBEjsjDfx X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230326_153257_619255_8004A25A X-CRM114-Status: GOOD ( 14.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Acked-by: Jernej Skrabec --- .../media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c b/drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c index a220ce849b41..dce130b4c9f6 100644 --- a/drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c +++ b/drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c @@ -737,15 +737,13 @@ static int sun6i_mipi_csi2_probe(struct platform_device *platform_dev) return ret; } -static int sun6i_mipi_csi2_remove(struct platform_device *platform_dev) +static void sun6i_mipi_csi2_remove(struct platform_device *platform_dev) { struct sun6i_mipi_csi2_device *csi2_dev = platform_get_drvdata(platform_dev); sun6i_mipi_csi2_bridge_cleanup(csi2_dev); sun6i_mipi_csi2_resources_cleanup(csi2_dev); - - return 0; } static const struct of_device_id sun6i_mipi_csi2_of_match[] = { @@ -756,7 +754,7 @@ MODULE_DEVICE_TABLE(of, sun6i_mipi_csi2_of_match); static struct platform_driver sun6i_mipi_csi2_platform_driver = { .probe = sun6i_mipi_csi2_probe, - .remove = sun6i_mipi_csi2_remove, + .remove_new = sun6i_mipi_csi2_remove, .driver = { .name = SUN6I_MIPI_CSI2_NAME, .of_match_table = of_match_ptr(sun6i_mipi_csi2_of_match),