From patchwork Sun Mar 26 14:31:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13188306 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65192C6FD1C for ; Sun, 26 Mar 2023 14:39:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bhZo29Ta9privcXpTKuUUcUZlpdIv6o4S8WbEi+4okY=; b=r6Zpv8D+MnZfj7 tBFwZ4RnknroVZiIpLulWCqTi0pC+cy6h8WGmVd23YAquBEtZFQEpnbllq28cskVH0oRtGd423QqR mC4MYGIX2ZsINi7Cnb8YHWS2YW7sxJqkASn5MufkotUnag9iVnm1IcTacDtjqL3X/p1BDyievsW+7 MY2m/OFNCV9s/uTRxWq1aeR5LamcgqeoEP8TmVv3Py++WjblPrSPPMzeuEpF/lYiYY/+8o03vljoO 1f/crs0MozU4TOGPr302v01D4jb+wmdqPwNLbEUCSImnBYxm5oIeaz1VgnGG4ybnqXWeOVr5uTsyF ZBNVeoQCoWvNctuo+rDA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pgRVT-008ciF-2U; Sun, 26 Mar 2023 14:38:03 +0000 Received: from casper.infradead.org ([90.155.50.34]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pgRQs-008Z8P-2z for linux-arm-kernel@bombadil.infradead.org; Sun, 26 Mar 2023 14:33:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description; bh=hS1Rc5B0XS8UlBZADWazgPiAqzg7UtaDntAuyt+N7ZE=; b=f5DCcPN0IdtBMhJlczjJ+ZLCjx DZf856NGTdOG66rsRR6uAWMMJnA6k5BwkuqTYarEthOLrF40a/BJ7c/CWHw9+n8qGU7fLdsDDQcY6 xaVl8x0mMeDYslbVIP+ShybYtep22naQxxlFxxxzAdSHsU7BoBm0pb3XAbgGUT3XAL7FIvXxEx+kj BRgacBMXzKHPn29R8fRe2I0k5837gr/s7ycrCbgto85ySdDHFTxehd13eGrHEdlB3WTiuD/PzSwgY P9TsY5ZPIVvwdjMgx9MKMSAJlIIM7Qy3ehXdBMKcc0wnZTLDyZtsZw0tukPvcQvQMS6UPV7Jk4ljV HGp9d3QA==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by casper.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pgRQp-006aSe-NE for linux-arm-kernel@lists.infradead.org; Sun, 26 Mar 2023 14:33:17 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pgRQN-0000Ao-H7; Sun, 26 Mar 2023 16:32:47 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pgRQK-006rf7-6S; Sun, 26 Mar 2023 16:32:44 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pgRQJ-0088Z0-52; Sun, 26 Mar 2023 16:32:43 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Mauro Carvalho Chehab , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Hans Verkuil , Paul Kocialkowski , Sakari Ailus , Maxime Ripard , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Christophe JAILLET Cc: linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@pengutronix.de Subject: [PATCH 081/117] media: sun8i_a83t_mipi_csi2: Convert to platform remove callback returning void Date: Sun, 26 Mar 2023 16:31:48 +0200 Message-Id: <20230326143224.572654-84-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230326143224.572654-1-u.kleine-koenig@pengutronix.de> References: <20230326143224.572654-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2114; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=k9x8HzVlyO7nqBiHyTmH/ywca9Pw/7RppQDC+gh421I=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkIFbmAbo3t/O7sXR98QYLqTmcRer9F9ZO1B245 G0ILVvnNlWJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZCBW5gAKCRCPgPtYfRL+ Tl2jB/9BovhRmpZKHAU3NPpips1+iUG8LVAqyxsVRkanp+lGCOsrmCb9HFCEWuNFNzK+np/o+Tj rTxNTSg3yOLwjohHDTgTq8qhNVOX+j+QP8rB4tAu13wldgnfy5e/rZcZSrzzvj38qLi/low4452 gPfFPO9NIMAOBFHvyBbT+g40ib6zlqwenGkEGSmTQN49i+lqRUPRINUEetLC0+fLbIFuhljIs3t vn7HwQc3uCMRCioSaD4Ee8HPZ47PEkULKjFaBqVRSdvtJwK3Xiya/0LbqSTa0+OTGrNLfL1t+Ic CorzysVmLole6sZsFuAqD3S6I4K4g38P4Bss8SpHB16mmh3N X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230326_153315_825566_C8D2C8D1 X-CRM114-Status: GOOD ( 14.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Acked-by: Jernej Skrabec --- .../sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c index cd2e92ae2293..23d32e198aaa 100644 --- a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c +++ b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c @@ -804,15 +804,13 @@ static int sun8i_a83t_mipi_csi2_probe(struct platform_device *platform_dev) return ret; } -static int sun8i_a83t_mipi_csi2_remove(struct platform_device *platform_dev) +static void sun8i_a83t_mipi_csi2_remove(struct platform_device *platform_dev) { struct sun8i_a83t_mipi_csi2_device *csi2_dev = platform_get_drvdata(platform_dev); sun8i_a83t_mipi_csi2_bridge_cleanup(csi2_dev); sun8i_a83t_mipi_csi2_resources_cleanup(csi2_dev); - - return 0; } static const struct of_device_id sun8i_a83t_mipi_csi2_of_match[] = { @@ -823,7 +821,7 @@ MODULE_DEVICE_TABLE(of, sun8i_a83t_mipi_csi2_of_match); static struct platform_driver sun8i_a83t_mipi_csi2_platform_driver = { .probe = sun8i_a83t_mipi_csi2_probe, - .remove = sun8i_a83t_mipi_csi2_remove, + .remove_new = sun8i_a83t_mipi_csi2_remove, .driver = { .name = SUN8I_A83T_MIPI_CSI2_NAME, .of_match_table = of_match_ptr(sun8i_a83t_mipi_csi2_of_match),