From patchwork Sun Mar 26 14:32:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13188300 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 806D6C74A5B for ; Sun, 26 Mar 2023 14:37:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5j0dJT0p6p6uosS/iIfarJ3d32sEmaKg+OZaYMg0bbk=; b=NpF0lGYzLCW1RC Lcj4VY8XU6wMJtceFw/hxLlWyzfBS+jNlZasKf8qO2leAP8ZjZr1oLMiYvu6NlB0HR7rc2WYrxR6I 4gmEYqnXoP3HvkBp/6cifOzyNXaJb3W1uhd6HkECrrfdVlTtOLQGIcgWI+eOkR6kgfEx0mkqIgrqM 9K+R7dGVmuLycb1xAVAiDLaG5qBO7Xgj3UFP8uoJmO7E2vEwrqTs6QBqjUPY0Je3CyKSYQr8wpehO by6w/8U7YS4fFdSyInvqCET+kAmbhjvlm3sfsrEYcufMUWF2y6UqtMozCEvWTUjFle20JZHmrzNzI lApJ27/LL4o+ZQsL4p6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pgRTm-008bRY-1g; Sun, 26 Mar 2023 14:36:18 +0000 Received: from casper.infradead.org ([90.155.50.34]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pgRQi-008Yx9-2i for linux-arm-kernel@bombadil.infradead.org; Sun, 26 Mar 2023 14:33:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description; bh=EbGO3tAldoseB/EGtPHVXlz/l54To1jA0hIWnqTS5SI=; b=atEM7I8QrJ5kah7jbonqWbdhp0 37ypc0Syid01jCRYtFsx7uDbzxx6isIMsTF+wueLqBNAd4KzgekdX4nx85pU5Ht1ZfG6SDFktmR94 D3laiVO7q40aDdRP1elG53kJpqhPaBU0+4OJFEO98nsWQ1Npw3lHw4lg36BhlldyTh2V0aDSWVPJk RDMipSZMebrY+k+dNiti4SZpyMdOtlxnhpNWESnUqm0TFy/QUrtKyhcaqX940W+irYq3s8ijotYTa VbH96iXOpsTIBZ4hkaPP5XxRZicklP3/h34Yd4sI6JqzdJ/FuhC3SB7chiTV7x/CRn5UdJ/zTNAVC FjQ5pVjw==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by casper.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pgRQc-006aQr-DH for linux-arm-kernel@lists.infradead.org; Sun, 26 Mar 2023 14:33:07 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pgRQP-0000Gw-Iu; Sun, 26 Mar 2023 16:32:49 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pgRQN-006rgG-4Q; Sun, 26 Mar 2023 16:32:47 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pgRQM-0088Zy-BM; Sun, 26 Mar 2023 16:32:46 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Hyun Kwon , Laurent Pinchart , Mauro Carvalho Chehab , Michal Simek Cc: linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 096/117] media: xilinx-tpg: Convert to platform remove callback returning void Date: Sun, 26 Mar 2023 16:32:03 +0200 Message-Id: <20230326143224.572654-99-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230326143224.572654-1-u.kleine-koenig@pengutronix.de> References: <20230326143224.572654-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1821; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=xJns6D+KgLvHNTqGGeDmhK7PxGSbwNgfYYo8C86ngV8=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkIFcC6QJJuuLDmbbRbtEb2CCwae6rQuuT2RrzA Q3Runy9C/KJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZCBXAgAKCRCPgPtYfRL+ Tnv4B/4saKNNmKzJRbUFbLwE4QCi1fcCdP/2m6MeY6E2opUl6sPvm0VsgoW6XOgVm7hwM2E6Saw 9YGjXFt/Np0FsToWrOYEJvsQtjPwLcWA47/WEV5uGlljrxSi/KP1F8K7yhilqoKL/mNKEuovj4A kKhkL7DZUl19wQjRov4qHwzC3cmYPfCN5wEt79QQz1Sdqwp6oeCrsGbOOSyDCk+crsNmlq8OYDO 4H6vvMNGhqoUvqyuL6YsTWQyK2BkbMTa7vFvBoAFpQszRF03N51RUNsEB0OFdgkR7YS3etXsWAS J8Cx8RqO2kpjELOYp0dsqMb6tiXS4titQVgU4zGkcShc2G+d X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230326_153302_472357_9C43CD87 X-CRM114-Status: GOOD ( 13.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/media/platform/xilinx/xilinx-tpg.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/xilinx/xilinx-tpg.c b/drivers/media/platform/xilinx/xilinx-tpg.c index 0f2d5a0edf0c..80353ca44402 100644 --- a/drivers/media/platform/xilinx/xilinx-tpg.c +++ b/drivers/media/platform/xilinx/xilinx-tpg.c @@ -894,7 +894,7 @@ static int xtpg_probe(struct platform_device *pdev) return ret; } -static int xtpg_remove(struct platform_device *pdev) +static void xtpg_remove(struct platform_device *pdev) { struct xtpg_device *xtpg = platform_get_drvdata(pdev); struct v4l2_subdev *subdev = &xtpg->xvip.subdev; @@ -904,8 +904,6 @@ static int xtpg_remove(struct platform_device *pdev) media_entity_cleanup(&subdev->entity); xvip_cleanup_resources(&xtpg->xvip); - - return 0; } static SIMPLE_DEV_PM_OPS(xtpg_pm_ops, xtpg_pm_suspend, xtpg_pm_resume); @@ -923,7 +921,7 @@ static struct platform_driver xtpg_driver = { .of_match_table = xtpg_of_id_table, }, .probe = xtpg_probe, - .remove = xtpg_remove, + .remove_new = xtpg_remove, }; module_platform_driver(xtpg_driver);