| Message ID | 20230327-cleanup-pinctrl-binding-v1-1-b695e32e4f2e@baylibre.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Cleanup Mediatek pinctrl device tree binding | expand |
Il 28/03/23 15:06, Alexandre Mergnat ha scritto: > Deprecate mediatek,drive-strength-adv which shall not exist, that was an > unnecessary property that leaked upstream from downstream kernels and > there's no reason to use it. > > The generic property drive-strength-microamp should be used instead. > > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> > --- > .../devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml | 8 ++++++-- > .../devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml | 6 +++++- > 2 files changed, 11 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml > index c30cd0d010dd..b82a066b91ec 100644 > --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml Thanks for doing MT8183!!! > @@ -110,8 +110,13 @@ patternProperties: > drive-strength: ..snip.. > diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml > index 4b96884a1afc..347f533776ba 100644 > --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml > @@ -91,8 +91,13 @@ patternProperties: > > input-schmitt-disable: true > > + drive-strength-microamp: > + enum: [125, 250, 500, 1000] > + > mediatek,drive-strength-adv: > + deprecated: true In the case of MT8365, since there's *no* devicetree using this property, *at all*, I think you can even just entirely remove this block, as that should not be considered an ABI breakage in that case. Krzysztof, can you please confirm? Cheers! Angelo
On 28/03/2023 15:41, AngeloGioacchino Del Regno wrote: > Il 28/03/23 15:06, Alexandre Mergnat ha scritto: >> Deprecate mediatek,drive-strength-adv which shall not exist, that was an >> unnecessary property that leaked upstream from downstream kernels and >> there's no reason to use it. >> >> The generic property drive-strength-microamp should be used instead. >> >> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> >> --- >> .../devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml | 8 ++++++-- >> .../devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml | 6 +++++- >> 2 files changed, 11 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml >> index c30cd0d010dd..b82a066b91ec 100644 >> --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml >> +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml > > Thanks for doing MT8183!!! > >> @@ -110,8 +110,13 @@ patternProperties: >> drive-strength: > > ..snip.. > >> diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml >> index 4b96884a1afc..347f533776ba 100644 >> --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml >> +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml >> @@ -91,8 +91,13 @@ patternProperties: >> >> input-schmitt-disable: true >> >> + drive-strength-microamp: >> + enum: [125, 250, 500, 1000] >> + >> mediatek,drive-strength-adv: >> + deprecated: true > > In the case of MT8365, since there's *no* devicetree using this property, *at all*, > I think you can even just entirely remove this block, as that should not be > considered an ABI breakage in that case. > > Krzysztof, can you please confirm? If it is defined as ABI in a released kernel, then should be rather deprecated. Best regards, Krzysztof
On 28/03/2023 15:06, Alexandre Mergnat wrote: > Deprecate mediatek,drive-strength-adv which shall not exist, that was an > unnecessary property that leaked upstream from downstream kernels and > there's no reason to use it. > > The generic property drive-strength-microamp should be used instead. > > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> > --- > .../devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml | 8 ++++++-- > .../devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml | 6 +++++- > 2 files changed, 11 insertions(+), 3 deletions(-) > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Wed, Mar 29, 2023 at 09:58:57AM +0200, Krzysztof Kozlowski wrote: > On 28/03/2023 15:41, AngeloGioacchino Del Regno wrote: > > Il 28/03/23 15:06, Alexandre Mergnat ha scritto: > >> Deprecate mediatek,drive-strength-adv which shall not exist, that was an > >> unnecessary property that leaked upstream from downstream kernels and > >> there's no reason to use it. > >> > >> The generic property drive-strength-microamp should be used instead. > >> > >> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> > >> --- > >> .../devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml | 8 ++++++-- > >> .../devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml | 6 +++++- > >> 2 files changed, 11 insertions(+), 3 deletions(-) > >> > >> diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml > >> index c30cd0d010dd..b82a066b91ec 100644 > >> --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml > >> +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml > > > > Thanks for doing MT8183!!! > > > >> @@ -110,8 +110,13 @@ patternProperties: > >> drive-strength: > > > > ..snip.. > > > >> diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml > >> index 4b96884a1afc..347f533776ba 100644 > >> --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml > >> +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml > >> @@ -91,8 +91,13 @@ patternProperties: > >> > >> input-schmitt-disable: true > >> > >> + drive-strength-microamp: > >> + enum: [125, 250, 500, 1000] > >> + > >> mediatek,drive-strength-adv: > >> + deprecated: true > > > > In the case of MT8365, since there's *no* devicetree using this property, *at all*, > > I think you can even just entirely remove this block, as that should not be > > considered an ABI breakage in that case. > > > > Krzysztof, can you please confirm? > > If it is defined as ABI in a released kernel, then should be rather > deprecated. Yes, but if no one notices it's not an ABI. It's up to the platform maintainers really. I only care that the commits indicate they know what they are doing (usually not). Rob
diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml index c30cd0d010dd..b82a066b91ec 100644 --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml @@ -110,8 +110,13 @@ patternProperties: drive-strength: enum: [2, 4, 6, 8, 10, 12, 14, 16] + drive-strength-microamp: + enum: [125, 250, 500, 1000] + mediatek,drive-strength-adv: + deprecated: true description: | + DEPRECATED: Please use drive-strength-microamp instead. Describe the specific driving setup property. For I2C pins, the existing generic driving setup can only support 2/4/6/8/10/12/14/16mA driving. But in specific driving setup, they @@ -215,7 +220,7 @@ examples: pinmux = <PINMUX_GPIO48__FUNC_SCL5>, <PINMUX_GPIO49__FUNC_SDA5>; mediatek,pull-up-adv = <3>; - mediatek,drive-strength-adv = <7>; + drive-strength-microamp = <1000>; }; }; @@ -224,7 +229,6 @@ examples: pinmux = <PINMUX_GPIO50__FUNC_SCL3>, <PINMUX_GPIO51__FUNC_SDA3>; mediatek,pull-down-adv = <2>; - mediatek,drive-strength-adv = <4>; }; }; }; diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml index 4b96884a1afc..347f533776ba 100644 --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml @@ -91,8 +91,13 @@ patternProperties: input-schmitt-disable: true + drive-strength-microamp: + enum: [125, 250, 500, 1000] + mediatek,drive-strength-adv: + deprecated: true description: | + DEPRECATED: Please use drive-strength-microamp instead. Describe the specific driving setup property. For I2C pins, the existing generic driving setup can only support 2/4/6/8/10/12/14/16mA driving. But in specific driving setup, they @@ -189,7 +194,6 @@ examples: pins { pinmux = <MT8365_PIN_59_SDA1__FUNC_SDA1_0>, <MT8365_PIN_60_SCL1__FUNC_SCL1_0>; mediatek,pull-up-adv = <3>; - mediatek,drive-strength-adv = <00>; bias-pull-up; }; };
Deprecate mediatek,drive-strength-adv which shall not exist, that was an unnecessary property that leaked upstream from downstream kernels and there's no reason to use it. The generic property drive-strength-microamp should be used instead. Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> --- .../devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml | 8 ++++++-- .../devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml | 6 +++++- 2 files changed, 11 insertions(+), 3 deletions(-)