From patchwork Sat Apr 1 16:19:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13197154 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E95D4C76196 for ; Sat, 1 Apr 2023 16:39:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pK+Ydt1SBxKKANfKGvTYqdPWkhvobrGBnvSWDt6WquM=; b=yTjmRAvmewF4Gb Fq+LMrepltIPclXjDfq4cZ5bjks3F+kk0ZWeEZVpJDbcJAHSQnTzhXjcr0PgR7wQXCZztdNEHgn2U qJrTcufte9Tvx+rVlPmVEJpwA2rJ1EjVIOed+yg+xk0/BGqERK547LwqoeACeXKATm7F1XmuleHbG NbDQB/2eDXEBgPvXM9mplobl43D2qrGIY9x/apLtA4M8+8Lpvaxg/7YoL+xY6258RuQDo6l5O+J6G WTH937/M8Ov4fcGdYw+F3XdUvWZJuKgjNQzhQAnGrpWFaNeyQ9KJd05GqXYpB9ja8w9mVQplQIVpn uQ0rFIGdSEsUhvyZetfQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pieEz-00Awx1-2m; Sat, 01 Apr 2023 16:38:10 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pieEN-00AwRk-1B for linux-arm-kernel@bombadil.infradead.org; Sat, 01 Apr 2023 16:37:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description; bh=82OGQX4FQHKXC/0gh6rSGyigQm/ixNj7n6g/PqGRZFc=; b=FW8SRx2YgYwEwcdjr3DDQdGLlT 6nV2VmDOTlW7ATB6ddzzJyVa/w/e2EpxxL2Bc5xElSvPCH92XXO0G6GqY9o4+3eLPG/LfiEmSDYmi kewoSorsJhqVjmenlS1qtBWV+gGUxdK6IhyqS+gmNvRAFoARnIhK1Poxk1Cqg9Dn0mwtNE01CXXSn TSaEwsHLsZc/wT14E3mqEUVP7Y5LMVsHIFzIWlqFyfQp81XYcbSFtalNCf/iZnnRTsu2efBz1pMWn 8GRsrPFUa/y3PGBViAnGZN58Po6OssrByJob+vcy3i6EuU1ClWTv+OzuSUpofFWU4VrxUs4HkV7j0 WXmcdHPA==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by casper.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pidxS-00CYOW-TF for linux-arm-kernel@lists.infradead.org; Sat, 01 Apr 2023 16:20:08 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxI-0008JG-Jd; Sat, 01 Apr 2023 18:19:52 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxH-008GRD-L5; Sat, 01 Apr 2023 18:19:51 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxG-009kgS-QD; Sat, 01 Apr 2023 18:19:50 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Vignesh Raghavendra , Vladimir Zapolskiy , Geert Uytterhoeven , Dmitry Torokhov Cc: Richard Weinberger , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 22/49] mtd: rawnand: lpc32xx_mlc: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:11 +0200 Message-Id: <20230401161938.2503204-23-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1879; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=TWFefpDxHWfkuMQsZUU/YYnQA1Ncz9g/YAZzkYUP7N4=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFkd8KJ2FC0m02q7GglRFellH7wX4OKY4WkZK fheCZgA7i+JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZHQAKCRCPgPtYfRL+ TvECCACow5b8t+Hq5gDTf6e+tnBdhSOgrsnyqDBhEiYEqa77h150Sgy1x+wfRmsH5/b88M4R4WD 8qKRyef2PAKE55ATKvBO68X0fZqz5iO85iunO+VG58sH+4wzGbUjrWcmrVENgZgWhPh55dDADA5 GJdr6qn9zRKR+b982z12byIVLj942NSZTVNwAlSNk2bHOE+gMJYR87UFWVze+MOxm9zqZYpECFX ROd4IiNuKolA0ytb9DVyK+t7Wl4rN2gzUgsavWjDRpcoI9z33qAlwPwwfaYKzc4zNexhTMWEhfQ h5XWkNg/OZ3N6f6vG+ofuD1Z3FiUEAy4KKvcjf9M0Xb5boak X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172003_042506_651EE7AB X-CRM114-Status: GOOD ( 13.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/raw/lpc32xx_mlc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/lpc32xx_mlc.c b/drivers/mtd/nand/raw/lpc32xx_mlc.c index ae7f6429a5f6..b3136ae6f4e9 100644 --- a/drivers/mtd/nand/raw/lpc32xx_mlc.c +++ b/drivers/mtd/nand/raw/lpc32xx_mlc.c @@ -827,7 +827,7 @@ static int lpc32xx_nand_probe(struct platform_device *pdev) /* * Remove NAND device */ -static int lpc32xx_nand_remove(struct platform_device *pdev) +static void lpc32xx_nand_remove(struct platform_device *pdev) { struct lpc32xx_nand_host *host = platform_get_drvdata(pdev); struct nand_chip *chip = &host->nand_chip; @@ -846,8 +846,6 @@ static int lpc32xx_nand_remove(struct platform_device *pdev) lpc32xx_wp_enable(host); gpiod_put(host->wp_gpio); - - return 0; } static int lpc32xx_nand_resume(struct platform_device *pdev) @@ -889,7 +887,7 @@ MODULE_DEVICE_TABLE(of, lpc32xx_nand_match); static struct platform_driver lpc32xx_nand_driver = { .probe = lpc32xx_nand_probe, - .remove = lpc32xx_nand_remove, + .remove_new = lpc32xx_nand_remove, .resume = pm_ptr(lpc32xx_nand_resume), .suspend = pm_ptr(lpc32xx_nand_suspend), .driver = {