| Message ID | 20230404080243.9613-3-stefan.wahren@chargebyte.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: dts: imx6ull: Add chargebyte Tarragon support | expand |
On 04/04/2023 10:02, Stefan Wahren wrote: > This adds a dedicated devicetree binding for the Maxim DS2482/DS2484 > I2C to 1-W bridges, which can be extended later for further features > (e.g. sleep mode control GPIO). Since one wire is a bus, child nodes > needs to be allowed here. > > Signed-off-by: Stefan Wahren <stefan.wahren@chargebyte.com> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Tue, Apr 04, 2023 at 10:02:39AM +0200, Stefan Wahren wrote: > This adds a dedicated devicetree binding for the Maxim DS2482/DS2484 > I2C to 1-W bridges, which can be extended later for further features > (e.g. sleep mode control GPIO). Since one wire is a bus, child nodes > needs to be allowed here. > > Signed-off-by: Stefan Wahren <stefan.wahren@chargebyte.com> > --- > .../devicetree/bindings/w1/maxim,ds2482.yaml | 44 +++++++++++++++++++ > 1 file changed, 44 insertions(+) > create mode 100644 Documentation/devicetree/bindings/w1/maxim,ds2482.yaml Reviewed-by: Rob Herring <robh@kernel.org>
Hi Greg, Am 04.04.23 um 15:39 schrieb Rob Herring: > On Tue, Apr 04, 2023 at 10:02:39AM +0200, Stefan Wahren wrote: >> This adds a dedicated devicetree binding for the Maxim DS2482/DS2484 >> I2C to 1-W bridges, which can be extended later for further features >> (e.g. sleep mode control GPIO). Since one wire is a bus, child nodes >> needs to be allowed here. >> >> Signed-off-by: Stefan Wahren <stefan.wahren@chargebyte.com> >> --- >> .../devicetree/bindings/w1/maxim,ds2482.yaml | 44 +++++++++++++++++++ >> 1 file changed, 44 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/w1/maxim,ds2482.yaml > > Reviewed-by: Rob Herring <robh@kernel.org> Shawn Guo applied all patches from this series [1] except of this one and patch 3, which probably should go via your 1-w tree? Unfortunately no feedback from Evgeniy so far. Should i resend these two patches for you? Best regards Stefan [1] - https://lore.kernel.org/linux-arm-kernel/20230404080243.9613-1-stefan.wahren@chargebyte.com/T/ > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Thu, Apr 06, 2023 at 11:53:28AM +0200, Stefan Wahren wrote: > Hi Greg, > > Am 04.04.23 um 15:39 schrieb Rob Herring: > > On Tue, Apr 04, 2023 at 10:02:39AM +0200, Stefan Wahren wrote: > > > This adds a dedicated devicetree binding for the Maxim DS2482/DS2484 > > > I2C to 1-W bridges, which can be extended later for further features > > > (e.g. sleep mode control GPIO). Since one wire is a bus, child nodes > > > needs to be allowed here. > > > > > > Signed-off-by: Stefan Wahren <stefan.wahren@chargebyte.com> > > > --- > > > .../devicetree/bindings/w1/maxim,ds2482.yaml | 44 +++++++++++++++++++ > > > 1 file changed, 44 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/w1/maxim,ds2482.yaml > > > > Reviewed-by: Rob Herring <robh@kernel.org> > > Shawn Guo applied all patches from this series [1] except of this one and > patch 3, which probably should go via your 1-w tree? > > Unfortunately no feedback from Evgeniy so far. Should i resend these two > patches for you? Please do. thanks, greg k-h
Stefan, Greg, hi On 06/04/2023 10:58, Greg Kroah-Hartman wrote: > On Thu, Apr 06, 2023 at 11:53:28AM +0200, Stefan Wahren wrote: >> Unfortunately no feedback from Evgeniy so far. Should i resend these two >> patches for you? > > Please do. Thank you for the patches Stefan, but I'm no longer a w1 maintainer, sorry I haven't updated the maintainers file, please send all w1 patches to Greg.
On 06/04/2023 13:47, Evgeniy Polyakov wrote: > Stefan, Greg, hi > > On 06/04/2023 10:58, Greg Kroah-Hartman wrote: >> On Thu, Apr 06, 2023 at 11:53:28AM +0200, Stefan Wahren wrote: >>> Unfortunately no feedback from Evgeniy so far. Should i resend these two >>> patches for you? >> >> Please do. > > Thank you for the patches Stefan, but I'm no longer a w1 maintainer, > sorry I haven't updated the maintainers file, please send all w1 patches > to Greg. Thanks Evgeniy. If the one-wire subsystem is orphaned, I can manage the patches to offload Greg a bit. Best regards, Krzysztof
On 06/04/2023 20:10, Krzysztof Kozlowski wrote: > On 06/04/2023 13:47, Evgeniy Polyakov wrote: >> Stefan, Greg, hi >> >> On 06/04/2023 10:58, Greg Kroah-Hartman wrote: >>> On Thu, Apr 06, 2023 at 11:53:28AM +0200, Stefan Wahren wrote: >>>> Unfortunately no feedback from Evgeniy so far. Should i resend these two >>>> patches for you? >>> >>> Please do. >> >> Thank you for the patches Stefan, but I'm no longer a w1 maintainer, >> sorry I haven't updated the maintainers file, please send all w1 patches >> to Greg. > > Thanks Evgeniy. > > If the one-wire subsystem is orphaned, I can manage the patches to > offload Greg a bit. There was not feedback on my proposal, which I am optimistically going to understand as "go ahead". :) I'll send a patch, assuming Evgeniy that you are not planning to maintain w1 anymore and a new maintainer would be useful. Best regards, Krzysztof
Hi Krzysztof On 15/04/2023 10:34, Krzysztof Kozlowski wrote: >>> Thank you for the patches Stefan, but I'm no longer a w1 maintainer, >>> sorry I haven't updated the maintainers file, please send all w1 patches >>> to Greg. >> >> Thanks Evgeniy. >> >> If the one-wire subsystem is orphaned, I can manage the patches to >> offload Greg a bit. > > There was not feedback on my proposal, which I am optimistically going > to understand as "go ahead". :) > > I'll send a patch, assuming Evgeniy that you are not planning to > maintain w1 anymore and a new maintainer would be useful. Greg has been managing all the w1 patches for last years and as far as I understand, in particular since I stepped out, I'm totally not against anyone picking up the queue from him or doing it the way I've been doing through his tree, but please discuss it with him and come up with the solution which works best, I have no word in it. Thank you.
diff --git a/Documentation/devicetree/bindings/w1/maxim,ds2482.yaml b/Documentation/devicetree/bindings/w1/maxim,ds2482.yaml new file mode 100644 index 000000000000..422becc6e1fa --- /dev/null +++ b/Documentation/devicetree/bindings/w1/maxim,ds2482.yaml @@ -0,0 +1,44 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/w1/maxim,ds2482.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Maxim One wire bus master controller + +maintainers: + - Stefan Wahren <stefan.wahren@chargebyte.com> + +description: | + I2C to 1-wire bridges + + https://www.analog.com/media/en/technical-documentation/data-sheets/ds2482-100.pdf + https://www.analog.com/media/en/technical-documentation/data-sheets/DS2482-800.pdf + https://www.analog.com/media/en/technical-documentation/data-sheets/DS2484.pdf + +properties: + compatible: + enum: + - maxim,ds2482 + - maxim,ds2484 + + reg: + maxItems: 1 + +required: + - compatible + - reg + +additionalProperties: + type: object + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + onewire@18 { + compatible = "maxim,ds2484"; + reg = <0x18>; + }; + };
This adds a dedicated devicetree binding for the Maxim DS2482/DS2484 I2C to 1-W bridges, which can be extended later for further features (e.g. sleep mode control GPIO). Since one wire is a bus, child nodes needs to be allowed here. Signed-off-by: Stefan Wahren <stefan.wahren@chargebyte.com> --- .../devicetree/bindings/w1/maxim,ds2482.yaml | 44 +++++++++++++++++++ 1 file changed, 44 insertions(+) create mode 100644 Documentation/devicetree/bindings/w1/maxim,ds2482.yaml