clk: mediatek: clk-mt7986-infracfg: delete the code related to 'base'

Commit Message

Xinyi Hou April 7, 2023, 8:37 a.m. UTC

In clk_mt7986_infracfg_probe(), 'base' is allocated but never used,
either not released on both success failure path.

Fix this by deleting 'base' and the code related to it.

Signed-off-by: Xinyi Hou <[e-mail]>
Reviewed-by: Dongliang Mu <[e-mail]>
---

 drivers/clk/mediatek/clk-mt7986-infracfg.c | 7 -------
 1 file changed, 7 deletions(-)

Comments

Alexandre Mergnat April 12, 2023, 11:50 a.m. UTC | #1

On 07/04/2023 10:37, Xinyi Hou wrote:
> In clk_mt7986_infracfg_probe(), 'base' is allocated but never used,
> either not released on both success failure path.
> 
> Fix this by deleting 'base' and the code related to it.
> 
> Signed-off-by: Xinyi Hou<[e-mail]>
> Reviewed-by: Dongliang Mu<[e-mail]>

Reviewed-by: Alexandre Mergnat <[e-mail]>

Patch

diff --git a/drivers/clk/mediatek/clk-mt7986-infracfg.c b/drivers/clk/mediatek/clk-mt7986-infracfg.c
index e80c92167c8f..76b32f3a16b2 100644
--- a/drivers/clk/mediatek/clk-mt7986-infracfg.c
+++ b/drivers/clk/mediatek/clk-mt7986-infracfg.c
@@ -174,16 +174,9 @@  static int clk_mt7986_infracfg_probe(struct platform_device *pdev)
 	struct clk_hw_onecell_data *clk_data;
 	struct device_node *node = pdev->dev.of_node;
 	int r;
-	void __iomem *base;
 	int nr = ARRAY_SIZE(infra_divs) + ARRAY_SIZE(infra_muxes) +
 		 ARRAY_SIZE(infra_clks);
 
-	base = of_iomap(node, 0);
-	if (!base) {
-		pr_err("%s(): ioremap failed\n", __func__);
-		return -ENOMEM;
-	}
-
 	clk_data = mtk_alloc_clk_data(nr);
 
 	if (!clk_data)