| Message ID | 20230407125008.42474-1-arinc.unal@arinc9.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/7] dt-bindings: net: dsa: mediatek,mt7530: correct brand name | expand |
Hi Arınç, On Fri, Apr 07, 2023 at 03:50:03PM +0300, arinc9.unal@gmail.com wrote: > From: Arınç ÜNAL <arinc.unal@arinc9.com> > > The brand name is MediaTek, change it to that. > > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> > Acked-by: Daniel Golle <daniel@makrotopia.org> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- It is good practice for series larger than 2 patches to create a cover letter, which gives the overview for the changes. Its contents gets used as the merge commit description when the series is accepted.
On 12.04.2023 02:57, Vladimir Oltean wrote: > Hi Arınç, > > On Fri, Apr 07, 2023 at 03:50:03PM +0300, arinc9.unal@gmail.com wrote: >> From: Arınç ÜNAL <arinc.unal@arinc9.com> >> >> The brand name is MediaTek, change it to that. >> >> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> >> Acked-by: Daniel Golle <daniel@makrotopia.org> >> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- > > It is good practice for series larger than 2 patches to create a cover > letter, which gives the overview for the changes. Its contents gets used > as the merge commit description when the series is accepted. Ok, will do on the next version. I'll also split the schema while at it. Arınç
On Wed, Apr 12, 2023 at 09:36:32AM +0300, Arınç ÜNAL wrote: > On 12.04.2023 02:57, Vladimir Oltean wrote: > > Hi Arınç, > > > > On Fri, Apr 07, 2023 at 03:50:03PM +0300, arinc9.unal@gmail.com wrote: > > > From: Arınç ÜNAL <arinc.unal@arinc9.com> > > > > > > The brand name is MediaTek, change it to that. > > > > > > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> > > > Acked-by: Daniel Golle <daniel@makrotopia.org> > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > --- > > > > It is good practice for series larger than 2 patches to create a cover > > letter, which gives the overview for the changes. Its contents gets used > > as the merge commit description when the series is accepted. > > Ok, will do on the next version. I'll also split the schema while at it. Ok. I wasn't sure if you and Krzysztof were in agreement about that, so this is why I didn't mention it. FWIW, it's also pretty unreviewable to me too.
On 12.04.2023 14:17, Vladimir Oltean wrote: > On Wed, Apr 12, 2023 at 09:36:32AM +0300, Arınç ÜNAL wrote: >> On 12.04.2023 02:57, Vladimir Oltean wrote: >>> Hi Arınç, >>> >>> On Fri, Apr 07, 2023 at 03:50:03PM +0300, arinc9.unal@gmail.com wrote: >>>> From: Arınç ÜNAL <arinc.unal@arinc9.com> >>>> >>>> The brand name is MediaTek, change it to that. >>>> >>>> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> >>>> Acked-by: Daniel Golle <daniel@makrotopia.org> >>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>> --- >>> >>> It is good practice for series larger than 2 patches to create a cover >>> letter, which gives the overview for the changes. Its contents gets used >>> as the merge commit description when the series is accepted. >> >> Ok, will do on the next version. I'll also split the schema while at it. > > Ok. I wasn't sure if you and Krzysztof were in agreement about that, so > this is why I didn't mention it. FWIW, it's also pretty unreviewable to > me too. I already agreed but was planning to do that later. I prefer to divide things into smaller parts so I improve progressively without being overwhelmed. My RFC series for this driver along with this series are growing which has become a bit overwhelming but I'll manage. Arınç
diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml index e532c6b795f4..6df995478275 100644 --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml @@ -4,7 +4,7 @@ $id: http://devicetree.org/schemas/net/dsa/mediatek,mt7530.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: Mediatek MT7530 and MT7531 Ethernet Switches +title: MediaTek MT7530 and MT7531 Ethernet Switches maintainers: - Arınç ÜNAL <arinc.unal@arinc9.com>