| Message ID | 20230412112739.160376-4-angelogioacchino.delregno@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | MediaTek Helio X10 - Mailbox, Display, MMC/SD/SDIO | expand |
On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: > Add a compatible string for the MediaTek Helio X10 MT6795 SoC, using > the same parameters as MT8183. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > .../display/mediatek/mediatek,dpi.yaml | 23 +++++++++++-------- > 1 file changed, 14 insertions(+), 9 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > index d976380801e3..803c00f26206 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > @@ -17,15 +17,20 @@ description: | > > properties: > compatible: > - enum: > - - mediatek,mt2701-dpi > - - mediatek,mt7623-dpi > - - mediatek,mt8173-dpi > - - mediatek,mt8183-dpi > - - mediatek,mt8186-dpi > - - mediatek,mt8188-dp-intf > - - mediatek,mt8192-dpi > - - mediatek,mt8195-dp-intf > + oneOf: > + - enum: > + - mediatek,mt2701-dpi > + - mediatek,mt7623-dpi > + - mediatek,mt8173-dpi > + - mediatek,mt8183-dpi > + - mediatek,mt8186-dpi > + - mediatek,mt8188-dp-intf > + - mediatek,mt8192-dpi > + - mediatek,mt8195-dp-intf > + - items: > + - enum: > + - mediatek,mt6795-dpi > + - const: mediatek,mt8183-dpi Shouldn't we declare both const: ?
On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: > Add a compatible string for the MediaTek Helio X10 MT6795 SoC, using > the same parameters as MT8183. > > Signed-off-by: AngeloGioacchino Del Regno<angelogioacchino.delregno@collabora.com> Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>
On Wed, 12 Apr 2023 13:27:15 +0200, AngeloGioacchino Del Regno wrote: > Add a compatible string for the MediaTek Helio X10 MT6795 SoC, using > the same parameters as MT8183. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > .../display/mediatek/mediatek,dpi.yaml | 23 +++++++++++-------- > 1 file changed, 14 insertions(+), 9 deletions(-) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230412112739.160376-4-angelogioacchino.delregno@collabora.com dpi@14014000: Additional properties are not allowed ('ports' was unexpected) arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dtb arch/arm/boot/dts/mt7623n-rfb-emmc.dtb dpi@14014000: compatible: 'oneOf' conditional failed, one must be fixed: arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dtb arch/arm/boot/dts/mt7623n-rfb-emmc.dtb dpi@14014000: 'port' is a required property arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dtb arch/arm/boot/dts/mt7623n-rfb-emmc.dtb dpi@1401d000: Additional properties are not allowed ('power-domains' was unexpected) arch/arm64/boot/dts/mediatek/mt8173-elm.dtb arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtb arch/arm64/boot/dts/mediatek/mt8173-elm-hana-rev7.dtb arch/arm64/boot/dts/mediatek/mt8173-evb.dtb dp-intf@1c015000: clock-names:0: 'pixel' was expected arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dtb arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dtb arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dtb arch/arm64/boot/dts/mediatek/mt8195-demo.dtb arch/arm64/boot/dts/mediatek/mt8195-evb.dtb dp-intf@1c015000: clock-names:1: 'engine' was expected arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dtb arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dtb arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dtb arch/arm64/boot/dts/mediatek/mt8195-demo.dtb arch/arm64/boot/dts/mediatek/mt8195-evb.dtb dp-intf@1c113000: Additional properties are not allowed ('power-domains' was unexpected) arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dtb arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dtb arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dtb arch/arm64/boot/dts/mediatek/mt8195-demo.dtb arch/arm64/boot/dts/mediatek/mt8195-evb.dtb dp-intf@1c113000: clock-names:0: 'pixel' was expected arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dtb arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dtb arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dtb arch/arm64/boot/dts/mediatek/mt8195-demo.dtb arch/arm64/boot/dts/mediatek/mt8195-evb.dtb dp-intf@1c113000: clock-names:1: 'engine' was expected arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dtb arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dtb arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dtb arch/arm64/boot/dts/mediatek/mt8195-demo.dtb arch/arm64/boot/dts/mediatek/mt8195-evb.dtb
On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: > Add a compatible string for the MediaTek Helio X10 MT6795 SoC, using > the same parameters as MT8183. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 12/04/2023 14:35, Matthias Brugger wrote: > > > On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: >> Add a compatible string for the MediaTek Helio X10 MT6795 SoC, using >> the same parameters as MT8183. >> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >> --- >> .../display/mediatek/mediatek,dpi.yaml | 23 +++++++++++-------- >> 1 file changed, 14 insertions(+), 9 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml >> index d976380801e3..803c00f26206 100644 >> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml >> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml >> @@ -17,15 +17,20 @@ description: | >> >> properties: >> compatible: >> - enum: >> - - mediatek,mt2701-dpi >> - - mediatek,mt7623-dpi >> - - mediatek,mt8173-dpi >> - - mediatek,mt8183-dpi >> - - mediatek,mt8186-dpi >> - - mediatek,mt8188-dp-intf >> - - mediatek,mt8192-dpi >> - - mediatek,mt8195-dp-intf >> + oneOf: >> + - enum: >> + - mediatek,mt2701-dpi >> + - mediatek,mt7623-dpi >> + - mediatek,mt8173-dpi >> + - mediatek,mt8183-dpi >> + - mediatek,mt8186-dpi >> + - mediatek,mt8188-dp-intf >> + - mediatek,mt8192-dpi >> + - mediatek,mt8195-dp-intf >> + - items: >> + - enum: >> + - mediatek,mt6795-dpi >> + - const: mediatek,mt8183-dpi > > Shouldn't we declare both const: ? I assume it is likely the enum will grow. If this is reasonably anticipated, keep enum. Best regards, Krzysztof
Hi Chun-Kuang Hu, Can you help to merge the missing DT-binding patches in this series? Thanks a lot, Matthias On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: > Add a compatible string for the MediaTek Helio X10 MT6795 SoC, using > the same parameters as MT8183. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > .../display/mediatek/mediatek,dpi.yaml | 23 +++++++++++-------- > 1 file changed, 14 insertions(+), 9 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > index d976380801e3..803c00f26206 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > @@ -17,15 +17,20 @@ description: | > > properties: > compatible: > - enum: > - - mediatek,mt2701-dpi > - - mediatek,mt7623-dpi > - - mediatek,mt8173-dpi > - - mediatek,mt8183-dpi > - - mediatek,mt8186-dpi > - - mediatek,mt8188-dp-intf > - - mediatek,mt8192-dpi > - - mediatek,mt8195-dp-intf > + oneOf: > + - enum: > + - mediatek,mt2701-dpi > + - mediatek,mt7623-dpi > + - mediatek,mt8173-dpi > + - mediatek,mt8183-dpi > + - mediatek,mt8186-dpi > + - mediatek,mt8188-dp-intf > + - mediatek,mt8192-dpi > + - mediatek,mt8195-dp-intf > + - items: > + - enum: > + - mediatek,mt6795-dpi > + - const: mediatek,mt8183-dpi > > reg: > maxItems: 1
Hi, Matthias: Matthias Brugger <matthias.bgg@gmail.com> 於 2023年5月29日 週一 下午10:07寫道： > > Hi Chun-Kuang Hu, > > Can you help to merge the missing DT-binding patches in this series? Apply display binding of this series to mediatek-drm-next [1]. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > > Thanks a lot, > Matthias > > On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: > > Add a compatible string for the MediaTek Helio X10 MT6795 SoC, using > > the same parameters as MT8183. > > > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > > --- > > .../display/mediatek/mediatek,dpi.yaml | 23 +++++++++++-------- > > 1 file changed, 14 insertions(+), 9 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > > index d976380801e3..803c00f26206 100644 > > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > > @@ -17,15 +17,20 @@ description: | > > > > properties: > > compatible: > > - enum: > > - - mediatek,mt2701-dpi > > - - mediatek,mt7623-dpi > > - - mediatek,mt8173-dpi > > - - mediatek,mt8183-dpi > > - - mediatek,mt8186-dpi > > - - mediatek,mt8188-dp-intf > > - - mediatek,mt8192-dpi > > - - mediatek,mt8195-dp-intf > > + oneOf: > > + - enum: > > + - mediatek,mt2701-dpi > > + - mediatek,mt7623-dpi > > + - mediatek,mt8173-dpi > > + - mediatek,mt8183-dpi > > + - mediatek,mt8186-dpi > > + - mediatek,mt8188-dp-intf > > + - mediatek,mt8192-dpi > > + - mediatek,mt8195-dp-intf > > + - items: > > + - enum: > > + - mediatek,mt6795-dpi > > + - const: mediatek,mt8183-dpi > > > > reg: > > maxItems: 1
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml index d976380801e3..803c00f26206 100644 --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml @@ -17,15 +17,20 @@ description: | properties: compatible: - enum: - - mediatek,mt2701-dpi - - mediatek,mt7623-dpi - - mediatek,mt8173-dpi - - mediatek,mt8183-dpi - - mediatek,mt8186-dpi - - mediatek,mt8188-dp-intf - - mediatek,mt8192-dpi - - mediatek,mt8195-dp-intf + oneOf: + - enum: + - mediatek,mt2701-dpi + - mediatek,mt7623-dpi + - mediatek,mt8173-dpi + - mediatek,mt8183-dpi + - mediatek,mt8186-dpi + - mediatek,mt8188-dp-intf + - mediatek,mt8192-dpi + - mediatek,mt8195-dp-intf + - items: + - enum: + - mediatek,mt6795-dpi + - const: mediatek,mt8183-dpi reg: maxItems: 1
Add a compatible string for the MediaTek Helio X10 MT6795 SoC, using the same parameters as MT8183. Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> --- .../display/mediatek/mediatek,dpi.yaml | 23 +++++++++++-------- 1 file changed, 14 insertions(+), 9 deletions(-)