diff mbox series

[v2,6/7] leds: leds-mt6323: Add support for MT6331 leds

Message ID 20230412153310.241046-7-angelogioacchino.delregno@collabora.com (mailing list archive)
State New, archived
Headers show
Series Add support for MT6331 and MT6332 LEDs | expand

Commit Message

AngeloGioacchino Del Regno April 12, 2023, 3:33 p.m. UTC
Add the register offsets for MT6331. The hwspec is the same as MT6323.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 drivers/leds/leds-mt6323.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

Comments

Pavel Machek April 13, 2023, 11:01 a.m. UTC | #1
Hi!

> Add the register offsets for MT6331. The hwspec is the same as MT6323.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
>  drivers/leds/leds-mt6323.c | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/drivers/leds/leds-mt6323.c b/drivers/leds/leds-mt6323.c
> index 182256ec1924..5d95dbd9a761 100644
> --- a/drivers/leds/leds-mt6323.c
> +++ b/drivers/leds/leds-mt6323.c
> @@ -531,6 +531,17 @@ static const struct mt6323_regs mt6323_registers = {
>  	.isink_en_ctrl = 0x356,
>  };
>  
> +static const struct mt6323_regs mt6331_registers = {
> +	.top_ckpdn = (const u16[]){ 0x138, 0x13e, 0x144 },
> +	.num_top_ckpdn = 3,
> +	.top_ckcon = (const u16[]){ 0x14c, 0x14a },
> +	.num_top_ckcon = 2,
> +	.isink_con = (const u16[]){ 0x40c, 0x40e, 0x410, 0x412, 0x414 },
> +	.num_isink_con = 5,
> +	.isink_max_regs = 4, /* ISINK[0..3] */
> +	.isink_en_ctrl = 0x43a,
> +};
> +
>  static const struct mt6323_hwspec mt6323_spec = {
>  	.max_period = 10000,
>  	.max_leds = 4,
> @@ -543,8 +554,14 @@ static const struct mt6323_data mt6323_pdata = {
>  	.spec = &mt6323_spec,
>  };
>  
> +static const struct mt6323_data mt6331_pdata = {
> +	.regs = &mt6331_registers,
> +	.spec = &mt6323_spec,
> +};
> +
>  static const struct of_device_id mt6323_led_dt_match[] = {
>  	{ .compatible = "mediatek,mt6323-led", .data = &mt6323_pdata},
> +	{ .compatible = "mediatek,mt6331-led", .data = &mt6331_pdata },
>  	{},

" " before } is missing.

But that's really detail.

Acked-by: Pavel Machek <pavel@ucw.cz>
								Pavel
Alexandre Mergnat April 13, 2023, 1:19 p.m. UTC | #2
On 12/04/2023 17:33, AngeloGioacchino Del Regno wrote:
> Add the register offsets for MT6331. The hwspec is the same as MT6323.
> 
> Signed-off-by: AngeloGioacchino Del Regno<angelogioacchino.delregno@collabora.com>

Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>

Regards,
Alexandre
diff mbox series

Patch

diff --git a/drivers/leds/leds-mt6323.c b/drivers/leds/leds-mt6323.c
index 182256ec1924..5d95dbd9a761 100644
--- a/drivers/leds/leds-mt6323.c
+++ b/drivers/leds/leds-mt6323.c
@@ -531,6 +531,17 @@  static const struct mt6323_regs mt6323_registers = {
 	.isink_en_ctrl = 0x356,
 };
 
+static const struct mt6323_regs mt6331_registers = {
+	.top_ckpdn = (const u16[]){ 0x138, 0x13e, 0x144 },
+	.num_top_ckpdn = 3,
+	.top_ckcon = (const u16[]){ 0x14c, 0x14a },
+	.num_top_ckcon = 2,
+	.isink_con = (const u16[]){ 0x40c, 0x40e, 0x410, 0x412, 0x414 },
+	.num_isink_con = 5,
+	.isink_max_regs = 4, /* ISINK[0..3] */
+	.isink_en_ctrl = 0x43a,
+};
+
 static const struct mt6323_hwspec mt6323_spec = {
 	.max_period = 10000,
 	.max_leds = 4,
@@ -543,8 +554,14 @@  static const struct mt6323_data mt6323_pdata = {
 	.spec = &mt6323_spec,
 };
 
+static const struct mt6323_data mt6331_pdata = {
+	.regs = &mt6331_registers,
+	.spec = &mt6323_spec,
+};
+
 static const struct of_device_id mt6323_led_dt_match[] = {
 	{ .compatible = "mediatek,mt6323-led", .data = &mt6323_pdata},
+	{ .compatible = "mediatek,mt6331-led", .data = &mt6331_pdata },
 	{},
 };
 MODULE_DEVICE_TABLE(of, mt6323_led_dt_match);