From patchwork Tue Apr 18 11:23:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Horman X-Patchwork-Id: 13215483 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8307AC77B75 for ; Tue, 18 Apr 2023 11:24:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Message-Id:MIME-Version:Subject: Date:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=GPAVLBznPaSN99cYHcahpmnVspOGYGEaKT3FXEEjRGc=; b=Pul2lNnI0bN9Gm IxbAVUBHwRHDOLMsk50DmOZjWtrv8VpZCbyIYctJKhs5Rp2SxNByOlVRAcXn05XLGGiLLtZnuUWkj IV5hPiIcyg92H06heW+Vx++BfzKw7SzRBYb6Ztsw4PDYI6rm7er3q0SsOayybmDBKXopM/Zbko2iy NC23/MUD0KXbmeiJAeh4L3OSv0ARB0+MFFiKX9YSJq/ae52Gwj59BndABORNc8h90cT/OhkOsXBhF Fr7jLN+wTtAzZMd3/9VvMmt11nKty6rfnrgP58sS3fYA9EDKC7y/U7+sHumTZ9iFLXD0I67FJpjCx 5niGt7OhuFOjuhgPGrAQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pojQm-001w1I-0i; Tue, 18 Apr 2023 11:23:28 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pojQj-001w0K-1S; Tue, 18 Apr 2023 11:23:26 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D54C962CD1; Tue, 18 Apr 2023 11:23:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83822C433D2; Tue, 18 Apr 2023 11:23:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681817004; bh=IWIhSHtXN5nXxkAIHYe//XXXEDzJDm71oCZAeg45FLQ=; h=From:Date:Subject:To:Cc:From; b=j2BOdExt1aEudYgnio6ULM3NMX1kKONLTQzO8lrN5aWTX8ZAeQb069WqlkhDkaL5T pwQeVc1ts2QGftGu3IuySEHNJ0IL+LnlSeCoeCgItn/swYpcpUlFlWwDOeSURv0mC8 3R2oqJE5g9FON1DHLyTEivkUnDst3+RhhG1rxR/0IQnu/lyL4xXXA86zH0x9SMPVLy ogOW89hjUKzkmdAjuIyA1n0V6vUurYiqkvivHVrXqsVanlQgiNfVOwW8MZ2sJoX9EM CBLqiIucydnPRYqO42+brshR7zZBYccdAZizU/KdzomcEE/EcQEjClMofkj/WcE5bY 9RQIt5TdMdd2Q== From: Simon Horman Date: Tue, 18 Apr 2023 13:23:11 +0200 Subject: [PATCH] staging: vchiq_arm: Make vchiq_platform_init() static MIME-Version: 1.0 Message-Id: <20230418-vchiq_platform_init-static-v1-1-3c38ba81bc66@kernel.org> X-B4-Tracking: v=1; b=H4sIAJ59PmQC/x2NQQqDMBAAvyJ77kLU0tp+pYhkk7VZSBNNohTEv 1d7HAZmNsichDM8qw0Sr5IlhgPqSwXG6fBmFHswNKpp1bXucDVO5mHyuowxfQYJUjAXXcSguj+ ovZG1HREcAdKZkZIOxp0JH432OC+88GmnxKN8/+tXv+8/9Kxym4oAAAA= To: Florian Fainelli , Greg Kroah-Hartman Cc: Broadcom internal kernel review list , Nathan Chancellor , Nick Desaulniers , Tom Rix , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, llvm@lists.linux.dev X-Mailer: b4 0.12.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230418_042325_548270_D549AA85 X-CRM114-Status: GOOD ( 12.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org vchiq_platform_init() is only used in this file so it can be static. clang-16 with W=1 reports: drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:465:5: error: no previous prototype for function 'vchiq_platform_init' [-Werror,-Wmissing-prototypes] int vchiq_platform_init(struct platform_device *pdev, struct vchiq_state *state) ^ drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:465:1: note: declare 'static' if the function is not intended to be used outside of this translation unit Signed-off-by: Simon Horman Reviewed-by: Nick Desaulniers Reviewed-by: Nathan Chancellor Signed-off-by: Arnd Bergmann Reviewed-by: Nick Desaulniers --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index 40dd62cf7399..59312b9f2058 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c @@ -462,7 +462,8 @@ free_pagelist(struct vchiq_instance *instance, struct vchiq_pagelist_info *pagel cleanup_pagelistinfo(instance, pagelistinfo); } -int vchiq_platform_init(struct platform_device *pdev, struct vchiq_state *state) +static int +vchiq_platform_init(struct platform_device *pdev, struct vchiq_state *state) { struct device *dev = &pdev->dev; struct vchiq_drvdata *drvdata = platform_get_drvdata(pdev);