| Message ID | 20230420105115.26838-1-nancy.lin@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/mediatek: fix uninitialized symbol | expand |
Il 20/04/23 12:51, Nancy.Lin ha scritto: > fix Smatch static checker warning > - uninitialized symbol comp_pdev in mtk_ddp_comp_init. > > Signed-off-by: Nancy.Lin <nancy.lin@mediatek.com> I agree with this commit, but please add a Fixes tag. Thanks, Angelo
Hi Angelo, On Thu, 2023-04-20 at 14:01 +0200, AngeloGioacchino Del Regno wrote: > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > > Il 20/04/23 12:51, Nancy.Lin ha scritto: > > fix Smatch static checker warning > > - uninitialized symbol comp_pdev in mtk_ddp_comp_init. > > > > Signed-off-by: Nancy.Lin <nancy.lin@mediatek.com> > > I agree with this commit, but please add a Fixes tag. > > Thanks, > Angelo Thanks for the review. I will resend it with Fixes tag. Regards, Nancy
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c index f114da4d36a9..e987ac4481bc 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c @@ -546,7 +546,7 @@ unsigned int mtk_drm_find_possible_crtc_by_comp(struct drm_device *drm, int mtk_ddp_comp_init(struct device_node *node, struct mtk_ddp_comp *comp, unsigned int comp_id) { - struct platform_device *comp_pdev; + struct platform_device *comp_pdev = NULL; enum mtk_ddp_comp_type type; struct mtk_ddp_comp_dev *priv; #if IS_REACHABLE(CONFIG_MTK_CMDQ) @@ -588,6 +588,9 @@ int mtk_ddp_comp_init(struct device_node *node, struct mtk_ddp_comp *comp, type == MTK_DSI) return 0; + if (!comp_pdev) + return -EPROBE_DEFER; + priv = devm_kzalloc(comp->dev, sizeof(*priv), GFP_KERNEL); if (!priv) return -ENOMEM;
fix Smatch static checker warning - uninitialized symbol comp_pdev in mtk_ddp_comp_init. Signed-off-by: Nancy.Lin <nancy.lin@mediatek.com> --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)