From patchwork Wed May 17 14:57:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Rogers X-Patchwork-Id: 13245160 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 239FFC77B7F for ; Wed, 17 May 2023 14:59:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:From:Subject:References:Mime-Version :Message-Id:In-Reply-To:Date:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Hog76526Lwbte+VdvmmeZamxP4qdtJkUZsotC9FrypE=; b=CeMMfp3yW4HO+s t+nc7kbwH23OLmhmFYxjkfqdFxRiMecNspLkDIs5i3mhz+Wmcf7BZEMOgcjdKPGbV26jsQngJzpQT 3L80lyqK+oqO/h7u3iiS+ZaorVroMrAoW4jvZXAj6va/+YcRFhHWgEBMHdG5EHFBwiX90ZZWGG3TU 4QsMC3IxT46M6bq9P/7O7Q9XU3Ev6mRkmTu2TU+CNL/jZHT0hKl5bOnHp4ZawlS42YkLpQlLQLRDg tlZ5VbpPElfaRd3EUXdzUW8h91jVy1CtDd2XJXwSSQ02qrIOsjxEFhHavvjPN7q+XPKqIh5elp//U /zhCondboE3D9V+B526Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pzIcn-00ADl8-2J; Wed, 17 May 2023 14:59:33 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pzIcg-00ADgY-17 for linux-arm-kernel@bombadil.infradead.org; Wed, 17 May 2023 14:59:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Type:To:From:Subject:References :Mime-Version:Message-Id:In-Reply-To:Date:Sender:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description; bh=KKqoIZuPWcw9eVnTQaV/Yxm1zaZil6JyotfyFlNgjRY=; b=lmeS5P/pz14eIpT3hWI2pmVyh1 mRfqwR8J9s+TvA0TH7o3ofXqyNVUpvkQvbJ2yxFP+39FvMR0uBaBoEixGCr1fxV1nwXJ8hHFl1nI6 I8LX2nXjVidO3C2QLV2gXgECqQR1C6endXlTYIgiXc5TNerdYfzDLmgIrjpY6CYdkI7YmbA78BTbn gmTLDyMLmbqbn9NnIsgrUOV3uFZ0KCGaB+8VHj65se+vPoxpHkD5YZcE5TLA78ZW/uMRPsXqJJ7im kwon0AIUFtRbnfu7c4c9XAPHz2TmgJT2hK/UNw3VXtymRlmR6l3JLQJw3GS4N/Ja0LooHCRnw44VR oZZqk8mA==; Received: from mail-yw1-x1149.google.com ([2607:f8b0:4864:20::1149]) by casper.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pzIcc-005Ald-W0 for linux-arm-kernel@lists.infradead.org; Wed, 17 May 2023 14:59:25 +0000 Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-5617da91670so8300147b3.0 for ; Wed, 17 May 2023 07:59:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1684335552; x=1686927552; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=KKqoIZuPWcw9eVnTQaV/Yxm1zaZil6JyotfyFlNgjRY=; b=TUFbOf6Vuteciew1H/sR8GFDllTU26HtBigIAOcm6RNblkHLxR1s1nxllnAGP+U6gw 6LetlTntu1sEwfssXYiaidtTavHjq/QXjXhiTXjaqX5+HFtni52UpqVqVCYFD9rfH0ql Uvn/PhwowUE7pFmwze16n/YTEweKs7XEDJA6u953lHrDicn48O1FsUAdfNbl6VnC0/rR QcLMnwEX+jxIZk8F+jP2Tw8gqmYmlQjhix0jgVbuDVGfgfBS8Nna8Hf0XBCkSpAWRcLn L83rAuTyA5bxFDqwXcXNwdPa8PulsCEhXZN4tctpP+DhfuWrANs/C15RHq64A1vEDFz/ 65kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684335552; x=1686927552; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KKqoIZuPWcw9eVnTQaV/Yxm1zaZil6JyotfyFlNgjRY=; b=QpZJAHXuRXsejJXh5H3nlQngeiwG0aqx5bBIZtfxHiQ509MNN1apcJeRvki3uL+YQ9 6N1jfq2BugYgdya+ce0SJNtQgrdOu6SSKekoE/xo2itp1ZldJqmO+7ePCCNcCeE8liRG Q6l4vowGytMIDVnVm7uLoNzRqgh7PilN98JhTh2Y8wgBz9m1Y5fc6wmv9z9x8y/bnOBt ZSapt84QyrxE0FkbNPMSWdHVeT2HBmUkUB4dyxV1bgz4UsvCPquQpfDR2iTrA8bvKr+v XzH+8BOo+dQr0lhd/zgVorKdnhqLFZN9HfvYcLwdBhymJGp/WHCV9HmIAcmJ9YKbsxKo Ufbg== X-Gm-Message-State: AC+VfDyxX9P1m5W+1P9dNggnl4SH/oLoExqgFl1srxFeQszkMjS+NNrZ f4IXcWYG8cCbA2dpaEsr+PldYIyT2iCs X-Google-Smtp-Source: ACHHUZ6N4HYRzQ3Z7NxRIwYgx8pZoI+LByxp+5DF2IYl0KvI6WWpkWjIJcQZotKUwdlgvE97nF4ub8C4g1CC X-Received: from irogers.svl.corp.google.com ([2620:15c:2d4:203:628b:7e78:d09b:39b]) (user=irogers job=sendgmr) by 2002:a81:4314:0:b0:561:8c16:2b66 with SMTP id q20-20020a814314000000b005618c162b66mr1686499ywa.4.1684335552162; Wed, 17 May 2023 07:59:12 -0700 (PDT) Date: Wed, 17 May 2023 07:57:56 -0700 In-Reply-To: <20230517145803.559429-1-irogers@google.com> Message-Id: <20230517145803.559429-17-irogers@google.com> Mime-Version: 1.0 References: <20230517145803.559429-1-irogers@google.com> X-Mailer: git-send-email 2.40.1.606.ga4b1b128d6-goog Subject: [PATCH v1 16/23] perf pmu: Remove perf_pmu__hybrid_pmus list From: Ian Rogers To: Suzuki K Poulose , Mike Leach , Leo Yan , John Garry , Will Deacon , James Clark , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Kajol Jain , Jing Zhang , Kan Liang , Zhengjun Xing , Ravi Bangoria , Madhavan Srinivasan , Athira Rajeev , Ming Wang , Huacai Chen , Sandipan Das , Dmitrii Dolgov <9erthalion6@gmail.com>, Sean Christopherson , Raul Silvera , Ali Saidi , Rob Herring , Thomas Richter , Kang Minchul , linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230517_155923_056883_80486AB7 X-CRM114-Status: GOOD ( 16.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Rather than iterate hybrid PMUs, inhererently Intel specific, iterate all PMUs checking whether they are core. To only get hybrid cores, first call perf_pmu__has_hybrid. Signed-off-by: Ian Rogers --- tools/perf/builtin-record.c | 1 - tools/perf/util/Build | 1 - tools/perf/util/pmu-hybrid.c | 39 ------------------------------ tools/perf/util/pmu-hybrid.h | 29 ---------------------- tools/perf/util/pmu.c | 7 ------ tools/perf/util/pmu.h | 2 -- tools/perf/util/print-events.c | 1 - tools/perf/util/python-ext-sources | 1 - 8 files changed, 81 deletions(-) delete mode 100644 tools/perf/util/pmu-hybrid.c delete mode 100644 tools/perf/util/pmu-hybrid.h diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c index 42135be760ab..aaf18e487757 100644 --- a/tools/perf/builtin-record.c +++ b/tools/perf/builtin-record.c @@ -49,7 +49,6 @@ #include "util/util.h" #include "util/pfm.h" #include "util/clockid.h" -#include "util/pmu-hybrid.h" #include "util/off_cpu.h" #include "util/bpf-filter.h" #include "asm/bug.h" diff --git a/tools/perf/util/Build b/tools/perf/util/Build index 21e4cdcba504..0d68be51a739 100644 --- a/tools/perf/util/Build +++ b/tools/perf/util/Build @@ -73,7 +73,6 @@ perf-y += pmu.o perf-y += pmus.o perf-y += pmu-flex.o perf-y += pmu-bison.o -perf-y += pmu-hybrid.o perf-y += svghelper.o perf-$(CONFIG_LIBTRACEEVENT) += trace-event-info.o perf-y += trace-event-scripting.o diff --git a/tools/perf/util/pmu-hybrid.c b/tools/perf/util/pmu-hybrid.c deleted file mode 100644 index 7fe943dd3217..000000000000 --- a/tools/perf/util/pmu-hybrid.c +++ /dev/null @@ -1,39 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0 -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include "fncache.h" -#include "pmu-hybrid.h" - -LIST_HEAD(perf_pmu__hybrid_pmus); - -static struct perf_pmu *perf_pmu__find_hybrid_pmu(const char *name) -{ - struct perf_pmu *pmu; - - if (!name) - return NULL; - - perf_pmu__for_each_hybrid_pmu(pmu) { - if (!strcmp(name, pmu->name)) - return pmu; - } - - return NULL; -} - -bool perf_pmu__is_hybrid(const char *name) -{ - return perf_pmu__find_hybrid_pmu(name) != NULL; -} diff --git a/tools/perf/util/pmu-hybrid.h b/tools/perf/util/pmu-hybrid.h deleted file mode 100644 index 8dbcae935020..000000000000 --- a/tools/perf/util/pmu-hybrid.h +++ /dev/null @@ -1,29 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0 */ -#ifndef __PMU_HYBRID_H -#define __PMU_HYBRID_H - -#include -#include -#include -#include -#include "pmu.h" - -extern struct list_head perf_pmu__hybrid_pmus; - -#define perf_pmu__for_each_hybrid_pmu(pmu) \ - list_for_each_entry(pmu, &perf_pmu__hybrid_pmus, hybrid_list) - -bool perf_pmu__is_hybrid(const char *name); - -static inline int perf_pmu__hybrid_pmu_num(void) -{ - struct perf_pmu *pmu; - int num = 0; - - perf_pmu__for_each_hybrid_pmu(pmu) - num++; - - return num; -} - -#endif /* __PMU_HYBRID_H */ diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c index acbf504c895a..bcf9d78a0003 100644 --- a/tools/perf/util/pmu.c +++ b/tools/perf/util/pmu.c @@ -32,7 +32,6 @@ #include "string2.h" #include "strbuf.h" #include "fncache.h" -#include "pmu-hybrid.h" #include "util/evsel_config.h" struct perf_pmu perf_pmu__fake; @@ -967,11 +966,6 @@ static struct perf_pmu *pmu_lookup(int dirfd, const char *lookup_name) list_splice(&aliases, &pmu->aliases); list_add_tail(&pmu->list, &pmus); - if (!strcmp(name, "cpu_core") || !strcmp(name, "cpu_atom")) - list_add_tail(&pmu->hybrid_list, &perf_pmu__hybrid_pmus); - else - INIT_LIST_HEAD(&pmu->hybrid_list); - pmu->default_config = perf_pmu__get_default_config(pmu); return pmu; @@ -2144,7 +2138,6 @@ void perf_pmu__destroy(void) list_for_each_entry_safe(pmu, tmp, &pmus, list) { list_del(&pmu->list); - list_del(&pmu->hybrid_list); perf_pmu__delete(pmu); } diff --git a/tools/perf/util/pmu.h b/tools/perf/util/pmu.h index 5f5de7c20ab6..cb51ad6e40fa 100644 --- a/tools/perf/util/pmu.h +++ b/tools/perf/util/pmu.h @@ -119,8 +119,6 @@ struct perf_pmu { struct list_head caps; /** @list: Element on pmus list in pmu.c. */ struct list_head list; - /** @hybrid_list: Element on perf_pmu__hybrid_pmus. */ - struct list_head hybrid_list; /** * @missing_features: Features to inhibit when events on this PMU are diff --git a/tools/perf/util/print-events.c b/tools/perf/util/print-events.c index 69492cbd6921..8d823bc906e6 100644 --- a/tools/perf/util/print-events.c +++ b/tools/perf/util/print-events.c @@ -26,7 +26,6 @@ #include "strlist.h" #include "tracepoint.h" #include "pfm.h" -#include "pmu-hybrid.h" #include "thread_map.h" #define MAX_NAME_LEN 100 diff --git a/tools/perf/util/python-ext-sources b/tools/perf/util/python-ext-sources index aa5156c2bcff..d4c9b4cd35ef 100644 --- a/tools/perf/util/python-ext-sources +++ b/tools/perf/util/python-ext-sources @@ -39,5 +39,4 @@ util/affinity.c util/rwsem.c util/hashmap.c util/perf_regs.c -util/pmu-hybrid.c util/fncache.c