From patchwork Wed May 17 23:02:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13245953 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DFC48C7EE2A for ; Wed, 17 May 2023 23:04:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EFZwreHFPR5WBf9T54nLpMdso8P1l5uQs4wIB+MZmdE=; b=t51ntNryF/Ys6r o/4fINO1FIaL/ev9TkK8W5yof0v6VxhaW7fo6ktApose9UrisCScNptmabSIulzL/NRHZnxS5fNyl lGMTEJmqvGY+pvvlBNDvg+CE3OtWNQxVGQdZ3zWpH4/s2keicW2LXKrZx/TrqCAjxy2+12KIv7vsN G+hQZD6GkID7mS//865uhUarJcYmWqI23Qv9xxZ4grbWnF7DXbCxpg15QiXwZ2pwQkSbQjmxlmc7H vNCQTAYjYzT5adjM+uNL0M1+2Ro33TFBzRLmMyHK4esUBxKUTKhsACTtfu3DlCRE5yrN4MQ1QOC6F 5JUC0oPse/vkQ0yynM2Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pzQBm-00BIpx-0V; Wed, 17 May 2023 23:04:10 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pzQAv-00BIFc-1B for linux-arm-kernel@bombadil.infradead.org; Wed, 17 May 2023 23:03:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=jncjnoHBvah0A3Q6496m0f+paqPYAEesfstycI9uWBQ=; b=eBl2ArwsedrJ/TSqOMTs6yEu76 EhgIL4ECDVV2e6sTsZ5gFr5kg3penbtKA6XOxWabMDKQUC1CrMPkVsbQrNF2NAzLtkley4N9O3nnH UeJlJYW4wibEPdubyTHQbkpjIIZFWMCfKz8i53JVO1GjR7YJ50tCMmKhLoLWtEb4f91IQ0EoBVqrW Hfe89OKgDGRIBLuaerh0pBc7S0n3pNPFXWAaKpkzQlKOYRxEH3cNTaIWucUxiQVIrG/GWvDjsc+II XzyhTcqB64zt5A9qEWz1YWj29QVgmESJ4HM1M9xBFeITRMIotd6T1LRieuSKgFPkkdAwKjsm4sCEB QulV36Nw==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pzQAo-00DMb7-1L for linux-arm-kernel@lists.infradead.org; Wed, 17 May 2023 23:03:15 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pzQAe-0008QG-Cf; Thu, 18 May 2023 01:03:00 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pzQAd-000wtu-4t; Thu, 18 May 2023 01:02:59 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pzQAc-005UaN-7R; Thu, 18 May 2023 01:02:58 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Alan Stern , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 80/97] usb: uhci-platform: Convert to platform remove callback returning void Date: Thu, 18 May 2023 01:02:22 +0200 Message-Id: <20230517230239.187727-81-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230517230239.187727-1-u.kleine-koenig@pengutronix.de> References: <20230517230239.187727-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2000; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=nq5llLRtqxTeiCKz9CiVLPyrxx2u5Rt3ymD7c+iJv54=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkZVzH302yAan/O1jyQoTcbj/aa5B1roPiaHX3+ IB0GO7woo2JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZGVcxwAKCRCPgPtYfRL+ Tq8BB/41xDNLk+plWzrriMOagRBjZhMeUi9C1CKrQ6/ohvJjferkSwQ2fThmFJ87iYTTo/FrT5F 2+mM7xTWcwL4/FmXpBzfIsV/LXqpqgJqIO+SOnxCxfwAIPaGebrfvMiO36+MzzDZoAoi2fgyIb4 LfO7ZpEIhcsusLrKqCb457APiqtou7TgcCH9HWOdYS2Jv+gKY/56AJgVqo2XnHIdNdgPSWebv3i kPtKIK8cBjcJRcQGGKK3nERCGVgKrPQZ6dMPbK3VLuvKqfqwTfECnf5zSX3vd5DzjEDdcGUf+rP W2Sn3JgrtJtucucbf0jvMHe5jhI28PXkmDEilAXlDWhLB5bj X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230518_000311_670883_F89913DC X-CRM114-Status: GOOD ( 17.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() is renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/usb/host/uhci-platform.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/host/uhci-platform.c b/drivers/usb/host/uhci-platform.c index b2049b47a08d..71ca532fc086 100644 --- a/drivers/usb/host/uhci-platform.c +++ b/drivers/usb/host/uhci-platform.c @@ -152,7 +152,7 @@ static int uhci_hcd_platform_probe(struct platform_device *pdev) return ret; } -static int uhci_hcd_platform_remove(struct platform_device *pdev) +static void uhci_hcd_platform_remove(struct platform_device *pdev) { struct usb_hcd *hcd = platform_get_drvdata(pdev); struct uhci_hcd *uhci = hcd_to_uhci(hcd); @@ -160,8 +160,6 @@ static int uhci_hcd_platform_remove(struct platform_device *pdev) clk_disable_unprepare(uhci->clk); usb_remove_hcd(hcd); usb_put_hcd(hcd); - - return 0; } /* Make sure the controller is quiescent and that we're not using it @@ -187,7 +185,7 @@ MODULE_DEVICE_TABLE(of, platform_uhci_ids); static struct platform_driver uhci_platform_driver = { .probe = uhci_hcd_platform_probe, - .remove = uhci_hcd_platform_remove, + .remove_new = uhci_hcd_platform_remove, .shutdown = uhci_hcd_platform_shutdown, .driver = { .name = "platform-uhci",