| Message ID | 20230522201404.660242-3-festevam@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v6,1/5] PCI: imx6: Use a more specific i.MX6SX GPR compatible | expand |
On Mon, 22 May 2023 17:14:02 -0300, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > The i.MX6SX General Purpose Registers is a set of register that serves > various different purposes and in particular, IOMUXC_GPR_GPR6, at > offset 0x18, can be used to configure the LDB block. > > Signed-off-by: Fabio Estevam <festevam@denx.de> > --- > Changes since v5: > - Dropped "fsl,imx6q-iomuxc-gpr" and "reg-names" (Marek). > > .../bindings/soc/imx/fsl,imx6sx-gpr.yaml | 82 +++++++++++++++++++ > 1 file changed, 82 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.example.dtb: syscon@20e4000: bridge@18:compatible:0: 'fsl,imx6sx-ldb' is not one of ['fsl,imx8mp-ldb', 'fsl,imx93-ldb'] From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230522201404.660242-3-festevam@gmail.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Mon, May 22, 2023 at 6:32 PM Rob Herring <robh@kernel.org> wrote: > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.example.dtb: syscon@20e4000: bridge@18:compatible:0: 'fsl,imx6sx-ldb' is not one of ['fsl,imx8mp-ldb', 'fsl,imx93-ldb'] > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.yaml Same comment as in 2/5 applies here too: Dependency: This depends on bd60d98a11da ("dt-bindings: display: bridge: ldb: Adjust imx6sx entries"), which is available on linux-next. I missed adding such a comment here.
On Mon, May 22, 2023 at 05:14:02PM -0300, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > The i.MX6SX General Purpose Registers is a set of register that serves > various different purposes and in particular, IOMUXC_GPR_GPR6, at > offset 0x18, can be used to configure the LDB block. > > Signed-off-by: Fabio Estevam <festevam@denx.de> > --- > Changes since v5: > - Dropped "fsl,imx6q-iomuxc-gpr" and "reg-names" (Marek). Please, especially when sending more than one version in a day, keep the changelogs from all of the versions in here. What you have seems grand, Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor.
On 5/22/23 22:14, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > The i.MX6SX General Purpose Registers is a set of register that serves > various different purposes and in particular, IOMUXC_GPR_GPR6, at > offset 0x18, can be used to configure the LDB block. > > Signed-off-by: Fabio Estevam <festevam@denx.de> Reviewed-by: Marek Vasut <marex@denx.de>
On Mon, May 22, 2023 at 06:53:10PM -0300, Fabio Estevam wrote: > On Mon, May 22, 2023 at 6:32 PM Rob Herring <robh@kernel.org> wrote: > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.example.dtb: syscon@20e4000: bridge@18:compatible:0: 'fsl,imx6sx-ldb' is not one of ['fsl,imx8mp-ldb', 'fsl,imx93-ldb'] > > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.yaml > > Same comment as in 2/5 applies here too: > > Dependency: This depends on bd60d98a11da ("dt-bindings: display: > bridge: ldb: Adjust imx6sx entries"), > which is available on linux-next. No such commit hash nor is Documentation/bindings/display/bridge/fsl,ldb.yaml a file in next. Rob
On Wed, Jun 7, 2023 at 5:31 PM Rob Herring <robh@kernel.org> wrote: > No such commit hash nor is > Documentation/bindings/display/bridge/fsl,ldb.yaml a file in next. Correct has in linux-next is f85f2ce57783913a23f21b9d3d03a27357c07c3a: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20230607&id=f85f2ce57783913a23f21b9d3d03a27357c07c3a
diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.yaml new file mode 100644 index 000000000000..b9752b4c45ab --- /dev/null +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.yaml @@ -0,0 +1,82 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/soc/imx/fsl,imx6sx-gpr.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NXP i.MX6SX General Purpose Register + +maintainers: + - Fabio Estevam <festevam@denx.de> + +description: + The i.MX6SX General Purpose Registers is a set of register that serves + for various purposes and in particular, IOMUXC_GPR_GPR6, at offset 0x18, + can be used to configure the LDB block. + +properties: + compatible: + items: + - const: fsl,imx6sx-iomuxc-gpr + - const: syscon + + reg: + maxItems: 1 + + '#address-cells': + const: 1 + + '#size-cells': + const: 1 + + bridge@18: + type: object + $ref: /schemas/display/bridge/fsl,ldb.yaml# + unevaluatedProperties: false + +required: + - compatible + - reg + - '#address-cells' + - '#size-cells' + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/imx6sx-clock.h> + + syscon@20e4000 { + compatible = "fsl,imx6sx-iomuxc-gpr", "syscon"; + reg = <0x020e4000 0x4000>; + #address-cells = <1>; + #size-cells = <1>; + + bridge@18 { + compatible = "fsl,imx6sx-ldb"; + reg = <0x18 0x4>; + clocks = <&clks IMX6SX_CLK_LDB_DI0>; + clock-names = "ldb"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + + ldb_from_lcdif1: endpoint { + remote-endpoint = <&lcdif1_to_ldb>; + }; + }; + + port@1 { + reg = <1>; + + ldb_lvds_ch0: endpoint { + }; + }; + }; + }; + }; +...