From patchwork Wed May 24 22:18:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Rogers X-Patchwork-Id: 13254576 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4BED0C77B73 for ; Wed, 24 May 2023 22:41:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:From:Subject:References:Mime-Version :Message-Id:In-Reply-To:Date:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vqqKIpANZGq04bXEliqAB27OAYGUn5uo5EypnectLls=; b=Xp01qa92oRhiqD lJbE0kkPkuF16lP1UcoC/koVOaT20SUUvlrB7LRhWgLw9bRFjTUWfcNNtMmTCLUWhapClApYzMZLs Y0rhXAFe4q36FC9SmuGi+cR78HQY9oh9Nni1V+1N3CEn7jxfDaiI+QGDjndRa8/pQDhsBaukvKLlv QF0+W9hblVjhWDsx7GRp5z7Itk8tlOy+K8HBvVQmGd44D/sCKY8Hj8jCxDvBmwYcUWUt3KiTRSL8P GnnSqcSaObF22AKJ/GCL/pFfdUfjhvv6jgSPA9R3ZkyY4eJk8fN6zTFkSIUKSvI7REIgsqyOnCvMh hXUnFjMAzW7puclcsBxA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q1xAc-00EpYU-1w; Wed, 24 May 2023 22:41:26 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q1xAM-00EpNQ-1L for linux-arm-kernel@bombadil.infradead.org; Wed, 24 May 2023 22:41:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:To:From:Subject: References:Mime-Version:Message-Id:In-Reply-To:Date:Sender:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description; bh=02rUQOyiNwiIsyzOJl6kmDGqZDjZZQRLfOwGjV/VqPE=; b=P2RDeBS5YD/GXJJE2N0l1nhk3c AH6rTrktf5VB5NQXkFFJ0iq4IX1vVLawxSeDxU2dxGpWJqtCeE+nN4QdnB67Nf6uUFs2PwKLD8JSs QSCN8CFlv7vD0XvfSGIMYm6gp+m0VgqtagGkQ8zaJ3NgUKALzaYeavDyK1iDB0YxD6xD1gOGo8tQc 67Em5DleRkEUdXbs4zD1g8LIfk6+PfF5bpD/fK0o0eeXx7G4hlSk7sa7Nd3CzrthDRurq0ZKHnXse GgmNfZfKN2PMrizeodDjuZRKp9eXTMZ42InHPQwaAnmmbP/NsCnmc6uRz/MS53oOUvfCPDjr8IV5L ST9npDIA==; Received: from mail-yw1-x1149.google.com ([2607:f8b0:4864:20::1149]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q1wp0-0056co-0i for linux-arm-kernel@lists.infradead.org; Wed, 24 May 2023 22:19:08 +0000 Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-5653c160973so29004597b3.3 for ; Wed, 24 May 2023 15:19:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1684966740; x=1687558740; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=02rUQOyiNwiIsyzOJl6kmDGqZDjZZQRLfOwGjV/VqPE=; b=6nKoJ2ZO2zIHMG8Vdhftw3G8IlB6fVDXK39qsnSEPChSilm0wJ/DBoEf/QAb9CKCtT sfl6tJ20fNMBLh97PdjBYAb4xwqrGbsF0B0qpOXvzMqb/SbfEy09hJ36UhQFCY2+3EkZ Ecs+YMXsSgSVwlenuoOLTusuDp6eMpj4MthxKqw7ozC/oX/4yiAau6Ja80T5wm+YIZph wg2k7TOddlTZGJ5APBshhaqD7+LEbnxMoJV6jtZYQq0CsMy27uPahpzu5IDpGWSkBCKC hX5nos7aAoj3UzTj18VQxbOd1qzYBmweEpaWI1d5IvW0Fz2DhWgg+2qTJc+zCcK6Z6cc uBhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684966740; x=1687558740; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=02rUQOyiNwiIsyzOJl6kmDGqZDjZZQRLfOwGjV/VqPE=; b=UVjN0Zl9yqJnE1j0T0EMdNb0VfNyNanxTiH5jkgIL7Blr/PLw99z20vd+wtvfO0vee 8lK9BC9jxY2JpA4Z3Ob2LJmwETn8F1o+UXaaICuwEoRpsMO/fIXcDRWiWUZhQez942UM 7A+4WhTOgUiLCwy3i9EFS6S/x9/8vcOdAIcz9SAYmvaScYtHnRwaGnwRnxGK1gWVW/6V OXVXQMWX39aNDAFPdggT+hGEanBJfVyyYHzWprWnVi5rX8DNxJQ0wkY9yfAcIkhoD+Vc lTgne/uNGKfTgwIDiFPXEOjlqmb4wTGdCaz6I/WcE2LYn2IDYaxvMDiUyDa6QI/BNKya FITA== X-Gm-Message-State: AC+VfDyPI6XL2oQyGylIYy0I6Zz5ei4Dhd/Er4ofat3XZ3i5BUnJntm5 WYYW6YvwYfGiaWfsOwKuWpMszqtk8dsK X-Google-Smtp-Source: ACHHUZ4T7vcSgycY4rtVGxUs6e/PZeDHYPYD8NwHQcrQfDN3dFzRusqoyw6Y03vhVSWmL2KloRvoUXcR1GS5 X-Received: from irogers.svl.corp.google.com ([2620:15c:2d4:203:7aa7:3d2d:76ae:8e96]) (user=irogers job=sendgmr) by 2002:a81:ad4d:0:b0:552:d924:a304 with SMTP id l13-20020a81ad4d000000b00552d924a304mr11478114ywk.4.1684966740240; Wed, 24 May 2023 15:19:00 -0700 (PDT) Date: Wed, 24 May 2023 15:18:07 -0700 In-Reply-To: <20230524221831.1741381-1-irogers@google.com> Message-Id: <20230524221831.1741381-12-irogers@google.com> Mime-Version: 1.0 References: <20230524221831.1741381-1-irogers@google.com> X-Mailer: git-send-email 2.40.1.698.g37aff9b760-goog Subject: [PATCH v3 11/35] perf target: Remove unused hybrid value From: Ian Rogers To: Suzuki K Poulose , Mike Leach , Leo Yan , John Garry , Will Deacon , James Clark , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Kajol Jain , Jing Zhang , Kan Liang , Zhengjun Xing , Ravi Bangoria , Madhavan Srinivasan , Athira Rajeev , Ming Wang , Huacai Chen , Sandipan Das , Dmitrii Dolgov <9erthalion6@gmail.com>, Sean Christopherson , Ali Saidi , Rob Herring , Thomas Richter , Kang Minchul , linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230524_231907_035366_EF3DF938 X-CRM114-Status: GOOD ( 13.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Previously this was used to modify CPU map propagation, but it is now unnecessary as map propagation ensure core PMUs only have valid PMUs in the CPU map from user requested CPUs. Signed-off-by: Ian Rogers --- tools/perf/builtin-record.c | 2 -- tools/perf/builtin-stat.c | 1 - tools/perf/util/target.h | 1 - 3 files changed, 4 deletions(-) diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c index ec0f2d5f189f..d152ab04a209 100644 --- a/tools/perf/builtin-record.c +++ b/tools/perf/builtin-record.c @@ -4204,8 +4204,6 @@ int cmd_record(int argc, const char **argv) goto out; } - rec->opts.target.hybrid = perf_pmu__has_hybrid(); - if (callchain_param.enabled && callchain_param.record_mode == CALLCHAIN_FP) arch__add_leaf_frame_record_opts(&rec->opts); diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c index bc45cee3f77c..c70cb0990661 100644 --- a/tools/perf/builtin-stat.c +++ b/tools/perf/builtin-stat.c @@ -2467,7 +2467,6 @@ int cmd_stat(int argc, const char **argv) goto out; } - target.hybrid = perf_pmu__has_hybrid(); if (evlist__create_maps(evsel_list, &target) < 0) { if (target__has_task(&target)) { pr_err("Problems finding threads of monitor\n"); diff --git a/tools/perf/util/target.h b/tools/perf/util/target.h index 880f1af7f6ad..d582cae8e105 100644 --- a/tools/perf/util/target.h +++ b/tools/perf/util/target.h @@ -17,7 +17,6 @@ struct target { bool default_per_cpu; bool per_thread; bool use_bpf; - bool hybrid; int initial_delay; const char *attr_map; };