From patchwork Fri May 26 21:53:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Rogers X-Patchwork-Id: 13257404 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6F14C77B7C for ; Fri, 26 May 2023 22:41:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:From:Subject:References:Mime-Version :Message-Id:In-Reply-To:Date:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BpERbglRCXORPCiUsWu3uYGvgwj+SFdUxbRyruYavv8=; b=cU+2MMHb6B/89n njKhSamWdTvRKBsJ3ThR5vWLq0seRnHEIY3UL7d0vCKzAgkxGrW++9jb2pTCO4DPhrS7EEAYsv+LU i7iaroFO8Q/CQwx0EF/o+oXPCp3NPMczUukdXHscY+FtcU/0qbPiY8AcJnqRZPbTMM01RyONp3fvX wgcJaCBNSH0+CdfOObzoFM5Bm7zNAN5lZbAGqAPlbFGhoB+3krsjGM8HaRgs3xHO7h6auDB9d1YeL xueFq1/ZdG78V3xwA+4yv0tL67NKOxtL+afgusCdReMVD3qaVSAkIlTCEL//eXvmDMqLPZw5bcJNz W6pYVMx9uRuOK3eeltZw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q2g7C-004A7E-02; Fri, 26 May 2023 22:40:54 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q2g6p-0049uz-0z for linux-arm-kernel@bombadil.infradead.org; Fri, 26 May 2023 22:40:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:To:From:Subject: References:Mime-Version:Message-Id:In-Reply-To:Date:Sender:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4G044dwOBhR5m2jaMfIZVfXdRdn6jhcUb1KB/kVg+Hc=; b=mfI1ek2UQPm49yKbFFASzMlcfj +ZseZR7mMpoKt8AVb8U196Le5lsFu1WoXi51Z5hZqNl9TY4/QdkC1xj2AWMTIokEt9dSMoRt+mwFc TWP9p81o/xH3xlcId0kfwXCuvDlo96QsC2FMFoOkj2k8lGFGjNMDMB7mf0aGkEUG/HYOZsQvFrUKD AWtZBzCDnsFCcXPG3XQ1a9sjfOBtYdIfe/bGQjsLagze4Ro0lD4jnBe7XLOAv7ZMusNMIkECoclzh R6JCLHJvh8s8gKRT5DPBtdAD+iIBuydcMUIDn8h/LGH/o8kD61lfeyqemqAOMJE/RPjgHGtWvgtor ECdHluLw==; Received: from mail-yw1-x1149.google.com ([2607:f8b0:4864:20::1149]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q2fOS-007ipb-10 for linux-arm-kernel@lists.infradead.org; Fri, 26 May 2023 21:54:42 +0000 Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-5654c7f991bso30764957b3.3 for ; Fri, 26 May 2023 14:54:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1685138079; x=1687730079; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=4G044dwOBhR5m2jaMfIZVfXdRdn6jhcUb1KB/kVg+Hc=; b=xFmXSnutuvwQaRPV6MvNc57aHCMlqOrcBz+anlNUSEj3MwpOSghgrADN0poHTOpjvl hWWbB5YXJ8lmFqKU7VsZjKZ62D72heYstI9VI9J25vvwCODF1sC4jRL61fQn6D0Y9SdI /SaYfb2vwVwzFCJEPnO/JJDb5X3ENTIE1xam1KOApN01araedqO6Pf1o5FGwkrY86+PG D/eVaI0/Jmgwd8/570KnC/O9pEaEQ8us4rny5IhdRtFT6pmhd85Z9VZ9xcT11ZxFSMmJ EPBnSWVA6pr+ZMJ9rccFJKeU2UaNcLpnY498nB2pHVnEA/bdSWjQBiiz3oIaJzz0uvgV 4Eeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685138079; x=1687730079; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4G044dwOBhR5m2jaMfIZVfXdRdn6jhcUb1KB/kVg+Hc=; b=GQXYG4TuefCk8mFf7bpUlsNcGrz7r6uz9k/M+hb0q5+6FJQ/kdr+Cyj+Akbvch8Nm8 FuX+ttjmiSU8lq+R8dmOjIcnklXI+yMb4bW0g2U6zjTsguxGXx9vg0qGJ/9LKevOk7DH qlA54uNtA9V2GMa7YXPBOjYUAFFlh7n5ciOIrGhGVeIwdPssqDWNcwjtMBa3/InmJp0R Q2SI/ywM33RG/PqxW/DrgXFeesehxRlaEHxJWuIGJRPWRfDDtik19npuYxl8GwOXmUFU kh/SrKaYSrIEB+Eben+PNqpYb5+f/0JH0PB25vkAkH+2VpvzfONct3s0MaIwUO0+DEoJ hM4w== X-Gm-Message-State: AC+VfDxhw3oiAxsdS6aeibgw276FKgMmSlWjioIKus0+b5mTKmpIwNdn xCeojoRyzPzAqo4Q731BqtzU1l/rIdt4 X-Google-Smtp-Source: ACHHUZ5uHH81uEsfWXLMPgmeDcR/Pi44wMN/4hfHAU+pTAxpvx8n7c1uH67wCMUMU0MOfYOiju2EHAJuJsN6 X-Received: from irogers.svl.corp.google.com ([2620:15c:2d4:203:3b4e:312c:644:a642]) (user=irogers job=sendgmr) by 2002:a81:ae15:0:b0:55a:1488:b479 with SMTP id m21-20020a81ae15000000b0055a1488b479mr1842134ywh.1.1685138079209; Fri, 26 May 2023 14:54:39 -0700 (PDT) Date: Fri, 26 May 2023 14:53:46 -0700 In-Reply-To: <20230526215410.2435674-1-irogers@google.com> Message-Id: <20230526215410.2435674-12-irogers@google.com> Mime-Version: 1.0 References: <20230526215410.2435674-1-irogers@google.com> X-Mailer: git-send-email 2.41.0.rc0.172.g3f132b7071-goog Subject: [PATCH v4 11/35] perf target: Remove unused hybrid value From: Ian Rogers To: Suzuki K Poulose , Mike Leach , Leo Yan , John Garry , Will Deacon , James Clark , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Kajol Jain , Jing Zhang , Kan Liang , Zhengjun Xing , Ravi Bangoria , Madhavan Srinivasan , Athira Rajeev , Ming Wang , Huacai Chen , Sandipan Das , Dmitrii Dolgov <9erthalion6@gmail.com>, Sean Christopherson , Ali Saidi , Rob Herring , Thomas Richter , Kang Minchul , linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230526_225440_398576_EADFD326 X-CRM114-Status: GOOD ( 12.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Previously this was used to modify CPU map propagation, but it is now unnecessary as map propagation ensure core PMUs only have valid PMUs in the CPU map from user requested CPUs. Signed-off-by: Ian Rogers Reviewed-by: Kan Liang --- tools/perf/builtin-record.c | 2 -- tools/perf/builtin-stat.c | 1 - tools/perf/util/target.h | 1 - 3 files changed, 4 deletions(-) diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c index ec0f2d5f189f..d152ab04a209 100644 --- a/tools/perf/builtin-record.c +++ b/tools/perf/builtin-record.c @@ -4204,8 +4204,6 @@ int cmd_record(int argc, const char **argv) goto out; } - rec->opts.target.hybrid = perf_pmu__has_hybrid(); - if (callchain_param.enabled && callchain_param.record_mode == CALLCHAIN_FP) arch__add_leaf_frame_record_opts(&rec->opts); diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c index bc45cee3f77c..c70cb0990661 100644 --- a/tools/perf/builtin-stat.c +++ b/tools/perf/builtin-stat.c @@ -2467,7 +2467,6 @@ int cmd_stat(int argc, const char **argv) goto out; } - target.hybrid = perf_pmu__has_hybrid(); if (evlist__create_maps(evsel_list, &target) < 0) { if (target__has_task(&target)) { pr_err("Problems finding threads of monitor\n"); diff --git a/tools/perf/util/target.h b/tools/perf/util/target.h index 880f1af7f6ad..d582cae8e105 100644 --- a/tools/perf/util/target.h +++ b/tools/perf/util/target.h @@ -17,7 +17,6 @@ struct target { bool default_per_cpu; bool per_thread; bool use_bpf; - bool hybrid; int initial_delay; const char *attr_map; };