| Message ID | 20230601152636.858553-9-nm@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: ti: Fix up references to phandles | expand |
Hi Nishanth On 6/1/2023 8:56 PM, Nishanth Menon wrote: > When referring to array of phandles, using <> to separate the array > entries is better notation as it makes potential errors with phandle and > cell arguments easier to catch. Fix the outliers to be consistent with > the rest of the usage. > > Signed-off-by: Nishanth Menon <nm@ti.com> > --- > arch/arm64/boot/dts/ti/k3-am642-evm.dts | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-am642-evm.dts b/arch/arm64/boot/dts/ti/k3-am642-evm.dts > index 91bdc6026d1f..fef68a778ac9 100644 > --- a/arch/arm64/boot/dts/ti/k3-am642-evm.dts > +++ b/arch/arm64/boot/dts/ti/k3-am642-evm.dts > @@ -467,8 +467,8 @@ &usb0 { > > &cpsw3g { > pinctrl-names = "default"; > - pinctrl-0 = <&rgmii1_pins_default > - &rgmii2_pins_default>; > + pinctrl-0 = <&rgmii1_pins_default>, > + <&rgmii2_pins_default>; Please see, if pinctrl-0 can be defined in one line, instead of two, to be inline with most of changes in this series. > [..]
On 22:32-20230605, Kumar, Udit wrote: > Hi Nishanth > > On 6/1/2023 8:56 PM, Nishanth Menon wrote: > > When referring to array of phandles, using <> to separate the array > > entries is better notation as it makes potential errors with phandle and > > cell arguments easier to catch. Fix the outliers to be consistent with > > the rest of the usage. > > > > Signed-off-by: Nishanth Menon <nm@ti.com> > > --- > > arch/arm64/boot/dts/ti/k3-am642-evm.dts | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/ti/k3-am642-evm.dts b/arch/arm64/boot/dts/ti/k3-am642-evm.dts > > index 91bdc6026d1f..fef68a778ac9 100644 > > --- a/arch/arm64/boot/dts/ti/k3-am642-evm.dts > > +++ b/arch/arm64/boot/dts/ti/k3-am642-evm.dts > > @@ -467,8 +467,8 @@ &usb0 { > > &cpsw3g { > > pinctrl-names = "default"; > > - pinctrl-0 = <&rgmii1_pins_default > > - &rgmii2_pins_default>; > > + pinctrl-0 = <&rgmii1_pins_default>, > > + <&rgmii2_pins_default>; > > > Please see, if pinctrl-0 can be defined in one line, instead of two, to be > inline with most of changes in this series. OK. I think i can respin it with that style change included once other comments flow in.
diff --git a/arch/arm64/boot/dts/ti/k3-am642-evm.dts b/arch/arm64/boot/dts/ti/k3-am642-evm.dts index 91bdc6026d1f..fef68a778ac9 100644 --- a/arch/arm64/boot/dts/ti/k3-am642-evm.dts +++ b/arch/arm64/boot/dts/ti/k3-am642-evm.dts @@ -467,8 +467,8 @@ &usb0 { &cpsw3g { pinctrl-names = "default"; - pinctrl-0 = <&rgmii1_pins_default - &rgmii2_pins_default>; + pinctrl-0 = <&rgmii1_pins_default>, + <&rgmii2_pins_default>; }; &cpsw_port1 { @@ -560,25 +560,25 @@ &mailbox0_cluster7 { }; &main_r5fss0_core0 { - mboxes = <&mailbox0_cluster2 &mbox_main_r5fss0_core0>; + mboxes = <&mailbox0_cluster2>, <&mbox_main_r5fss0_core0>; memory-region = <&main_r5fss0_core0_dma_memory_region>, <&main_r5fss0_core0_memory_region>; }; &main_r5fss0_core1 { - mboxes = <&mailbox0_cluster2 &mbox_main_r5fss0_core1>; + mboxes = <&mailbox0_cluster2>, <&mbox_main_r5fss0_core1>; memory-region = <&main_r5fss0_core1_dma_memory_region>, <&main_r5fss0_core1_memory_region>; }; &main_r5fss1_core0 { - mboxes = <&mailbox0_cluster4 &mbox_main_r5fss1_core0>; + mboxes = <&mailbox0_cluster4>, <&mbox_main_r5fss1_core0>; memory-region = <&main_r5fss1_core0_dma_memory_region>, <&main_r5fss1_core0_memory_region>; }; &main_r5fss1_core1 { - mboxes = <&mailbox0_cluster4 &mbox_main_r5fss1_core1>; + mboxes = <&mailbox0_cluster4>, <&mbox_main_r5fss1_core1>; memory-region = <&main_r5fss1_core1_dma_memory_region>, <&main_r5fss1_core1_memory_region>; };
When referring to array of phandles, using <> to separate the array entries is better notation as it makes potential errors with phandle and cell arguments easier to catch. Fix the outliers to be consistent with the rest of the usage. Signed-off-by: Nishanth Menon <nm@ti.com> --- arch/arm64/boot/dts/ti/k3-am642-evm.dts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)