| Message ID | 20230604121223.9625-6-stefan.wahren@i2se.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: dts: bcm283x: Improve device-trees and bindings | expand |
Hello, On Sun, Jun 04, 2023 at 02:12:18PM +0200, Stefan Wahren wrote: > Convert the DT binding document for pwm-bcm2835 from .txt to YAML. Both dt_binding_check and dtbs_check (for ARCH=arm) are happy, apart from errors like: arch/arm/boot/dts/bcm2711-rpi-4-b.dtb: pwm@7e20c000: #pwm-cells:0:0: 3 was expected From schema: Documentation/devicetree/bindings/pwm/pwm-bcm2835.yaml which is fixed in patch #6. So: Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Who will pick up this patch? Is it supposed to go in via pwm or arm/broadcom? (I suggest the latter.) Best regards Uwe
On Sun, 04 Jun 2023 14:12:18 +0200, Stefan Wahren wrote: > Convert the DT binding document for pwm-bcm2835 from .txt to YAML. > > Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> > --- > .../devicetree/bindings/pwm/pwm-bcm2835.txt | 30 ------------- > .../devicetree/bindings/pwm/pwm-bcm2835.yaml | 43 +++++++++++++++++++ > 2 files changed, 43 insertions(+), 30 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/pwm/pwm-bcm2835.txt > create mode 100644 Documentation/devicetree/bindings/pwm/pwm-bcm2835.yaml > Reviewed-by: Rob Herring <robh@kernel.org>
On Wed, Jun 07, 2023 at 09:56:02AM +0200, Uwe Kleine-König wrote: > Hello, > > On Sun, Jun 04, 2023 at 02:12:18PM +0200, Stefan Wahren wrote: > > Convert the DT binding document for pwm-bcm2835 from .txt to YAML. > > Both dt_binding_check and dtbs_check (for ARCH=arm) are happy, apart > from errors like: > > arch/arm/boot/dts/bcm2711-rpi-4-b.dtb: pwm@7e20c000: #pwm-cells:0:0: 3 was expected > From schema: Documentation/devicetree/bindings/pwm/pwm-bcm2835.yaml > > which is fixed in patch #6. So: > > Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > Who will pick up this patch? Is it supposed to go in via pwm or > arm/broadcom? (I suggest the latter.) The default is the subsystem (pwm). Why not here? Rob
Hi, Am 09.06.23 um 23:59 schrieb Rob Herring: > On Wed, Jun 07, 2023 at 09:56:02AM +0200, Uwe Kleine-König wrote: >> Hello, >> >> On Sun, Jun 04, 2023 at 02:12:18PM +0200, Stefan Wahren wrote: >>> Convert the DT binding document for pwm-bcm2835 from .txt to YAML. >> >> Both dt_binding_check and dtbs_check (for ARCH=arm) are happy, apart >> from errors like: >> >> arch/arm/boot/dts/bcm2711-rpi-4-b.dtb: pwm@7e20c000: #pwm-cells:0:0: 3 was expected >> From schema: Documentation/devicetree/bindings/pwm/pwm-bcm2835.yaml >> >> which is fixed in patch #6. So: >> >> Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> >> >> Who will pick up this patch? Is it supposed to go in via pwm or >> arm/broadcom? (I suggest the latter.) > > The default is the subsystem (pwm). Why not here? i think Uwe's concern is about the fact, that the series is late in cycle. So the chance that the fixing DTS patch 6 miss Linux 6.5 is very high. > > Rob > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Tue, Jun 13, 2023 at 11:02:40AM +0200, Stefan Wahren wrote: > Hi, > > Am 09.06.23 um 23:59 schrieb Rob Herring: > > On Wed, Jun 07, 2023 at 09:56:02AM +0200, Uwe Kleine-König wrote: > > > Hello, > > > > > > On Sun, Jun 04, 2023 at 02:12:18PM +0200, Stefan Wahren wrote: > > > > Convert the DT binding document for pwm-bcm2835 from .txt to YAML. > > > > > > Both dt_binding_check and dtbs_check (for ARCH=arm) are happy, apart > > > from errors like: > > > > > > arch/arm/boot/dts/bcm2711-rpi-4-b.dtb: pwm@7e20c000: #pwm-cells:0:0: 3 was expected > > > From schema: Documentation/devicetree/bindings/pwm/pwm-bcm2835.yaml > > > > > > which is fixed in patch #6. So: > > > > > > Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > > > > > Who will pick up this patch? Is it supposed to go in via pwm or > > > arm/broadcom? (I suggest the latter.) > > > > The default is the subsystem (pwm). Why not here? > > i think Uwe's concern is about the fact, that the series is late in cycle. > So the chance that the fixing DTS patch 6 miss Linux 6.5 is very high. My concern is only that nobody might feel responsible and think the other party will pick up. Thierry didn't pick up patches yet for the next merge window (or I missed it), so I guess it's not yet to late for going in via pwm. I suggest to let it go in via the arm/broadcom tree, to have the whole series together. Best regards Uwe
diff --git a/Documentation/devicetree/bindings/pwm/pwm-bcm2835.txt b/Documentation/devicetree/bindings/pwm/pwm-bcm2835.txt deleted file mode 100644 index f5753b3f79df..000000000000 --- a/Documentation/devicetree/bindings/pwm/pwm-bcm2835.txt +++ /dev/null @@ -1,30 +0,0 @@ -BCM2835 PWM controller (Raspberry Pi controller) - -Required properties: -- compatible: should be "brcm,bcm2835-pwm" -- reg: physical base address and length of the controller's registers -- clocks: This clock defines the base clock frequency of the PWM hardware - system, the period and the duty_cycle of the PWM signal is a multiple of - the base period. -- #pwm-cells: Should be 3. See pwm.yaml in this directory for a description of - the cells format. - -Examples: - -pwm@2020c000 { - compatible = "brcm,bcm2835-pwm"; - reg = <0x2020c000 0x28>; - clocks = <&clk_pwm>; - #pwm-cells = <3>; -}; - -clocks { - .... - clk_pwm: pwm { - compatible = "fixed-clock"; - reg = <3>; - #clock-cells = <0>; - clock-frequency = <9200000>; - }; - .... -}; diff --git a/Documentation/devicetree/bindings/pwm/pwm-bcm2835.yaml b/Documentation/devicetree/bindings/pwm/pwm-bcm2835.yaml new file mode 100644 index 000000000000..15e7fd98defc --- /dev/null +++ b/Documentation/devicetree/bindings/pwm/pwm-bcm2835.yaml @@ -0,0 +1,43 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/pwm/pwm-bcm2835.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: BCM2835 PWM controller (Raspberry Pi controller) + +maintainers: + - Stefan Wahren <stefan.wahren@i2se.com> + +allOf: + - $ref: pwm.yaml# + +properties: + compatible: + const: brcm,bcm2835-pwm + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + "#pwm-cells": + const: 3 + +required: + - compatible + - reg + - clocks + - "#pwm-cells" + +additionalProperties: false + +examples: + - | + pwm@2020c000 { + compatible = "brcm,bcm2835-pwm"; + reg = <0x2020c000 0x28>; + clocks = <&clk_pwm>; + #pwm-cells = <3>; + };
Convert the DT binding document for pwm-bcm2835 from .txt to YAML. Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> --- .../devicetree/bindings/pwm/pwm-bcm2835.txt | 30 ------------- .../devicetree/bindings/pwm/pwm-bcm2835.yaml | 43 +++++++++++++++++++ 2 files changed, 43 insertions(+), 30 deletions(-) delete mode 100644 Documentation/devicetree/bindings/pwm/pwm-bcm2835.txt create mode 100644 Documentation/devicetree/bindings/pwm/pwm-bcm2835.yaml