diff mbox series

arm64: dts: imx8mm-venice: Fix GSC vdd_bat data size.

Message ID 20230605090442.11316-1-nicolas.cavallari@green-communications.fr (mailing list archive)
State New, archived
Headers show
Series arm64: dts: imx8mm-venice: Fix GSC vdd_bat data size. | expand

Commit Message

Nicolas Cavallari June 5, 2023, 9:04 a.m. UTC 
On these boards, vdd_bat is 16bit, not 24bit.  Reading them as 24bit
values yield garbage values because of the additional byte, which is a
configurable fan trippoint[1].

So set their mode to mode_voltage_16bit = 3 instead of
mode_voltage_24bit = 1.

[1]: http://trac.gateworks.com/wiki/gsc#SystemTemperatureandVoltageMonitor

Only tested on GW7100.

Signed-off-by: Nicolas Cavallari <nicolas.cavallari@green-communications.fr>
---
 arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi | 2 +-
 arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts  | 2 +-
 arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts  | 2 +-
 arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dts  | 2 +-
 arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts  | 2 +-
 arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts  | 2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)

Comments

Tim Harvey June 5, 2023, 11:42 p.m. UTC | #1 
On Mon, Jun 5, 2023 at 2:05 AM Nicolas Cavallari
<nicolas.cavallari@green-communications.fr> wrote:
>
> On these boards, vdd_bat is 16bit, not 24bit.  Reading them as 24bit
> values yield garbage values because of the additional byte, which is a
> configurable fan trippoint[1].
>
> So set their mode to mode_voltage_16bit = 3 instead of
> mode_voltage_24bit = 1.
>
> [1]: http://trac.gateworks.com/wiki/gsc#SystemTemperatureandVoltageMonitor
>
> Only tested on GW7100.
>
> Signed-off-by: Nicolas Cavallari <nicolas.cavallari@green-communications.fr>
> ---
>  arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi | 2 +-
>  arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts  | 2 +-
>  arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts  | 2 +-
>  arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dts  | 2 +-
>  arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts  | 2 +-
>  arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts  | 2 +-
>  6 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi
> index 9e7d38872157..c3c9a00f9dfe 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi
> @@ -149,7 +149,7 @@ channel@6 {
>                         };
>
>                         channel@8 {
> -                               gw,mode = <1>;
> +                               gw,mode = <3>;
>                                 reg = <0x08>;
>                                 label = "vdd_bat";
>                         };
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
> index df3b2c93d2d5..0ec2ce3dd721 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
> @@ -354,7 +354,7 @@ channel@6 {
>                         };
>
>                         channel@8 {
> -                               gw,mode = <1>;
> +                               gw,mode = <3>;
>                                 reg = <0x08>;
>                                 label = "vdd_bat";
>                         };
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts
> index c33ec6826d32..03cd29063312 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts
> @@ -327,7 +327,7 @@ channel@6 {
>                         };
>
>                         channel@8 {
> -                               gw,mode = <1>;
> +                               gw,mode = <3>;
>                                 reg = <0x08>;
>                                 label = "vdd_bat";
>                         };
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dts
> index 363020a08c9b..6f26914602c8 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dts
> @@ -293,7 +293,7 @@ channel@6 {
>                         };
>
>                         channel@8 {
> -                               gw,mode = <1>;
> +                               gw,mode = <3>;
>                                 reg = <0x08>;
>                                 label = "vdd_bat";
>                         };
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts b/arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts
> index 7c12518dbc96..2ddba4213001 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts
> @@ -325,7 +325,7 @@ channel@6 {
>                         };
>
>                         channel@8 {
> -                               gw,mode = <1>;
> +                               gw,mode = <3>;
>                                 reg = <0x08>;
>                                 label = "vdd_bat";
>                         };
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> index eb51d648359b..92514b71b5f4 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> @@ -281,7 +281,7 @@ channel@6 {
>                         };
>
>                         channel@8 {
> -                               gw,mode = <1>;
> +                               gw,mode = <3>;
>                                 reg = <0x08>;
>                                 label = "vdd_bat";
>                         };
> --
> 2.40.1

Hi Nicolas,

Thanks for noticing this - these do indeed need to be changed.

Acked-by: Tim Harvey <tharvey@gateworks.com>

Best Regards,

Tim
Shawn Guo June 9, 2023, 2:18 p.m. UTC | #2 
On Mon, Jun 05, 2023 at 11:04:42AM +0200, Nicolas Cavallari wrote:
> On these boards, vdd_bat is 16bit, not 24bit.  Reading them as 24bit
> values yield garbage values because of the additional byte, which is a
> configurable fan trippoint[1].
> 
> So set their mode to mode_voltage_16bit = 3 instead of
> mode_voltage_24bit = 1.
> 
> [1]: http://trac.gateworks.com/wiki/gsc#SystemTemperatureandVoltageMonitor
> 
> Only tested on GW7100.
> 
> Signed-off-by: Nicolas Cavallari <nicolas.cavallari@green-communications.fr>

Applied, thanks!
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi
index 9e7d38872157..c3c9a00f9dfe 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi
@@ -149,7 +149,7 @@  channel@6 {
 			};
 
 			channel@8 {
-				gw,mode = <1>;
+				gw,mode = <3>;
 				reg = <0x08>;
 				label = "vdd_bat";
 			};
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
index df3b2c93d2d5..0ec2ce3dd721 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
@@ -354,7 +354,7 @@  channel@6 {
 			};
 
 			channel@8 {
-				gw,mode = <1>;
+				gw,mode = <3>;
 				reg = <0x08>;
 				label = "vdd_bat";
 			};
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts
index c33ec6826d32..03cd29063312 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts
@@ -327,7 +327,7 @@  channel@6 {
 			};
 
 			channel@8 {
-				gw,mode = <1>;
+				gw,mode = <3>;
 				reg = <0x08>;
 				label = "vdd_bat";
 			};
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dts
index 363020a08c9b..6f26914602c8 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dts
@@ -293,7 +293,7 @@  channel@6 {
 			};
 
 			channel@8 {
-				gw,mode = <1>;
+				gw,mode = <3>;
 				reg = <0x08>;
 				label = "vdd_bat";
 			};
diff --git a/arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts b/arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts
index 7c12518dbc96..2ddba4213001 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts
@@ -325,7 +325,7 @@  channel@6 {
 			};
 
 			channel@8 {
-				gw,mode = <1>;
+				gw,mode = <3>;
 				reg = <0x08>;
 				label = "vdd_bat";
 			};
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
index eb51d648359b..92514b71b5f4 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
@@ -281,7 +281,7 @@  channel@6 {
 			};
 
 			channel@8 {
-				gw,mode = <1>;
+				gw,mode = <3>;
 				reg = <0x08>;
 				label = "vdd_bat";
 			};