Message ID | 20230607014353.3172466-13-irogers@google.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9EA3CC77B7A for <linux-arm-kernel@archiver.kernel.org>; Wed, 7 Jun 2023 02:51:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:From:Subject:References:Mime-Version :Message-Id:In-Reply-To:Date:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BU0oEVQ1H4VGDF2JRcMrbWVZ0DtOSDFKG+plAuzBcS0=; b=nkSlnqWN1HlvTk 1TSwv7o+PVSZtMiZOLXUYR+M/2y+iDoUmQheJyJgdtK2W+f6CVYF+/SSrmnvQKR1BN//YUIM9GegV dxh3NEtDBGuFYuxI/VIXfOBdrdnK6beBHeoyXoPyZpORHLEs4TweWwGB2fPh09Ao+YpVgY44vSHiV LLXFrmgrKEvQn7bdk2jZphuQ6wBk5M2NUBsNMMlln1mQDvUuKLK8HqFNHrBfDkqOEt4Ix3tmSvaBL 7TwZbQOofSKE/8xWTzAqlUw0kGKDKdJOCvGQ8z17kvcpk9XrUWPDSz88G1zVuJJ0jXt/DMmqxmlWx oQRG/hW0OrueCG+SgGjg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q6jG5-0043w4-05; Wed, 07 Jun 2023 02:50:49 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q6jG2-0043v7-2Y for linux-arm-kernel@bombadil.infradead.org; Wed, 07 Jun 2023 02:50:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:To:From:Subject: References:Mime-Version:Message-Id:In-Reply-To:Date:Sender:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description; bh=w532lnbGp5anOsc290HQqo7yKb1jpgu9WE3T8mTec4I=; b=n5uPrl+OMqlEtPx2yNrsAvZrq7 PimlHi2rBhececkuc8/8zt+ICDlcJGhrud5QWtw8kSROnWHzUwH4O9VS8dBQuxlu/MDKEVyItB67g JYXuk5COvwmTQDLi+Jdm5lwRpKsayG19NIaWM0r2PAJSiQnDuCSf9G1oncDa/ksBs1O5p4Tz01sFZ Pu+CYWRqShetrTQfIbvhktBYI8ljxgdQ1dludmDG9sHLQJeCNh1nP6YZUMNmtm2KvYpGwsNyKrK7q bQpZ57detp8rK1Rv6o6jPekdVpUpu02LMeLDa/rSgkUScv+qnU27gy6cFBPQg+H/UuhBNwxuB/swO IcDNacgQ==; Received: from mail-yb1-xb49.google.com ([2607:f8b0:4864:20::b49]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q6iE4-004H0F-0u for linux-arm-kernel@lists.infradead.org; Wed, 07 Jun 2023 01:44:57 +0000 Received: by mail-yb1-xb49.google.com with SMTP id 3f1490d57ef6-bad06cc7fb7so11059276276.3 for <linux-arm-kernel@lists.infradead.org>; Tue, 06 Jun 2023 18:44:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1686102277; x=1688694277; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=w532lnbGp5anOsc290HQqo7yKb1jpgu9WE3T8mTec4I=; b=4Ah77oIcW1fhi4PUaWNVyQCtlDy0ODJswvsNp12X68m9YC8jPYB0wJjfd6u9Nes/qM WyyQujj/FsWMFXlvbodKx9omh3hxJTA8Uzg3HFoKmEIM/4ZXwapKkMv/J4GriQEMoMxK YH6zmrmTRduNvHTbQI16cu3VXzfSd+04P8SdbixqbWrtaMQm+DPgD8pGSVIx6KnvG12E /LsrP+9Ui0xoiwCUGBT8mDlfuLWX+nI5VPmXw+d4/M5gvRf4ahFqHPMpDTdJjkqfjB4r lVY40iPLtZBNOI6+2oGaNs8iPKdw3FbkJaZxO/havOEgdW4CiJu+WhvCcJduPdjNd8TX 3Caw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686102277; x=1688694277; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=w532lnbGp5anOsc290HQqo7yKb1jpgu9WE3T8mTec4I=; b=BwYRZZWvuol9s8Lv9Qr+Aj/xgpvA0P0VY0Y3MCUL1uq49ApgZ/+3tIi7V2bkgFXjVm U/G6Lp2CHmtkzh9VsShXJNm3B90Tjc5Mp67c7Fe8jAMrVhKZGjABgXz3Nr+HU5GsDpPW iN+T7CIpDXOiDhcuIicMhCAQLLfL7PcI+86JwZffmCLuQ8Pbi3vtVfOaMqD+Lu1rZsMB TqMEvx8tG497E2E0t0MHFIGbYcWHw/alTG2x2bvqN1N8U9NpmqqOGbbvoMBLh5sla28V es9grRFk3wkz8HskAexchAnuhDB4cWE+3AM6s5F3rrBgsHBN4eQ8AEOqZz4zDcqisF9X OZRg== X-Gm-Message-State: AC+VfDz9O9PfA+onN1ZBICsMCeIGXnGMQFEVXt4hpKxMWf8wkTflSbaG PUGHrivuctOJXbkK3HUyXNFpnDuVKwNj X-Google-Smtp-Source: ACHHUZ5K3q2BRZQ3BVaY4x+Gz/kg1NLcmTS5uYFGmWeNZGZJl9FEpVaiPom/EYkG6lni3/0N8BD8dY+UkiA/ X-Received: from irogers.svl.corp.google.com ([2620:15c:2d4:203:3c35:209f:5d38:b7a1]) (user=irogers job=sendgmr) by 2002:a05:6902:1204:b0:bac:f582:ef18 with SMTP id s4-20020a056902120400b00bacf582ef18mr2308600ybu.5.1686102277621; Tue, 06 Jun 2023 18:44:37 -0700 (PDT) Date: Tue, 6 Jun 2023 18:43:45 -0700 In-Reply-To: <20230607014353.3172466-1-irogers@google.com> Message-Id: <20230607014353.3172466-13-irogers@google.com> Mime-Version: 1.0 References: <20230607014353.3172466-1-irogers@google.com> X-Mailer: git-send-email 2.41.0.rc0.172.g3f132b7071-goog Subject: [PATCH v1 12/20] perf intel-pt: Fix missed put and leak From: Ian Rogers <irogers@google.com> To: John Garry <john.g.garry@oracle.com>, Will Deacon <will@kernel.org>, James Clark <james.clark@arm.com>, Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linaro.org>, Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, Arnaldo Carvalho de Melo <acme@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>, Ian Rogers <irogers@google.com>, Adrian Hunter <adrian.hunter@intel.com>, Suzuki K Poulose <suzuki.poulose@arm.com>, "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>, Kan Liang <kan.liang@linux.intel.com>, German Gomez <german.gomez@arm.com>, Ali Saidi <alisaidi@amazon.com>, Jing Zhang <renyu.zj@linux.alibaba.com>, " =?utf-8?q?Martin_Li=C5=A1ka?= " <mliska@suse.cz>, Athira Rajeev <atrajeev@linux.vnet.ibm.com>, Miguel Ojeda <ojeda@kernel.org>, ye xingchen <ye.xingchen@zte.com.cn>, Liam Howlett <liam.howlett@oracle.com>, Dmitrii Dolgov <9erthalion6@gmail.com>, "Shawn M. Chapla" <schapla@codeweavers.com>, Yang Jihong <yangjihong1@huawei.com>, K Prateek Nayak <kprateek.nayak@amd.com>, Changbin Du <changbin.du@huawei.com>, Ravi Bangoria <ravi.bangoria@amd.com>, Sean Christopherson <seanjc@google.com>, Raul Silvera <rsilvera@google.com>, Andi Kleen <ak@linux.intel.com>, "Steinar H. Gunderson" <sesse@google.com>, Yuan Can <yuancan@huawei.com>, Brian Robbins <brianrob@linux.microsoft.com>, liuwenyu <liuwenyu7@huawei.com>, Ivan Babrou <ivan@cloudflare.com>, Fangrui Song <maskray@google.com>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, coresight@lists.linaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230607_024440_723825_77F5F388 X-CRM114-Status: GOOD ( 11.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org |
Series |
Reference count checking for thread
|
expand
|
diff --git a/tools/perf/util/intel-pt.c b/tools/perf/util/intel-pt.c index 783ce61c6d25..dbf0bc71a63b 100644 --- a/tools/perf/util/intel-pt.c +++ b/tools/perf/util/intel-pt.c @@ -1280,6 +1280,7 @@ static void intel_pt_add_br_stack(struct intel_pt *pt, pt->kernel_start); sample->branch_stack = pt->br_stack; + thread__put(thread); } /* INTEL_PT_LBR_0, INTEL_PT_LBR_1 and INTEL_PT_LBR_2 */ @@ -3580,6 +3581,7 @@ static void intel_pt_free(struct perf_session *session) zfree(&pt->chain); zfree(&pt->filter); zfree(&pt->time_ranges); + zfree(&pt->br_stack); free(pt); }
Add missing put and free, detected with leak sanitizer. Signed-off-by: Ian Rogers <irogers@google.com> --- tools/perf/util/intel-pt.c | 2 ++ 1 file changed, 2 insertions(+)