From patchwork Wed Jun 7 01:43:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Rogers X-Patchwork-Id: 13269936 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B7D5C7EE37 for ; Wed, 7 Jun 2023 02:49:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:From:Subject:References:Mime-Version :Message-Id:In-Reply-To:Date:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wleg+mJkaYPEw9+y/Wp1ZEWB2i7drYkuRihmwRkzfos=; b=Exza4RaTtMnidY YBuMUvQrIuKzZFg5NAYvDO2qB0/gmRBR7GIlyvA3QkLnC7xlSDa2wpy3b/yPK6AlpbdJaSuawpWL+ AKMdBBcXzZo1irFYvdgpl+i4znABki9bx1EQV/lGEVKO8wgTLgkiw4XCXY3zHZgQukwSmb4c2+ghH i751vlCkbdFkWowQqbp68LRYRVc8iQ4XEtBmSW9iEg+LQp+Mn16y9Iu//bOoH5CIZ9gRfQLfrly2O Dydkdk6ZCFzi+kUgncQfTd+wNtlORSgL0UIlw/Ty7bPStAYDeoOktfnCpPC9XqcuiD6QT90q6HCRZ JTg4qYxocJRAoCv5dwfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q6jEo-0043Qj-0E; Wed, 07 Jun 2023 02:49:30 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q6jEm-0043Pi-02 for linux-arm-kernel@bombadil.infradead.org; Wed, 07 Jun 2023 02:49:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:To:From:Subject: References:Mime-Version:Message-Id:In-Reply-To:Date:Sender:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description; bh=yOIINORTn0PFJFSJlhKwC+O6Tqe9UX93OtBkr06o1MI=; b=bCRADpiCM8PTyPjVEnJIhVYd5u QTgtAYCC5OEAYBkoSQA24h1RvlTAAXF0vPGniIZRT29320dWKTSwLx40ona7ucpvA1/wIiyrbAD2b T7uTCMHxmkrd7rN4WmwtWVjWlDVf7+YW7+bHl5Y4C1ERSWyXLp1auz8R9bLf5mEbh+ErG/PTjsJvd Dc6LRmgdSnPqIseRao5v8gEdoHIV6fRqf6brezpG8FM1Cu77BRMxxcI0gD/eYuKYyLvF2wTYXHVSt 65S5oXrXsCTws+k3yFn1NSlLsF3s2t1m0Nu7INSBocIE90ntFHUAxNzTzc/1YgZ6gdn/FfiWsl5iv hsgL5G/Q==; Received: from mail-yw1-x1149.google.com ([2607:f8b0:4864:20::1149]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q6iEE-004H3k-1M for linux-arm-kernel@lists.infradead.org; Wed, 07 Jun 2023 01:44:52 +0000 Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-56938733c13so90750107b3.1 for ; Tue, 06 Jun 2023 18:44:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1686102288; x=1688694288; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=yOIINORTn0PFJFSJlhKwC+O6Tqe9UX93OtBkr06o1MI=; b=Wa0jHgYu7yo6yDbvDMoChgMV4Y/i3gAhc51C7Y/1Zp4qXLse4hCqY1eFCW8jXhZAeh wVF1lTpIU5m54nO3wa3E4cFY++lS1ESwVmUNBEQV22QkrsV9fPoB0L0YGJtsB92UCjZo VNSS0+rTT7I+GOgWUHqmZOSJjnWWqLzyUwasAanqINU2E7LRBlfYN1DhvY8G1nu08lVv uNaD3E7u6lcFaI8kIuzI5iat8BjY815NhGDQlsZuVPdo0PipMa9wrwJ+OM92XjhB373w VGRvpWwaOSp9/mPj+UTdhsKi4LX9iPjemg84hvvbIdNxJVE2qdStqIAh4n2NzoAV00oQ I8yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686102288; x=1688694288; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yOIINORTn0PFJFSJlhKwC+O6Tqe9UX93OtBkr06o1MI=; b=I0YRHVybChQ1TqOpkySHmOt9p+bFNvjdOzHxB/c/js2Qz9LWgpIcbpdn4n9cwW1Kka VKYkIVvx1OHMAvXOJGl2xCFnQHjURc4dFviNtqAhvokmyA4u2dTveNVGQnOabSHvM5Lr vlXP1/3umm9u+bymEOZqSardZfOBVp2bEd8IpTa5SA7ziJJMXrLgtSTqoiS+nQBoaSom 4qaM+59bzI5Evk87TUtx1s0hggu7jSk8xCK2/XWUmV077Xjnsvy4IqEJLNIr+GlfnE3M Jo5LlpPB8dl3YN9QTD3mUe2eJA1eIKCkfamgy76Udn4geEI9uODLrXEUAJMKsQno15kP oNFw== X-Gm-Message-State: AC+VfDxXPUAZb4LpGwkFcyqRyVDfX+vF4m0ZjFpsvtxFLXmdFoBZgQ8S FirdJMkaH3NpIepzEtxbkXalbWlz+d2w X-Google-Smtp-Source: ACHHUZ6bhSqGSNTPX7PPLeAh4LDoJ50x15oKgeKxKdgw6QbIsf0UJ97hv8l0FaRESJRHlzcYJw/vhj9Npw4v X-Received: from irogers.svl.corp.google.com ([2620:15c:2d4:203:3c35:209f:5d38:b7a1]) (user=irogers job=sendgmr) by 2002:a05:6902:124f:b0:bab:9391:470a with SMTP id t15-20020a056902124f00b00bab9391470amr1478491ybu.0.1686102288644; Tue, 06 Jun 2023 18:44:48 -0700 (PDT) Date: Tue, 6 Jun 2023 18:43:50 -0700 In-Reply-To: <20230607014353.3172466-1-irogers@google.com> Message-Id: <20230607014353.3172466-18-irogers@google.com> Mime-Version: 1.0 References: <20230607014353.3172466-1-irogers@google.com> X-Mailer: git-send-email 2.41.0.rc0.172.g3f132b7071-goog Subject: [PATCH v1 17/20] perf maps: Fix overlapping memory leak From: Ian Rogers To: John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Suzuki K Poulose , "Naveen N. Rao" , Kan Liang , German Gomez , Ali Saidi , Jing Zhang , " =?utf-8?q?Martin_Li=C5=A1ka?= " , Athira Rajeev , Miguel Ojeda , ye xingchen , Liam Howlett , Dmitrii Dolgov <9erthalion6@gmail.com>, "Shawn M. Chapla" , Yang Jihong , K Prateek Nayak , Changbin Du , Ravi Bangoria , Sean Christopherson , Raul Silvera , Andi Kleen , "Steinar H. Gunderson" , Yuan Can , Brian Robbins , liuwenyu , Ivan Babrou , Fangrui Song , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, coresight@lists.linaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230607_024450_910074_CCBDC6E0 X-CRM114-Status: GOOD ( 10.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add a missed free detected by leak sanitizer. Signed-off-by: Ian Rogers --- tools/perf/util/maps.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/perf/util/maps.c b/tools/perf/util/maps.c index 5206a6433117..233438c95b53 100644 --- a/tools/perf/util/maps.c +++ b/tools/perf/util/maps.c @@ -374,6 +374,7 @@ int maps__fixup_overlappings(struct maps *maps, struct map *map, FILE *fp) } put_map: map__put(pos->map); + free(pos); } up_write(maps__lock(maps)); return err;