| Message ID | 20230607020529.22934-1-jiasheng@iscas.ac.cn (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: xlnx: zynqmp_dpsub: Add missing check for dma_set_mask | expand |
Hello Jiasheng, Thank you for the patch. On Wed, Jun 07, 2023 at 10:05:29AM +0800, Jiasheng Jiang wrote: > Add check for dma_set_mask() and return the error if it fails. > > Fixes: d76271d22694 ("drm: xlnx: DRM/KMS driver for Xilinx ZynqMP DisplayPort Subsystem") > Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> > --- > drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c > index bab862484d42..068413be6527 100644 > --- a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c > +++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c > @@ -227,7 +227,9 @@ static int zynqmp_dpsub_probe(struct platform_device *pdev) > dpsub->dev = &pdev->dev; > platform_set_drvdata(pdev, dpsub); > > - dma_set_mask(dpsub->dev, DMA_BIT_MASK(ZYNQMP_DISP_MAX_DMA_BIT)); > + ret = dma_set_mask(dpsub->dev, DMA_BIT_MASK(ZYNQMP_DISP_MAX_DMA_BIT)); > + if (ret) > + return ret; This seems reasonable. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Tomi, would you be able to quickly test this ? > > /* Try the reserved memory. Proceed if there's none. */ > of_reserved_mem_device_init(&pdev->dev);
On 07/06/2023 08:07, Laurent Pinchart wrote: > Hello Jiasheng, > > Thank you for the patch. > > On Wed, Jun 07, 2023 at 10:05:29AM +0800, Jiasheng Jiang wrote: >> Add check for dma_set_mask() and return the error if it fails. >> >> Fixes: d76271d22694 ("drm: xlnx: DRM/KMS driver for Xilinx ZynqMP DisplayPort Subsystem") >> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> >> --- >> drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c >> index bab862484d42..068413be6527 100644 >> --- a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c >> +++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c >> @@ -227,7 +227,9 @@ static int zynqmp_dpsub_probe(struct platform_device *pdev) >> dpsub->dev = &pdev->dev; >> platform_set_drvdata(pdev, dpsub); >> >> - dma_set_mask(dpsub->dev, DMA_BIT_MASK(ZYNQMP_DISP_MAX_DMA_BIT)); >> + ret = dma_set_mask(dpsub->dev, DMA_BIT_MASK(ZYNQMP_DISP_MAX_DMA_BIT)); >> + if (ret) >> + return ret; > > This seems reasonable. > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Tomi, would you be able to quickly test this ? Works for me. Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> Tomi
diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c index bab862484d42..068413be6527 100644 --- a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c +++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c @@ -227,7 +227,9 @@ static int zynqmp_dpsub_probe(struct platform_device *pdev) dpsub->dev = &pdev->dev; platform_set_drvdata(pdev, dpsub); - dma_set_mask(dpsub->dev, DMA_BIT_MASK(ZYNQMP_DISP_MAX_DMA_BIT)); + ret = dma_set_mask(dpsub->dev, DMA_BIT_MASK(ZYNQMP_DISP_MAX_DMA_BIT)); + if (ret) + return ret; /* Try the reserved memory. Proceed if there's none. */ of_reserved_mem_device_init(&pdev->dev);
Add check for dma_set_mask() and return the error if it fails. Fixes: d76271d22694 ("drm: xlnx: DRM/KMS driver for Xilinx ZynqMP DisplayPort Subsystem") Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> --- drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)