diff mbox series

[1/2] dt-bindings: arm: Add Gateworks i.MX8M Mini GW7905-0x board

Message ID 20230607162438.2009738-1-tharvey@gateworks.com (mailing list archive)
State Superseded
Headers show
Series [1/2] dt-bindings: arm: Add Gateworks i.MX8M Mini GW7905-0x board | expand

Commit Message

Tim Harvey June 7, 2023, 4:24 p.m. UTC
Add DT compatible string for a Gateworks GW7905-0x board based on
the i.MX8M Mini from NXP.

Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
 Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski June 7, 2023, 4:27 p.m. UTC | #1
On 07/06/2023 18:24, Tim Harvey wrote:
> Add DT compatible string for a Gateworks GW7905-0x board based on
> the i.MX8M Mini from NXP.
> 
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 2510eaa8906d..b19444dc23da 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -915,6 +915,7 @@ properties:
>                - gw,imx8mm-gw7901          # i.MX8MM Gateworks Board
>                - gw,imx8mm-gw7902          # i.MX8MM Gateworks Board
>                - gw,imx8mm-gw7903          # i.MX8MM Gateworks Board
> +              - gateworks,imx8mm-gw7905-0x # i.MX8MM Gateworks Board

Are you sure you are using correct prefix? Anyway, keep alphabetical
order, so before "gw".

Best regards,
Krzysztof
Conor Dooley June 7, 2023, 4:31 p.m. UTC | #2
On Wed, Jun 07, 2023 at 06:27:28PM +0200, Krzysztof Kozlowski wrote:
> On 07/06/2023 18:24, Tim Harvey wrote:
> > Add DT compatible string for a Gateworks GW7905-0x board based on
> > the i.MX8M Mini from NXP.
> > 
> > Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> > ---
> >  Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > index 2510eaa8906d..b19444dc23da 100644
> > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > @@ -915,6 +915,7 @@ properties:
> >                - gw,imx8mm-gw7901          # i.MX8MM Gateworks Board
> >                - gw,imx8mm-gw7902          # i.MX8MM Gateworks Board
> >                - gw,imx8mm-gw7903          # i.MX8MM Gateworks Board
> > +              - gateworks,imx8mm-gw7905-0x # i.MX8MM Gateworks Board
> 
> Are you sure you are using correct prefix? Anyway, keep alphabetical
> order, so before "gw".

  "^gw,.*":
    description: Gateworks Corporation
                 use "gateworks" vendor prefix
    deprecated: true

 ;)

 I'd be more interested in whether that -0x is a wildcard!
Tim Harvey June 7, 2023, 4:35 p.m. UTC | #3
On Wed, Jun 7, 2023 at 9:31 AM Conor Dooley <conor@kernel.org> wrote:
>
> On Wed, Jun 07, 2023 at 06:27:28PM +0200, Krzysztof Kozlowski wrote:
> > On 07/06/2023 18:24, Tim Harvey wrote:
> > > Add DT compatible string for a Gateworks GW7905-0x board based on
> > > the i.MX8M Mini from NXP.
> > >
> > > Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> > > ---
> > >  Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > index 2510eaa8906d..b19444dc23da 100644
> > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > @@ -915,6 +915,7 @@ properties:
> > >                - gw,imx8mm-gw7901          # i.MX8MM Gateworks Board
> > >                - gw,imx8mm-gw7902          # i.MX8MM Gateworks Board
> > >                - gw,imx8mm-gw7903          # i.MX8MM Gateworks Board
> > > +              - gateworks,imx8mm-gw7905-0x # i.MX8MM Gateworks Board
> >
> > Are you sure you are using correct prefix? Anyway, keep alphabetical
> > order, so before "gw".
>
>   "^gw,.*":
>     description: Gateworks Corporation
>                  use "gateworks" vendor prefix
>     deprecated: true
>
>  ;)
>
>  I'd be more interested in whether that -0x is a wildcard!

The 0x has to do with our part numbering scheme. The gw7905 is the
baseboard and the 0x is the SOM and we have SOM's with part loading
options that do not affect device-tree as reserved for 00 to 09.

I'll fix the sorting for v2.

Thanks,

Tim
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 2510eaa8906d..b19444dc23da 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -915,6 +915,7 @@  properties:
               - gw,imx8mm-gw7901          # i.MX8MM Gateworks Board
               - gw,imx8mm-gw7902          # i.MX8MM Gateworks Board
               - gw,imx8mm-gw7903          # i.MX8MM Gateworks Board
+              - gateworks,imx8mm-gw7905-0x # i.MX8MM Gateworks Board
               - innocomm,wb15-evk         # i.MX8MM Innocomm EVK board with WB15 SoM
               - kontron,imx8mm-sl         # i.MX8MM Kontron SL (N801X) SOM
               - kontron,imx8mm-osm-s      # i.MX8MM Kontron OSM-S (N802X) SOM