diff mbox series

perf: arm_cspmu: Set irq affinitiy only if overflow interrupt is used

Message ID 20230608203742.3503486-1-ilkka@os.amperecomputing.com (mailing list archive)
State New, archived
Headers show
Series perf: arm_cspmu: Set irq affinitiy only if overflow interrupt is used | expand

Commit Message

Ilkka Koskinen June 8, 2023, 8:37 p.m. UTC 
Don't try to set irq affinity if PMU doesn't have an overflow interrupt.

Fixes: e37dfd65731d ("perf: arm_cspmu: Add support for ARM CoreSight PMU driver")
Signed-off-by: Ilkka Koskinen <ilkka@os.amperecomputing.com>
---
 drivers/perf/arm_cspmu/arm_cspmu.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Will Deacon June 9, 2023, 11:16 a.m. UTC | #1 
On Thu, 8 Jun 2023 13:37:42 -0700, Ilkka Koskinen wrote:
> Don't try to set irq affinity if PMU doesn't have an overflow interrupt.
> 
> 

Applied to will (for-next/perf), thanks!

[1/1] perf: arm_cspmu: Set irq affinitiy only if overflow interrupt is used
      https://git.kernel.org/will/c/225d757012e0

Cheers,
diff mbox series

Patch

diff --git a/drivers/perf/arm_cspmu/arm_cspmu.c b/drivers/perf/arm_cspmu/arm_cspmu.c
index 9021d1878250..62be0956dbba 100644
--- a/drivers/perf/arm_cspmu/arm_cspmu.c
+++ b/drivers/perf/arm_cspmu/arm_cspmu.c
@@ -1250,7 +1250,8 @@  static struct platform_driver arm_cspmu_driver = {
 static void arm_cspmu_set_active_cpu(int cpu, struct arm_cspmu *cspmu)
 {
 	cpumask_set_cpu(cpu, &cspmu->active_cpu);
-	WARN_ON(irq_set_affinity(cspmu->irq, &cspmu->active_cpu));
+	if (cspmu->irq)
+		WARN_ON(irq_set_affinity(cspmu->irq, &cspmu->active_cpu));
 }
 
 static int arm_cspmu_cpu_online(unsigned int cpu, struct hlist_node *node)