| Message ID | 20230613070426.467389-3-manikandan.m@microchip.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add support for XLCDC to sam9x7 SoC family. | expand |
On Tue, 13 Jun 2023, Manikandan Muralidharan wrote: > Add compatible for SAM9X7 HLCD controller. > > Signed-off-by: Manikandan Muralidharan <manikandan.m@microchip.com> > --- > drivers/mfd/atmel-hlcdc.c | 1 + > 1 file changed, 1 insertion(+) Applied, thanks
On Wed, Jun 21, 2023 at 06:56:45PM +0100, Lee Jones wrote: > On Tue, 13 Jun 2023, Manikandan Muralidharan wrote: > > > Add compatible for SAM9X7 HLCD controller. > > > > Signed-off-by: Manikandan Muralidharan <manikandan.m@microchip.com> > > --- > > drivers/mfd/atmel-hlcdc.c | 1 + > > 1 file changed, 1 insertion(+) > > Applied, thanks Hmm, Nicolas pointed out that this compatible is likely insufficient, and it'll likely need to be sam9x70 & sam9x75 as there are differences between what each of these SoCs support. https://lore.kernel.org/all/ef09246c-9220-4c71-4ac2-2792d9ca519d@microchip.com/ I guess it doesn't really matter, since the binding didn't get applied and what's in the driver can be arbitrarily changed? Cheers, Conor.
On Wed, 21 Jun 2023, Conor Dooley wrote: > On Wed, Jun 21, 2023 at 06:56:45PM +0100, Lee Jones wrote: > > On Tue, 13 Jun 2023, Manikandan Muralidharan wrote: > > > > > Add compatible for SAM9X7 HLCD controller. > > > > > > Signed-off-by: Manikandan Muralidharan <manikandan.m@microchip.com> > > > --- > > > drivers/mfd/atmel-hlcdc.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > Applied, thanks > > Hmm, Nicolas pointed out that this compatible is likely insufficient, > and it'll likely need to be sam9x70 & sam9x75 as there are differences > between what each of these SoCs support. > https://lore.kernel.org/all/ef09246c-9220-4c71-4ac2-2792d9ca519d@microchip.com/ > I guess it doesn't really matter, since the binding didn't get applied > and what's in the driver can be arbitrarily changed? Unapplied, thanks. :)
diff --git a/drivers/mfd/atmel-hlcdc.c b/drivers/mfd/atmel-hlcdc.c index 3c2414ba4b01..8755c91ce854 100644 --- a/drivers/mfd/atmel-hlcdc.c +++ b/drivers/mfd/atmel-hlcdc.c @@ -141,6 +141,7 @@ static const struct of_device_id atmel_hlcdc_match[] = { { .compatible = "atmel,sama5d3-hlcdc" }, { .compatible = "atmel,sama5d4-hlcdc" }, { .compatible = "microchip,sam9x60-hlcdc" }, + { .compatible = "microchip,sam9x7-xlcdc" }, { /* sentinel */ }, }; MODULE_DEVICE_TABLE(of, atmel_hlcdc_match);
Add compatible for SAM9X7 HLCD controller. Signed-off-by: Manikandan Muralidharan <manikandan.m@microchip.com> --- drivers/mfd/atmel-hlcdc.c | 1 + 1 file changed, 1 insertion(+)